From 4c5ec5ae42f45a7d26018ff547f1489b70a6b1a3 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 15 Nov 2018 08:35:33 -0500 Subject: [PATCH] Bug 21495: Regression in hold override functionality The changes caused by the patches for bug 11512 have broken existing workflows for many libraries and are widely considered to be a bad move. We should revert this behavior. Signed-off-by: Kyle M Hall Signed-off-by: Rhonda Kuiper Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens (cherry picked from commit 398704662487a0c8a3f848a2ae23618ee96406ff) Signed-off-by: Martin Renvoize (cherry picked from commit e3fde6153e66b7c01b804ec7c36e22706abd3e27) Signed-off-by: Lucas Gass --- .../prog/en/modules/admin/preferences/circulation.pref | 2 +- reserve/request.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref index ac1bdaee1e..a98681c162 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ -537,7 +537,7 @@ Circulation: choices: yes: Allow no: "Don't allow" - - staff to force addition of holds even if the patron already has the maximum number of holds allowed. + - staff to override hold policies when placing holds. - - pref: AllowHoldsOnDamagedItems choices: diff --git a/reserve/request.pl b/reserve/request.pl index ee1d8c4962..345293156c 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -479,7 +479,7 @@ foreach my $biblionumber (@biblionumbers) { push( @available_itemtypes, $item->{itype} ); } - elsif ( $can_item_be_reserved eq 'tooManyReserves' && C4::Context->preference('AllowHoldPolicyOverride') ) { + elsif ( C4::Context->preference('AllowHoldPolicyOverride') ) { # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules $item->{override} = 1; $num_override++; -- 2.39.5