From c65bcd02c940eb05f55a3d875815eef4f4cf31f1 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 6 Jun 2024 12:13:38 +0000
Subject: [PATCH] Bug 36694: (follow-up) Remove some missed instances

This patch removes some missed HCSticky code/mentions as well as the
entry on the About page.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../intranet-tmpl/prog/en/modules/authorities/authorities.tt | 2 --
 koha-tmpl/intranet-tmpl/prog/js/members-menu.js              | 2 +-
 koha-tmpl/intranet-tmpl/prog/js/staff-global.js              | 5 +----
 t/mock_templates/intranet-tmpl/prog/en/modules/about.tt      | 5 -----
 4 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
index 85cf272b90..48e0984df2 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
@@ -106,7 +106,6 @@
 
         $("body").on("click", ".show-errors", function(e){
             document.getElementById("form-errors").scrollIntoView();
-            Sticky.hcSticky('refresh');
         });
 
         $("#preview").click(function () {
@@ -371,7 +370,6 @@
         } else {
             $("#check_errors").html( StrAlert );
             $('html, body').animate({ scrollTop: 0 }, 'fast');
-            Sticky.hcSticky('refresh');
             return false;
         }
     }
diff --git a/koha-tmpl/intranet-tmpl/prog/js/members-menu.js b/koha-tmpl/intranet-tmpl/prog/js/members-menu.js
index 09afae4801..3986b3d7b5 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/members-menu.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/members-menu.js
@@ -1,4 +1,4 @@
-/* global borrowernumber advsearch dateformat __ CAN_user_borrowers_delete_borrowers CAN_user_borrowers_edit_borrowers number_of_adult_categories destination Sticky Cookies*/
+/* global borrowernumber advsearch dateformat __ CAN_user_borrowers_delete_borrowers CAN_user_borrowers_edit_borrowers number_of_adult_categories destination Cookies*/
 
 $(document).ready(function(){
     searchfield_date_tooltip("");
diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
index 860ad82fb9..73a4a0251e 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
@@ -1,4 +1,4 @@
-/* global shortcut delBasket Sticky AUDIO_ALERT_PATH Cookies */
+/* global shortcut delBasket AUDIO_ALERT_PATH Cookies */
 /* exported addBibToContext delBibToContext escape_str escape_price openWindow _ removeFocus toUC confirmDelete confirmClone playSound */
 if (KOHA === undefined) var KOHA = {};
 
@@ -177,9 +177,6 @@ $(document).ready(function () {
     $(".toggle_element").on("click", function (e) {
         e.preventDefault();
         $($(this).data("element")).toggle();
-        if (typeof Sticky !== "undefined" && typeof hcSticky === "function") {
-            Sticky.hcSticky("update");
-        }
     });
 
     var navmenulist = $("#navmenulist");
diff --git a/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt b/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt
index e777dae7cb..4a7851c519 100644
--- a/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt
+++ b/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt
@@ -1083,11 +1083,6 @@
             <a href="https://web.archive.org/web/20160819153233/http://orangoo.com:80/labs/GreyBox">GreyBox JavaScript Library v5.54</a>: <a href="https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html">GNU Lesser General Public License, version 2.1</a>
         </p>
 
-        <h2>HC Sticky</h2>
-        <p>
-            <a href="https://somewebmedia.github.io/hc-sticky/">HC Sticky JavaScript library v2.2.7</a>: <a href="https://github.com/somewebmedia/hc-sticky/blob/v2.2.7/LICENSE">MIT License</a>
-        </p>
-
         <h2>Highlight</h2>
         <p>
             <a href="https://johannburkard.de/blog/programming/javascript/highlight-javascript-text-higlighting-jquery-plugin.html">Highlight jQuery Plugin v5.0</a>: MIT License
-- 
2.39.5