From 0787f6649d32c6355baa8482de7c2543f834d59c Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Wed, 16 Oct 2024 16:00:29 +0100
Subject: [PATCH] Bug 33736: Don't allow sorting on Location

We need some special handling to sort on Location as it's got both a
custom renderer and relies on _strings so the ordering and search won't
return expected results without some custom function building.

Sponsored-by: PTFS Europe Ltd
Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../intranet-tmpl/prog/en/modules/circ/pendingbookings.tt   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
index 485d3398af..51f6fdb401 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
@@ -145,7 +145,7 @@
                         "patron",
                         "pickup_library"
                     ],
-                    "order": [[ 1, "asc" ]],
+                    "order": [[ 7, "asc" ]],
                     "columns": [{
                         "data": "booking_id",
                         "title": "Booking ID",
@@ -196,10 +196,10 @@
                         }
                     },
                     {
-                        "data": "",
+                        "data": "item.location",
                         "title": "Location",
                         "searchable": false,
-                        "orderable": true,
+                        "orderable": false,
                         "render": function(data,type,row,meta) {
                             if ( row.item ) {
                                 if ( row.item.checked_out_date ) {
-- 
2.39.5