From 230e1e3e7a17c246ed2a5bbfaccecc4135501183 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Tue, 1 Oct 2024 10:57:25 +0000 Subject: [PATCH] Bug 28575: (QA follow-up) Tidy and test count Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer --- C4/Circulation.pm | 8 ++++---- circ/returns.pl | 5 +---- t/db_dependent/Circulation.t | 6 +++--- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 2bd5efca49..58946ae12a 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2313,13 +2313,13 @@ sub AddReturn { my @object_messages = @{ $updated_item->object_messages }; for my $message (@object_messages) { $messages->{'LostItemFeeRefunded'} = 1 - if $message->message eq 'lost_refunded'; + if $message->message eq 'lost_refunded'; $messages->{'ProcessingFeeRefunded'} = 1 - if $message->message eq 'processing_refunded'; + if $message->message eq 'processing_refunded'; $messages->{'LostItemFeeRestored'} = 1 - if $message->message eq 'lost_restored'; + if $message->message eq 'lost_restored'; $messages->{'LostItemPaymentNotRefunded'} = 1 - if $message->message eq 'payment_not_refunded'; + if $message->message eq 'payment_not_refunded'; if ( $message->message eq 'lost_charge' ) { $issue //= Koha::Old::Checkouts->search( diff --git a/circ/returns.pl b/circ/returns.pl index e41cf9ab26..ea80408684 100755 --- a/circ/returns.pl +++ b/circ/returns.pl @@ -703,10 +703,7 @@ foreach my $code ( keys %$messages ) { elsif ( $code eq 'LostItemFeeRefunded' ) { $template->param( LostItemFeeRefunded => 1 ); } - elsif ( - $code eq 'LostItemPaymentNotRefunded' - ) - { + elsif ( $code eq 'LostItemPaymentNotRefunded' ) { $template->param( LostItemPaymentNotRefunded => 1 ); } elsif ( $code eq 'LostItemFeeCharged' ) { diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 7ca57e12da..39b30dea55 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -18,7 +18,7 @@ use Modern::Perl; use utf8; -use Test::More tests => 75; +use Test::More tests => 76; use Test::Exception; use Test::MockModule; use Test::Deep qw( cmp_deeply ); @@ -6882,8 +6882,8 @@ subtest 'NoRefundOnLostFinesPaidAge' => sub { date => '1970-01-01 14:00:01', amountoutstanding => 0, amount => -5, - interface => 'commandline', - credit_type_code => 'PAYMENT' + interface => 'commandline', + credit_type_code => 'PAYMENT' } )->store(); my $offset = Koha::Account::Offset->new( -- 2.39.5