From 7ab007718748e07ddb07196cce8c8d49cfd76a2a Mon Sep 17 00:00:00 2001 From: David Cook Date: Wed, 23 Oct 2024 22:35:00 +0000 Subject: [PATCH] Bug 38248: Fix condition when item has no return_claims in API response This change just fixes a condition to not break when an item has no return_claims in an API response. Test plan: 0) Apply the patch and koha-plack --restart kohadev NOTE: You may need to rebuild your swagger spec since bug 27919 was pushed redocly bundle --ext json api/v1/swagger/swagger.yaml \ --output api/v1/swagger/swagger_bundle.json 1) Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 2) Create an item with a status of "Lost" 3) Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 4) Note that the item table loads without a problem 5) In system preferences, set the ClaimReturnedLostValue syspref to any value 6) Checkout an item to a patron 7) Click "Claim returned" and make the claim 8) Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 9) Note that the item table loads without a problem and "(Claimed returned") appears for the item that was claimed returned Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer --- .../en/includes/html_helpers/tables/items/catalogue_detail.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc index 8ccce6c896..14b47ecf9c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc @@ -494,7 +494,7 @@ if ( row.lost_status ) { let lost_lib = av_lost.get(row.lost_status.toString()) || _("Unavailable (lost or missing"); - const hasReturnClaims = row.return_claims.filter(rc => !rc.resolution).length > 0 ? true : false + const hasReturnClaims = row.return_claims && row.return_claims.filter(rc => !rc.resolution).length > 0 ? true : false nodes += '%s'.format(escape_str(lost_lib)); if(hasReturnClaims) { nodes += '' + _("(Claimed returned)") + ''; -- 2.39.5