From 4e5a77fb9b0e266d49bfd8d2fa3be76aa8d51e6a Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 31 May 2024 13:14:17 +0000 Subject: [PATCH] Bug 37002: Correct several HTML markup errors This patch makes several minor corrections to HTML markup in the bibliographic detail page template and related include files. This corrects the following validator errors: - Stray end tag a. - Bad value true for attribute disabled on element select. - Bad value true for attribute disabled on element input. - No space between attributes. - Duplicate attribute class. - The value of the for attribute of the label element must be the ID of a non-hidden form control. The patch is simple enough that an inspection of the patch is probably enough, but following is a detailed test plan of the affected areas: - Apply the patch and view the bibliographic detail page in the staff interface. - Under the "Edit" menu in the toolbar, these options should still work correctly: - Modify record using template - Edit items in a batch - Delete items in a batch - Click the "Items" link in the sidebar and find the "Bookable" setting for the title's items. Make at least one item bookable and return to the detail page. - Click the "Place booking" button in the toolbar and confirm that you can successfully place the booking. - If you have access to Novelist, confirm that Novelist content displays correctly on the detail page. - Turn on the "EnableItemGroups" preference. - On the detail page, open the "Item groups" tab and click the "New item group" button. - In the modal, the "Name" and "Display order" labels give focus to the corresponding form field when clicked. - Create an item group. - Under the holdings tab, select one or more items and click "Add/move to item group". - In the modal, clicking the "Item group" label should give focus to the dropdown. Signed-off-by: David Nind Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer (cherry picked from commit 928681a24cbcca64d02822c13776c2f92df2a963) Signed-off-by: Lucas Gass --- .../intranet-tmpl/prog/en/includes/cat-toolbar.inc | 6 +++--- .../html_helpers/tables/items/catalogue_detail.inc | 2 +- .../prog/en/includes/modals/place_booking.inc | 8 ++++---- .../prog/en/modules/catalogue/detail.tt | 12 ++++++------ 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc index 7b3582172f..37a7d05ee0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc @@ -54,7 +54,7 @@ - [% END %] @@ -71,7 +71,7 @@ - [% ELSE %] @@ -88,7 +88,7 @@ - [% ELSE %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc index 4d23b75103..f7ca251121 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc @@ -40,7 +40,7 @@ [% IF ( analyze ) %]Used in[% END %] [% IF Koha.Preference('UseCourseReserves') %]Course reserves[% END %] [% IF ( SpineLabelShowPrintOnBibDetails ) %]Spine label[% END %] - [% IF ( CAN_user_editcatalogue_edit_items ) %] [% END %] + [% IF ( CAN_user_editcatalogue_edit_items ) %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/place_booking.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/place_booking.inc index 1840e2b791..56c5302dd3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/place_booking.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/place_booking.inc @@ -26,20 +26,20 @@
Enter patron card number or partial name
  • - - + + Required
  • -
  • - + Required
    Select the booking start and end date
    diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index 92513e5599..65e395e508 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -742,7 +742,7 @@ [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectStaffProfile') && Koha.Preference('NovelistSelectStaffView') == 'tab' ) %] -
    +
    [% END %] @@ -832,12 +832,12 @@