From 5af5bdea94717c348f1f71610665d7a4467db653 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Sun, 16 Jun 2013 18:05:31 -0700 Subject: [PATCH] Bug 10258: offer to create basket group only when staff user has correct permission If the staff user does not have the group_manage acquisition permission, do not offer to create a new basket group when closing an order basket. This avoids a situation where if a staff member without that permission tries to close a basket and chose the option to create a bakset group, they would be redirected to the login page. To test: [1] Log in as a staff user that does not have the acquisition/group_manage permission. [2] Create a new order basket, attach at least one order line to it, then close it. [3] Verify that the confirmation page does not offer to create a basket group with the same name as the order basket. [4] Log in as a staff user that has the acquisition/group_manage permission. [5] Create and close an order basket. [6] Verify that this time, the confirmation page *does* offer to create a basket group. Signed-off-by: Galen Charlton Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton (cherry picked from commit 14a1bd0e420fd895f989ba88e0cad927697b6173) Signed-off-by: Tomas Cohen Arazi (cherry picked from commit fdf6c3790a8e942be8a3615252b6c214064dd21e) Signed-off-by: Bernardo Gonzalez Kriegel (cherry picked from commit fdf6c3790a8e942be8a3615252b6c214064dd21e) --- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt index e3eceffa61..b141542e38 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt @@ -484,10 +484,12 @@

Are you sure you want to close basket [% basketname|html %]?

+ [% IF ( CAN_user_acquisition_group_manage ) %]

+ [% END %] -- 2.39.5