From 76fa7143c0d93953bef14ba40ade4a8da0ebf39c Mon Sep 17 00:00:00 2001 From: David Cook Date: Thu, 1 Nov 2012 08:17:08 +1100 Subject: [PATCH] Bug 9002 - Remove Problematic Logic from Patron Messaging Preferences Form If you do not have SMSSendDriver set and you do not have a message_transport_type of "sms", you will get an extra table column filled with a hyphen "-" and no corresponding table heading in the Patron Messaging Preferences table. This pushes the table out of alignment so the email checkbox goes under "Digests Only?", the digests checkbox goes under "Do not notify", and the Do not notify checkbox is pushed to the side with no heading. Signed-off-by: Sophie Meynieux Signed-off-by: Katrin Fischer Tested for regressions. All tests and QA script pass. Signed-off-by: Jared Camins-Esakov Signed-off-by: Chris Cormack --- .../prog/en/includes/messaging-preference-form.inc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc index b08c5caa2f..ed6b067b63 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc @@ -52,7 +52,7 @@ [% ELSE %] - [% END %] - [% IF ( messaging_preference.transport_sms ) %] + [% IF ( SMSSendDriver ) %] [% IF ( messaging_form_inactive ) %] [% IF ( messaging_preference.transports_sms ) %] @@ -80,9 +80,6 @@ [% END %] [% END %] [% END %] - [% ELSE %] - - - [% END %] [% IF ( TalkingTechItivaPhone ) %] [% IF ( messaging_form_inactive ) %] -- 2.39.5