From c3a3d3ad242b5ffa17c28430f14a3dc9ca06971a Mon Sep 17 00:00:00 2001 From: Chris Cormack Date: Wed, 21 Sep 2011 15:52:23 +1200 Subject: [PATCH] Bug 6679 : Enable Critic tests for authorities and fixed resulting warnings Signed-off-by: Ian Signed-off-by: Chris Cormack (cherry picked from commit e1bb9e5137110c636334d4039b46c68bfd615b42) Signed-off-by: Chris Nighswonger --- authorities/authorities.pl | 8 ++++---- authorities/detail.pl | 2 +- t/00-testcritic.t | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/authorities/authorities.pl b/authorities/authorities.pl index 2e18332b95..2f82f5a253 100755 --- a/authorities/authorities.pl +++ b/authorities/authorities.pl @@ -47,7 +47,7 @@ builds list, depending on authorised value... =cut -sub build_authorized_values_list ($$$$$$$) { +sub build_authorized_values_list { my ( $tag, $subfield, $value, $dbh, $authorised_values_sth,$index_tag,$index_subfield ) = @_; my @authorised_values; @@ -321,11 +321,11 @@ Create a random value to set it into the input name =cut -sub CreateKey(){ +sub CreateKey { return int(rand(1000000)); } -sub build_tabs ($$$$$) { +sub build_tabs { my ( $template, $record, $dbh, $encoding,$input ) = @_; # fill arrays @@ -499,7 +499,7 @@ sub build_tabs ($$$$$) { } -sub build_hidden_data () { +sub build_hidden_data { # build hidden data => # we store everything, even if we show only requested subfields. diff --git a/authorities/detail.pl b/authorities/detail.pl index 57e07373ec..d4f2c6730c 100755 --- a/authorities/detail.pl +++ b/authorities/detail.pl @@ -50,7 +50,7 @@ use C4::Koha; our ($tagslib); -sub build_tabs ($$$$$) { +sub build_tabs { my ( $template, $record, $dbh, $encoding,$input ) = @_; # fill arrays diff --git a/t/00-testcritic.t b/t/00-testcritic.t index bc7a3cd7f0..19e53fb2d7 100755 --- a/t/00-testcritic.t +++ b/t/00-testcritic.t @@ -16,7 +16,7 @@ my @all_koha_dirs = qw( acqui admin authorities basket C4 catalogue cataloguing labels members misc offline_circ opac patroncards reports reserve reviews rotating_collections serials sms suggestion t tags test tools virtualshelves); -my @dirs = qw( acqui admin basket circ debian errors offline_circ reserve reviews rotating_collections +my @dirs = qw( acqui admin authorities basket circ debian errors offline_circ reserve reviews rotating_collections serials sms virtualshelves ); if ( not $ENV{TEST_QA} ) { -- 2.39.5