From 90d0b9ebfaa705a3fadd61bac22cf31ff0df671b Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 6 Mar 2017 09:44:48 +0100 Subject: [PATCH] Bug 18214: Cannot edit list permissions of a private list If you have disabled the pref OpacAllowPublicListCreation, your users are not able to edit the list permissions for private/shared lists. For a private list they may only be theoretically relevant, but for a shared list they are relevant. Since we do not always know the history of a list (has it been public or shared, does it contains entries from other users) and therefore permissions are even relevant for a currently private list, we should just allow editing these permissions. Test plan: [1] Do not yet apply this patch. [2] Disable OpacAllowPublicListCreation. [3] Create a private list in OPAC. Edit the list. Verify that you do not see the permission combo boxes. [4] Apply this patch. Edit the list again. Do they appear now? Signed-off-by: Marcel de Rooy Signed-off-by: Magnus Enger Works as advertised. Signed-off-by: Mason James --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt index 0e20fcf4c6..a7721a68ae 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt @@ -601,8 +601,8 @@ The library has disabled the ability for patrons to create new public lists. If you make your list private, you will not be able to make it public again. [% END %] - [% INCLUDE list_permissions %] [% END %] + [% INCLUDE list_permissions %] [% UNLESS Koha.Preference('OpacAllowPublicListCreation') OR category == PUBLIC %] -- 2.39.5