]> git.koha-community.org Git - koha.git/log
koha.git
15 years agoBug 2553: Alphabetization of branches in Checkout Statistics form.
Garry Collum [Wed, 22 Jul 2009 00:46:10 +0000 (20:46 -0400)]
Bug 2553: Alphabetization of branches in Checkout Statistics form.

Improvement of previous patch through the use of GetBranchLoop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3322: Fixes expandedSearchOption in opac. Makes "fewer options" possible.
Garry Collum [Wed, 15 Jul 2009 02:16:27 +0000 (22:16 -0400)]
Bug 3322: Fixes expandedSearchOption in opac. Makes "fewer options" possible.

Copies the logic of catalogue/search.pl to fix the expanded search option in opac. When expanded search is the default, it was impossible to go to the "fewer" options.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3421) fix the xhtml in serial biblio search
Nahuel ANGELINETTI [Wed, 15 Jul 2009 13:54:09 +0000 (15:54 +0200)]
(bug #3421) fix the xhtml in serial biblio search

This fix differents errors, and escape in bib search.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3423 - In Cataloging, fields are not ordered by tag number
Frédéric Demians [Wed, 15 Jul 2009 19:59:56 +0000 (21:59 +0200)]
Bug 3423 - In Cataloging, fields are not ordered by tag number

In cataloging, depending on installation and how biblio framework has been
created/modified, fields are not displayed ordered by tag number. For example,
in UNIMARC you can have in tab '2':

  225
  200
  210

This patch order fields in tabs by tag and letter in the tag.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2553: Fixes the alphabetization of the drop-down lists for the Most-Circulated...
Garry Collum [Thu, 16 Jul 2009 20:50:10 +0000 (16:50 -0400)]
Bug 2553: Fixes the alphabetization of the drop-down lists for the Most-Circulated items report.

This patch alphabetizes the descriptions that appear in the  Library, Item type, and patron category drop-down lists of the Most-Circulated Items report form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2553: Fixes the location drop-down alphabetization for the catalog statistics...
Garry Collum [Fri, 17 Jul 2009 23:08:15 +0000 (19:08 -0400)]
Bug 2553: Fixes the location drop-down alphabetization for the catalog statistics report form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2553: Fixes drop-down alphabetization for Circulation Statistics report form.
Garry Collum [Fri, 17 Jul 2009 23:31:55 +0000 (19:31 -0400)]
Bug 2553: Fixes drop-down alphabetization for Circulation Statistics report form.

Fixes alphabetization for the item type, library and collection drop-down lists in the Checkout Statistics wizard form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2553: Fixes drop-down alphabetization in acquisitions - New order and Receive...
Garry Collum [Sat, 18 Jul 2009 00:24:56 +0000 (20:24 -0400)]
Bug 2553: Fixes drop-down alphabetization in acquisitions - New order and Receive order.

Fixes alphabetization of library dropdown in New Order, and the shelf location, item type, and collection code in the Receive Items pages.  This patch takes care of Joann's original purpose of creating the bug enhancement.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2553: Fixes location drop-down alphabetization in Serials Statistics wizard form.
Garry Collum [Fri, 17 Jul 2009 23:54:10 +0000 (19:54 -0400)]
Bug 2553: Fixes location drop-down alphabetization in Serials Statistics wizard form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3418: Fixes the alpha order of the system preference tags.
Garry Collum [Wed, 15 Jul 2009 21:30:31 +0000 (17:30 -0400)]
Bug 3418: Fixes the alpha order of the system preference tags.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3408: Tag cloud says login when logged in - fix.
Garry Collum [Thu, 16 Jul 2009 16:45:29 +0000 (12:45 -0400)]
Bug 3408: Tag cloud says login when logged in - fix.

Changed the logic in the html form to have the login prompt only appear if a user is not logged in.  Separated the hidemylist functionality from the "show tags from other users" option.  Created a link for "hide my tags" or "show my tags" depending on context.

The user can now choose how many tags of other users to show, and can also choose whether to show their own tags or not.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCannot use the same TMPL_VAR to select ALL options.
Joe Atzberger [Mon, 20 Jul 2009 20:37:24 +0000 (15:37 -0500)]
Cannot use the same TMPL_VAR to select ALL options.

Only one select can be selected in this case.  If preselection of search type is
desired, I recommend a clean implementation w/ jquery instead of adding a conditional
for each select.  Please note, that is the only good way to get multiple preselections,
since the same .inc file will be used in each case.  So a single variable like
    <TMPL_IF NAME="index_bc_selected">
cannot be used, since it would set for ALL (3) advanced search dropdowns.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRemove bogus "selected" logic from OPAC adv. search.
Joe Atzberger [Mon, 20 Jul 2009 22:47:42 +0000 (17:47 -0500)]
Remove bogus "selected" logic from OPAC adv. search.

The only reason the TMPL_VAR works where it does is because it is part
of the TMPL_LOOP.  It doesn't mean anything outside the loops, since
*everything* would be selected with the same variable, indiscriminantly.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCorrect broken spacing in docs
Joe Atzberger [Fri, 17 Jul 2009 13:51:04 +0000 (08:51 -0500)]
Correct broken spacing in docs

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdd crontab instructrions.
Joe Atzberger [Fri, 17 Jul 2009 14:56:31 +0000 (09:56 -0500)]
Add crontab instructrions.

Too many people have been confused about crontab dependent functions
"not working" automatically on their installations.  This is probably
because there was no explicit step telling them to schedule the jobs.
The maintainers of the other INSTALL.* docs would be well advised
to insert similar lines in their docs, after confirming proper operation,
since cron/crontab are very system dependent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3393) take care of default rules in overdues
Nahuel ANGELINETTI [Mon, 6 Jul 2009 08:13:54 +0000 (10:13 +0200)]
(bug #3393) take care of default rules in overdues

This fix the overdues notices script, that doesn't take care of default rules.
Now if there is no specific rules for a branchcode, the script use the default rule if it exists.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3398) fix unimarc 210c plugin
Nahuel ANGELINETTI [Wed, 15 Jul 2009 09:01:27 +0000 (11:01 +0200)]
(bug #3398) fix unimarc 210c plugin

this add some args to SearchAuthority();
Fix the pagination, and fix javascript script.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3405) fix on loan list in search result
Nahuel ANGELINETTI [Wed, 8 Jul 2009 11:46:48 +0000 (13:46 +0200)]
(bug #3405) fix on loan list in search result

The hash keys were made using a base and $item->{date_due}, but this key doesn't exists, so the possibility to have duplicate keys exists, and sometimes the others items were not shown. This patch fix this bug.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix BUG #3406 - move tag cloud above 'my tags' for ease of reading
Nicole Engard [Thu, 9 Jul 2009 12:21:04 +0000 (07:21 -0500)]
Fix BUG #3406 - move tag cloud above 'my tags' for ease of reading

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3317: Adds author and added-author to email sent from basket (Cart).
Garry Collum [Sat, 27 Jun 2009 17:48:18 +0000 (13:48 -0400)]
Bug 3317: Adds author and added-author to email sent from basket (Cart).

Adds the author and added author fields to the email that is sent from the shopping cart.  This makes the data sent via email consistent with the data that is viewed in the basket.

There is still a problem with author authority records other than 100 tags appearing correctly in the shopping cart.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoLDAP overhaul
Joe Atzberger [Tue, 30 Jun 2009 14:14:50 +0000 (09:14 -0500)]
LDAP overhaul

Allow replicate and update to be zero.
Break out logic into separate subs.
Do only one bind attempt depending on setting, instead of
necessarily failing first before trying auth_by_bind.

POD added for active directory and to document permutations of
behavior given different conditions.  Fixed mistaken debug lines
that called "print STDERR printf ...", i.e. printed the line to output
and "1" to the error log.  Added principal_name feature for generating
bind user from Koha userid.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3267) show items.uri in opac and intranet
Nahuel ANGELINETTI [Thu, 25 Jun 2009 12:08:22 +0000 (14:08 +0200)]
(bug #3267) show items.uri in opac and intranet

This add a column in normal view, with a link to items.uri URL if it exists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoSearch breadcrumb spacing
Joe Atzberger [Thu, 9 Jul 2009 18:30:36 +0000 (13:30 -0500)]
Search breadcrumb spacing

Also integrated both halves of the "searchdesc" conditional so they use the
same "No Result found!" message and <p> tags.
[LL 570]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3384: Fixes invalid xhtml in advsearch.tmpl
Garry Collum [Thu, 2 Jul 2009 15:41:11 +0000 (11:41 -0400)]
Bug 3384: Fixes invalid xhtml in advsearch.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3395) fix unimarc plugin 225$a
Nahuel ANGELINETTI [Mon, 6 Jul 2009 12:58:48 +0000 (14:58 +0200)]
(bug #3395) fix unimarc plugin 225$a

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Cleaning up toggle variables in readingrec.pl and tmpl.
Garry Collum [Sat, 4 Jul 2009 20:48:17 +0000 (16:48 -0400)]
Bug 2889: Cleaning up toggle variables in readingrec.pl and tmpl.

Removed toggle variable from readingrec.pl and readingrec.tmpl.  Used __odd__ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMoving the text of an error message from the script to the template where it can...
Owen Leonard [Mon, 6 Jul 2009 14:06:51 +0000 (09:06 -0500)]
Moving the text of an error message from the script to the template where it can be translated. Partial fix for bug 1153.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCorrection to enable sending of update emails.
Owen Leonard [Mon, 6 Jul 2009 16:01:20 +0000 (11:01 -0500)]
Correction to enable sending of update emails.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3392: Fixes highlighting in Patrons with no Checkouts report.
Garry Collum [Sun, 5 Jul 2009 00:18:15 +0000 (20:18 -0400)]
Bug 3392: Fixes highlighting in Patrons with no Checkouts report.

Fixed class definition and moved the definition from the <td> tags to the <tr> tags.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix for Bug 2599 - Search limits not working for NoZebra
Ricardo Dias Marques [Fri, 3 Jul 2009 16:03:43 +0000 (16:03 +0000)]
Fix for Bug 2599 - Search limits not working for NoZebra

Adds the change suggested by Amer Denni to fix Bug 2599
in comment #7 at:

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2599

For UNIMARC installations, this patch only works after
updating the "NoZebraIndexes" system preference to
UNIMARC indexes (by default, NoZebraIndexes is being
wrongly set to MARC21 values in UNIMARC installations).

That has also been reported as a Bug, by me (see Bug 2178):

Bug 2178 - "NoZebraIndexes" system preference is being set
to MARC21 values in UNIMARC installations
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2178

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3355 followup - fix XHTML errors
Galen Charlton [Mon, 13 Jul 2009 03:06:35 +0000 (23:06 -0400)]
bug 3355 followup - fix XHTML errors

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3355) add pagination in bib search for subscriptions
Nahuel ANGELINETTI [Wed, 24 Jun 2009 09:00:48 +0000 (11:00 +0200)]
(bug #3355) add pagination in bib search for subscriptions

This add the support of pagination, delete a javascript call, and use now a get method(why post was used?).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3363) do not reload parent if you add a biblio in shelf
Nahuel ANGELINETTI [Thu, 25 Jun 2009 10:44:11 +0000 (12:44 +0200)]
(bug #3363) do not reload parent if you add a biblio in shelf

this patch make the script not reloading the parent if the user add a biblio in a already existing shelf(useless).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoTweaking CSS on z39.50 popup to improve readability (Bug 3269)
Owen Leonard [Mon, 29 Jun 2009 18:23:22 +0000 (13:23 -0500)]
Tweaking CSS on z39.50 popup to improve readability (Bug 3269)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoModifying the text of the error message for clarity and accuracy.
Owen Leonard [Mon, 29 Jun 2009 15:08:30 +0000 (10:08 -0500)]
Modifying the text of the error message for clarity and accuracy.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3360: Fix for unclosed <ol> element in export.tmpl
Garry Collum [Thu, 25 Jun 2009 00:23:39 +0000 (20:23 -0400)]
Bug 3360: Fix for unclosed <ol> element in export.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3362: Fixes invalid xhtml in stage-marc-import.tmpl
Garry Collum [Thu, 25 Jun 2009 02:23:46 +0000 (22:23 -0400)]
Bug 3362: Fixes invalid xhtml in stage-marc-import.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoReformatting interface for Notice Triggers (Bug 3366)
Owen Leonard [Thu, 25 Jun 2009 16:45:02 +0000 (11:45 -0500)]
Reformatting interface for Notice Triggers (Bug 3366)

Breaking up the table of options into three separate ones for first, second, and third notices, each in its own tab.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoPutting text form field first ensures field will correctly be given focus.
Owen Leonard [Thu, 25 Jun 2009 14:02:26 +0000 (09:02 -0500)]
Putting text form field first ensures field will correctly be given focus.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3364) add itemnotes in itemslost report
Nahuel ANGELINETTI [Thu, 25 Jun 2009 13:19:37 +0000 (15:19 +0200)]
(bug #3364) add itemnotes in itemslost report

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3368) index 464$t in unimarc
Nahuel ANGELINETTI [Fri, 26 Jun 2009 07:13:50 +0000 (09:13 +0200)]
(bug #3368) index 464$t in unimarc

this patch add 464$t part of Title index

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3369) add 995$* unimarc fields in "item" index
Nahuel ANGELINETTI [Fri, 26 Jun 2009 11:24:14 +0000 (13:24 +0200)]
(bug #3369) add 995$* unimarc fields in "item" index

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Cleaned up toggle variable in opac-readingrecord.tmpl. Disregard previous...
Garry Collum [Fri, 26 Jun 2009 00:27:56 +0000 (20:27 -0400)]
Bug 2889: Cleaned up toggle variable in opac-readingrecord.tmpl. Disregard previous patch.

Cleaned up toggle variable in opac-readingrecord.pl and tmpl.  Used __odd__ variable instead.

Missed </TMPL_UNLESS> in previous patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Removed toggle variable from z3950_search.pl.
Garry Collum [Fri, 26 Jun 2009 00:35:14 +0000 (20:35 -0400)]
Bug 2889: Removed toggle variable from z3950_search.pl.

Removed unused toggle variable from z3959_search.pl.  Added __odd__ variable to table in z3950_search.tmpl for non-javascript users.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAnother fix for Bug 3119 (Add date due to circ history)
Owen Leonard [Thu, 25 Jun 2009 13:28:42 +0000 (08:28 -0500)]
Another fix for Bug 3119 (Add date due to circ history)

Moving links (non-table data) out of table to correct persistent table border display issue.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3359 changed "registration branch" to "library" on moremember.tmpl for the sake...
Liz Rea [Thu, 25 Jun 2009 14:46:31 +0000 (09:46 -0500)]
bug 3359 changed "registration branch" to "library" on moremember.tmpl for the sake of consistency.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3301 - Speed up rebuild_zebra script
Frédéric Demians [Sun, 14 Jun 2009 05:17:40 +0000 (07:17 +0200)]
Bug 3301 - Speed up rebuild_zebra script

With this patch, rebuild_zebra can re-index a whole Koha DB
quickly:

  rebuild_zebra -r -b -nosanitize

Biblio (authority) records are dump directly in a file
from marcxml field without beeing transformed into
MARC::Record object and corrected.

DOCUMENTATION:

rebuild_zebra.pl new paramater:

-nosanitize  export biblio/authority records directly from DB marcxml
             field without sanitizing records. It speed up
             dump process but could fail if DB contains badly
             encoded records. Works now only with -x and -b

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agocheckoverdues should not require $dbh
Joe Atzberger [Sat, 20 Jun 2009 00:32:42 +0000 (19:32 -0500)]
checkoverdues should not require $dbh

Passing $dbh around is an ancient style that doesn't know
to use C4::Context.  C4::Context->dbh is efficient, especially
for modules that already use Context, including almost all C4.

I also internalized $today into the SQL using NOW() in the query
and removed sth->finish.  Even though I dislike the return style
that gives the count, then the array, I left it becuase I don't
have time to fix/test all the callers.  However, I did convert
it so it doesn't require a $count variable and its own loop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoReturn amount for CREDITS, POD rework.
Joe Atzberger [Sat, 20 Jun 2009 00:32:44 +0000 (19:32 -0500)]
Return amount for CREDITS, POD rework.

The main change here is to get an {amount} field for CREDITS,
not just CHARGES.  I also use a fallback to default value (5)
in case noissuescharge has been deleted or set to 0.

POD is reworked to keep the salient chunks
about patronflags in the correct section and format them for
easier reference.  Deprecated display layer code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCleanup Members.pm - minor
Joe Atzberger [Sat, 20 Jun 2009 00:32:45 +0000 (19:32 -0500)]
Cleanup Members.pm - minor

MoveMemberToDeleted is problematic.  It has a bad name, since it
only copies, not moves.  Also the POD for it referenced a totally
different function name and was largely useless.  Sanity checks inserted.

A couple sth->finish removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRemove unused variable and add FIXME.
Joe Atzberger [Sat, 20 Jun 2009 00:32:43 +0000 (19:32 -0500)]
Remove unused variable and add FIXME.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding installation documentation for Ubuntu
Chris Nighswonger [Tue, 23 Jun 2009 17:18:04 +0000 (13:18 -0400)]
Adding installation documentation for Ubuntu

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug # 2368 Change holds to pull default date range
Jane Wagner [Fri, 19 Jun 2009 13:10:20 +0000 (09:10 -0400)]
Bug # 2368 Change holds to pull default date range

Delivered range was 10 years ago to yesterday; changed default
to be two days ago to today.  Also removed notes field from report
output; 5xx fields can be quite large and including them in the
display resulted in a very lengthy printout for staff.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3350 - fail on queued emails w/ no address
Joe Atzberger [Mon, 22 Jun 2009 19:40:56 +0000 (14:40 -0500)]
Bug 3350 - fail on queued emails w/ no address

If a patron has no email address, we need to avoid stockpiling all
their messages indefinitely.  Otherwise they get mailbombed when
their email IS added.

Note that overdues should not be affected, since the overdues job
checks whether the patron email exists before sending the message
(falling back to the admin).  The other messaging features are the
targets affected by this patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3351 - Limit Serials Search for Biblio to an item type
Frédéric Demians [Tue, 23 Jun 2009 12:01:14 +0000 (14:01 +0200)]
Bug 3351 - Limit Serials Search for Biblio to an item type

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding links to guided reports wizard, dictionary, create from sql to reports home...
Liz Rea [Tue, 23 Jun 2009 18:11:24 +0000 (13:11 -0500)]
Adding links to guided reports wizard, dictionary, create from sql to reports home page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCorrect POD and misleading variable names from copy/paste laziness
Joe Atzberger [Thu, 18 Jun 2009 16:31:32 +0000 (11:31 -0500)]
Correct POD and misleading variable names from copy/paste laziness

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3339) fix rollover showed value
Nahuel ANGELINETTI [Thu, 18 Jun 2009 13:43:29 +0000 (15:43 +0200)]
(bug #3339) fix rollover showed value

This patch just print the value of "whenmorethan1", that was missed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3338: Fix for missing closing brackets in authorities/detail.tmpl
Garry Collum [Thu, 18 Jun 2009 09:18:26 +0000 (05:18 -0400)]
Bug 3338: Fix for missing closing brackets in authorities/detail.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdd MARC21 Fast-add Framework.
Ryan Higgins [Mon, 15 Jun 2009 22:20:29 +0000 (17:20 -0500)]
Add MARC21 Fast-add Framework.

Development is in progress for brief records
in Koha; until that's done, this framework can
be used to add a minimal record.
Created by debra.denault@liblime.com

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Removed toggle from marc_subfields_structure.pl and .tmpl
Garry Collum [Thu, 11 Jun 2009 20:44:30 +0000 (16:44 -0400)]
Bug 2889: Removed toggle from marc_subfields_structure.pl and .tmpl

Removed toggle variable from marc_subfields_structure.pl and marc_subfields_structure.tmpl.  Used template __odd__ variable instead.

Corrected a typo in the highlight class definition in .tmpl.

Corrected a readability issue with the description when deleting a subfield in .tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Removed toggle variable from stopwords.pl and .tmpl.
Garry Collum [Wed, 10 Jun 2009 23:59:01 +0000 (19:59 -0400)]
Bug 2889: Removed toggle variable from stopwords.pl and .tmpl.

Removed toggle variable from stopwords.pl and stopwords.tmpl. Used template __odd_ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCleanup - admin scripts
Joe Atzberger [Fri, 12 Jun 2009 14:25:47 +0000 (09:25 -0500)]
Cleanup - admin scripts

Fixed useless redirect statements that weren't even printed.
Removed unused javascript and script variables;
Removed sth->finish.  Use get instead of post on "cancel" button (no data to post).
Reduce duplicative variables (e.g. scriptname and script_name).

Many other problems are still in the scripts, including use of META-REFRESH instead of
redirect, and the whole idea of redirecting back to the same page for no valid reason.
We should be able to formulate the right response on THIS pass, not ask the browser to start over.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Removed unused toggle variable from pcard-member-search.pl. Added table...
Garry Collum [Fri, 12 Jun 2009 00:42:37 +0000 (20:42 -0400)]
Bug 2889: Removed unused toggle variable from pcard-member-search.pl. Added table highlighting to .tmpl.

Removed unused toggle variable form pcard-member-search.pl.

Added highlighting to pcard-members-search.tmpl and fixed some XHMTL errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Removed toggle variable from aqbudget.tmpl. Used template variable __odd__...
Garry Collum [Mon, 8 Jun 2009 19:52:37 +0000 (15:52 -0400)]
Bug 2889: Removed toggle variable from aqbudget.tmpl. Used template variable __odd__ instead.

Removed toggle variable from aqbudget.pl and aqbudget.tmpl. Used template variable __odd__ instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Added template __odd__ variable to letter.tmpl
Garry Collum [Tue, 9 Jun 2009 22:13:26 +0000 (18:13 -0400)]
Bug 2889: Added template __odd__ variable to letter.tmpl

Used __odd__ variable instead of toggle in letter.tmpl.  No toggle variable was defined in letter.pl.

The table in letter.tmpl uses jquery for highlighting so the above may not be necessary, unless javascript is turned off.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Removed toggle variable from aqbookfund.pl and aqbookfund.tmpl.
Garry Collum [Tue, 9 Jun 2009 22:35:24 +0000 (18:35 -0400)]
Bug 2889: Removed toggle variable from aqbookfund.pl and aqbookfund.tmpl.

Removed toggle variable from aqbookfund.pl and aqbookfund.tmpl. Used template __odd__ variable in aqbookfund.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCleanup authtypes and currency .pl and .tmpl
Joe Atzberger [Wed, 10 Jun 2009 19:04:50 +0000 (14:04 -0500)]
Cleanup authtypes and currency .pl and .tmpl

Removed unused javascript.  Enabled warnings.  Use common $dbh.
Removed sth->finish calls.  Removed toggle code.  Added row highlight where
none had been implemented.  Added some HTML escaping in TMPL.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Removed toggle variables from z3950servers.pl and .tmpl
Garry Collum [Wed, 10 Jun 2009 23:48:40 +0000 (19:48 -0400)]
Bug 2889: Removed toggle variables from z3950servers.pl and .tmpl

Removed toggle variables from z3950servers.pl and z3950servers.tmpl.  Used template __odd__variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Removed toggle variable from roadtype.pl and .tmpl.
Garry Collum [Thu, 11 Jun 2009 00:47:31 +0000 (20:47 -0400)]
Bug 2889: Removed toggle variable from roadtype.pl and .tmpl.

Removed toggle variable from roadtype.pl and roadtype.tmpl.  Corrected typo in class definition in roadtype.tmpl and add highlighting through the templated __odd__ variable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoremoving disused C4::Serials functions
Galen Charlton [Tue, 9 Jun 2009 14:29:14 +0000 (09:29 -0500)]
removing disused C4::Serials functions

The following functions are no longer in use:

* old_newsubscription
* old_modsubscription
* old_getserials

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoremoving disused script
Galen Charlton [Tue, 9 Jun 2009 14:26:11 +0000 (09:26 -0500)]
removing disused script

serials/subscription-copy.pl had been removed
in commit 8c78ff5aa5d52e3b16ea4c45cc38dc6999100ac3 but
for some reason had been accidentally restored in
a subsequent commit.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3316 - Improve last 3 issues displayed on OPAC detail page
Frédéric Demians [Tue, 9 Jun 2009 08:17:07 +0000 (10:17 +0200)]
Bug 3316 - Improve last 3 issues displayed on OPAC detail page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoEscaping HTML in the search results in the Librarian interface
Chris Cormack [Mon, 8 Jun 2009 23:29:48 +0000 (11:29 +1200)]
Escaping HTML in the search results in the Librarian interface

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Removed toggle variable from itemtypes.tmpl. (resubmittal)
Garry Collum [Mon, 8 Jun 2009 23:58:13 +0000 (19:58 -0400)]
Bug 2889: Removed toggle variable from itemtypes.tmpl. (resubmittal)

Removed toggle variable from itemtypes.tmpl and itemtypes.pl.  Used the __odd__ template variable instead.

Resubmittal - first patch contained a typo.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3304) fix notices trigger with diacritics in categorycodes
Nahuel ANGELINETTI [Mon, 8 Jun 2009 09:10:07 +0000 (11:10 +0200)]
(bug #3304) fix notices trigger with diacritics in categorycodes

This just utf8::encode the $key if needed to permit categorycodes with diacritics.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3314: remove disused scripts and API functions
Galen Charlton [Mon, 8 Jun 2009 20:11:42 +0000 (15:11 -0500)]
bug 3314: remove disused scripts and API functions

The distributedto column of the subscription table is
no longer used, having been replaced by the serials
routing list table.  This patch removes two C4::Serials
functions and a script and template, none of which were
reachable by current code:

C4::Serials::GetDistributedTo()
C4::Serials::SetDistributedTo()
koha-tmpl/intranet-tmpl/prog/en/modules/serials/distributedto.tmpl
serials/distributedto.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3313, bulkauthimport.pl skips MARC21 subdivision records.
Brian Harrington [Mon, 8 Jun 2009 19:43:20 +0000 (15:43 -0400)]
Bug 3313, bulkauthimport.pl skips MARC21 subdivision records.

This patch adds the MARC21 subdivsion record tags (18x) to the
block which recognizes and assigns authtypecodes to imported
authority records.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofixed bug resulting in invalid XHTML
Galen Charlton [Mon, 8 Jun 2009 21:57:12 +0000 (16:57 -0500)]
fixed bug resulting in invalid XHTML

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Removed toggle variable from overduerules.tmpl - added __odd__
Garry Collum [Mon, 8 Jun 2009 19:45:01 +0000 (15:45 -0400)]
Bug 2889: Removed toggle variable from overduerules.tmpl - added __odd__

Removed toggle variable from overduerules.pl and overduerules.tmpl. Used template variable __odd__ instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Added shading for alternating rows to authorised_values.tmpl
Garry Collum [Mon, 8 Jun 2009 19:48:21 +0000 (15:48 -0400)]
Bug 2889: Added shading for alternating rows to authorised_values.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Removed toggle variable from koha2marclinks.tmpl. Used template __odd__...
Garry Collum [Mon, 8 Jun 2009 20:54:23 +0000 (16:54 -0400)]
Bug 2889: Removed toggle variable from koha2marclinks.tmpl. Used template __odd__ variable.

Removed toggle variable from koha2marclinks.tmpl and koh2marclinks.pl.  Used template __odd__ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Removed toggle variable from currency.tmpl. Used template __odd__ instead.
Garry Collum [Mon, 8 Jun 2009 21:36:25 +0000 (17:36 -0400)]
Bug 2889: Removed toggle variable from currency.tmpl. Used template __odd__ instead.

Removed toggle variable from currency.tmpl and currency.pl.  Used template __odd_ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3259 part 3: changed last 'Too Many Renewals' to 'Not Renewable'
Galen Charlton [Fri, 5 Jun 2009 22:47:00 +0000 (17:47 -0500)]
bug 3259 part 3: changed last 'Too Many Renewals' to 'Not Renewable'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix Bug 3259 part 2 - fixed terminology on circulation.tmpl
Nicole Engard [Thu, 4 Jun 2009 15:48:32 +0000 (10:48 -0500)]
Fix Bug 3259 part 2 - fixed terminology on circulation.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix Bug 3259 - change 'too many renewals' to 'not renewable'
Nicole Engard [Thu, 4 Jun 2009 15:44:20 +0000 (10:44 -0500)]
Fix Bug 3259 - change 'too many renewals' to 'not renewable'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofollowup: remove unconditional warn
Galen Charlton [Fri, 5 Jun 2009 22:38:32 +0000 (17:38 -0500)]
followup: remove unconditional warn

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoStandalone branch selection
Joe Atzberger [Thu, 4 Jun 2009 17:43:53 +0000 (12:43 -0500)]
Standalone branch selection

selectbranchprinter now posts to itself to set the branch.  That also means that
other pages can set the branch by linking to selectbranchprinter like:
    /cgi-bin/koha/circ/selectbranchprinter.pl?branch=MAIN

We use HTTP_REFERER to allow the user to continue back to wherever they linked from,
defaulting to circulation.pl (the former POST target).

Note that all "branchprinter" functions are basically useless as the data is not
properly handled in the session storage.  Chris C. expects this to be addressed
with later patches for HLT.  There appear to be no 3.0 users of this intended
functionality yet.

Includes squashed patch to fix tmpl and to automatically redirect if there are no
POST params to be recycled.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCleanup selectbranchprinter.pl and .tmpl
Joe Atzberger [Fri, 29 May 2009 21:09:34 +0000 (16:09 -0500)]
Cleanup selectbranchprinter.pl and .tmpl

Use GetBranchesLoop and warnings.  Remove unused code.  Moved the Get's to after auth.
I begin to show how this script will use referer to redirect back to the sending
page upon successful change of branch or printer (see hidden div and recycle_loop).

Indicator for singleBranchMode added.
Also added another helper function for GetBranchesLoop, namely mybranch.  This
encapsulates the logic for finding an intelligent default selection, which is
almost always desirable.

This does not resolve bug 2426, but is work in that direction.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCleanup cities.pl and .tmpl - major
Joe Atzberger [Fri, 5 Jun 2009 17:18:50 +0000 (12:18 -0500)]
Cleanup cities.pl and .tmpl - major

80% of the javascript was junk.
Bad check failed on non-existant field borrowers.select_city.
Enabled warnings.  Reduced "StringSearch" to 3 lines, removed unused args and vars.
Fixed row highlighting and removed "toggle" code.  Etc.

TODO: Stop redirecting to the same page.  Instead get the correct data and show it
on THIS pass.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofollowup previous patch - remove disused $opacstylesheet
Galen Charlton [Fri, 5 Jun 2009 22:06:16 +0000 (17:06 -0500)]
followup previous patch - remove disused $opacstylesheet

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3127 - Stub function prevents undefined reference
Joe Atzberger [Fri, 24 Apr 2009 20:09:55 +0000 (15:09 -0500)]
Bug 3127 - Stub function prevents undefined reference

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2919 -- fix value_builder plugins for dateaccessioned, barcode
Joe Atzberger [Thu, 5 Feb 2009 19:04:20 +0000 (13:04 -0600)]
Bug 2919 -- fix value_builder plugins for dateaccessioned, barcode

This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.

Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery.  Performance improved.

Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding new "tag" icon to tag link in lists interface. Also removing an unwanted ID...
Owen Leonard [Tue, 7 Apr 2009 19:03:02 +0000 (14:03 -0500)]
Adding new "tag" icon to tag link in lists interface. Also removing an unwanted ID from opac-shelves.tmpl markup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMore fixes for Bug 3044
Owen Leonard [Tue, 7 Apr 2009 19:48:16 +0000 (14:48 -0500)]
More fixes for Bug 3044

Hiding the results page's "Add to Cart" links with CSS and revealing them with javascript; Writing the "Add to Cart" link to the opac-detail page with js using the biblionumber embedded in the Export form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoWriting Cart button to DOM with inline script. Fixes Bug 3044 without reintroducing...
Owen Leonard [Wed, 18 Mar 2009 12:49:56 +0000 (07:49 -0500)]
Writing Cart button to DOM with inline script. Fixes Bug 3044 without reintroducing Bug 2887 ("Cart is not translated").

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoNew styles for bulk hold and bulk tag inputs on search results page.
Owen Leonard [Sat, 4 Apr 2009 18:53:48 +0000 (13:53 -0500)]
New styles for bulk hold and bulk tag inputs on search results page.

This change gives the buttons a link style like is used on the lists page. My hope is that the similarity will help the user recognize the function, and the differentiation from the "Save" button will improve the clarity over having three similar buttons.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoInternationalize Amazon support
Frédéric Demians [Wed, 1 Apr 2009 19:36:28 +0000 (21:36 +0200)]
Internationalize Amazon support

With this patch:

  * On Amazon book cover, 'search inside' text is not displayed
    anymore because it's not translatable.
  * Link the image to local Amazon web site 'search inside' service.
    Based on AmazonLocale syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDDCN callnumber splitting with test.
Joe Atzberger [Fri, 13 Mar 2009 14:57:14 +0000 (09:57 -0500)]
DDCN callnumber splitting with test.

Similar to previous patch for LCCN splitting, this patch incorporates
changes to split_ddcn and supplies a test file for verifying proper
operation.  Note that the only previously documented example for intended
operation is included as one of the tests.

This regexps are created to be rather forgiving.  For example, the function
will not choke if two spaces were included where the "spec" (such as it is)
expects one.  Obviously this is because for CN splitting purposes, it doesn't
matter, we're not going to ever split in the middle of whitespace.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix syntax error in tags JavaScript
Galen Charlton [Fri, 3 Apr 2009 16:14:49 +0000 (11:14 -0500)]
fix syntax error in tags JavaScript

FF will tolerate a trailing comma in an
array literal, but Internet Explorer does not.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>