From 25e2da8dbb8b57b35d243d3e1780c5dbc01fa5df Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Fri, 26 Apr 2024 17:43:35 +0000 Subject: [PATCH] Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer --- koha-tmpl/intranet-tmpl/lib/hc-sticky/hc-sticky.js | 11 ----------- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 5 ----- .../prog/en/modules/catalogue/results.tt | 1 - .../prog/en/modules/members/member-flags.tt | 1 - .../tools/automatic_item_modification_by_age.tt | 1 - .../intranet-tmpl/prog/en/modules/tools/letter.tt | 1 - koha-tmpl/opac-tmpl/lib/hc-sticky/hc-sticky.js | 11 ----------- 7 files changed, 31 deletions(-) delete mode 100755 koha-tmpl/intranet-tmpl/lib/hc-sticky/hc-sticky.js delete mode 100755 koha-tmpl/opac-tmpl/lib/hc-sticky/hc-sticky.js diff --git a/koha-tmpl/intranet-tmpl/lib/hc-sticky/hc-sticky.js b/koha-tmpl/intranet-tmpl/lib/hc-sticky/hc-sticky.js deleted file mode 100755 index 3659e08020..0000000000 --- a/koha-tmpl/intranet-tmpl/lib/hc-sticky/hc-sticky.js +++ /dev/null @@ -1,11 +0,0 @@ -/* - * HC-Sticky - * ========= - * Version: 2.2.7 - * Author: Some Web Media - * Author URL: https://github.com/somewebmedia - * Plugin URL: https://github.com/somewebmedia/hc-sticky - * Description: JavaScript library that makes any element on your page visible while you scroll - * License: MIT - */ -"use strict";!function(t,e){if("object"==typeof module&&"object"==typeof module.exports){if(!t.document)throw new Error("HC-Sticky requires a browser to run.");module.exports=e(t)}else"function"==typeof define&&define.amd?define("hcSticky",[],e(t)):e(t)}("undefined"!=typeof window?window:this,function(V){var i,n,Q=V.document,U={top:0,bottom:0,bottomEnd:0,innerTop:0,innerSticker:null,stickyClass:"sticky",stickTo:null,followScroll:!0,responsive:null,mobileFirst:!1,onStart:null,onStop:null,onBeforeResize:null,onResize:null,resizeDebounce:100,disable:!1},Y=function(t,e,o){console.warn("%cHC Sticky:%c "+o+"%c '"+t+"'%c is now deprecated and will be removed. Use%c '"+e+"'%c instead.","color: #fa253b","color: default","color: #5595c6","color: default","color: #5595c6","color: default")},$=function(n,f){var o=this;if(f=f||{},!(n="string"==typeof n?Q.querySelector(n):n))return!1;f.queries&&Y("queries","responsive","option"),f.queryFlow&&Y("queryFlow","mobileFirst","option");var p={},u=$.Helpers,s=n.parentNode;"static"===u.getStyle(s,"position")&&(s.style.position="relative");function d(t){u.isEmptyObject(t=t||{})&&!u.isEmptyObject(p)||(p=Object.assign({},U,p,t))}function t(){return p.disable}function e(){var t,e=p.responsive||p.queries;if(e){var o=V.innerWidth;if(t=f,(p=Object.assign({},U,t||{})).mobileFirst)for(var i in e)i<=o&&!u.isEmptyObject(e[i])&&d(e[i]);else{var n,s=[];for(n in e){var r={};r[n]=e[n],s.push(r)}for(var l=s.length-1;0<=l;l--){var a=s[l],c=Object.keys(a)[0];o<=c&&!u.isEmptyObject(a[c])&&d(a[c])}}}}function i(){var t,e,o,i;I.css=(t=n,e=u.getCascadedStyle(t),o=u.getStyle(t),i={height:t.offsetHeight+"px",left:e.left,right:e.right,top:e.top,bottom:e.bottom,position:o.position,display:o.display,verticalAlign:o.verticalAlign,boxSizing:o.boxSizing,marginLeft:e.marginLeft,marginRight:e.marginRight,marginTop:e.marginTop,marginBottom:e.marginBottom,paddingLeft:e.paddingLeft,paddingRight:e.paddingRight},e.float&&(i.float=e.float||"none"),e.cssFloat&&(i.cssFloat=e.cssFloat||"none"),o.MozBoxSizing&&(i.MozBoxSizing=o.MozBoxSizing),i.width="auto"!==e.width?e.width:"border-box"===i.boxSizing||"border-box"===i.MozBoxSizing?t.offsetWidth+"px":o.width,i),P.init(),y=!(!p.stickTo||!("document"===p.stickTo||p.stickTo.nodeType&&9===p.stickTo.nodeType||"object"==typeof p.stickTo&&p.stickTo instanceof("undefined"!=typeof HTMLDocument?HTMLDocument:Document))),h=p.stickTo?y?Q:u.getElement(p.stickTo):s,z=(R=function(){var t=n.offsetHeight+(parseInt(I.css.marginTop)||0)+(parseInt(I.css.marginBottom)||0),e=(z||0)-t;return-1<=e&&e<=1?z:t})(),v=(H=function(){return y?Math.max(Q.documentElement.clientHeight,Q.body.scrollHeight,Q.documentElement.scrollHeight,Q.body.offsetHeight,Q.documentElement.offsetHeight):h.offsetHeight})(),S=y?0:u.offset(h).top,w=p.stickTo?y?0:u.offset(s).top:S,E=V.innerHeight,N=n.offsetTop-(parseInt(I.css.marginTop)||0),b=u.getElement(p.innerSticker),L=isNaN(p.top)&&-1>>0;if("function"!=typeof t)throw new TypeError(t+" is not a function");for(1GreyBox JavaScript Library v5.54: GNU Lesser General Public License, version 2.1

-

HC Sticky

-

- HC Sticky JavaScript library v2.2.7: MIT License -

-

Highlight

Highlight jQuery Plugin v5.0: MIT License diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt index 879b317681..e4f6638743 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt @@ -798,7 +798,6 @@ [% MACRO jsinclude BLOCK %] [% Asset.js("js/browser.js") | $raw %] - [% Asset.js("lib/hc-sticky/hc-sticky.js") | $raw %] [% Asset.js("js/coce.js") | $raw %] [% Asset.css("css/humanmsg.css") | $raw %] [% Asset.js("lib/jquery/plugins/humanmsg.js") | $raw %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt index 49bc8f8ebc..15789ad090 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt @@ -136,7 +136,6 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'str/members-menu.inc' %] [% Asset.js("js/members-menu.js") | $raw %] - [% Asset.js("lib/hc-sticky/hc-sticky.js") | $raw %]