From ea598df62484d62db140f988002ae2cbcf16d98e Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Fri, 13 May 2016 14:43:52 +0100
Subject: [PATCH] Bug 16504: (follow-up for bug 15163) Do not remove attributes
 of other patrons
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Simple patch for a silly error, this single line is going to fix a
critical bug.
If a patron attribute is limited to a library, all the values for that attributes
for every patrons will be deleted.

Test plan:
Create a patron attribute limited to a library
Set the the attribute for a patron
Set the the attribute for another patron
=> Without this patch applied, the attribute's value for the first
patron is deleted
=> With this patch applied, the 2 values exist in the DB after the
second edition

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit da94410ab5022c3bd97fba1878673149802db584)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
(cherry picked from commit 247bd55876a4e930934419070fc926a656a0d9d7)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
---
 C4/Members/Attributes.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/C4/Members/Attributes.pm b/C4/Members/Attributes.pm
index 2f560c7544..1f5a3f0286 100644
--- a/C4/Members/Attributes.pm
+++ b/C4/Members/Attributes.pm
@@ -259,7 +259,7 @@ sub DeleteBorrowerAttributes {
     $query .= $branch_limit
         ? q{
             LEFT JOIN borrower_attribute_types_branches ON bat_code = code
-            WHERE b_branchcode = ? OR b_branchcode IS NULL
+            WHERE ( b_branchcode = ? OR b_branchcode IS NULL )
                 AND borrowernumber = ?
         }
         : q{
-- 
2.39.5