]> git.koha-community.org Git - koha.git/commit
Bug 27549: "use of uninitialized value" warning on renew.pl
authorPetro Vashchuk <stalkernoid@gmail.com>
Mon, 25 Jan 2021 15:37:37 +0000 (17:37 +0200)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Thu, 11 Feb 2021 05:43:02 +0000 (06:43 +0100)
commit14e28d9efb7c72c1461ef6105d109d64942cf69a
tree79d46899ab4b1182bc720bc0586648a8b985634c
parent8f4dbfbf50cb027a133c28e5240a5c1c996e648d
Bug 27549: "use of uninitialized value" warning on renew.pl

On the beginning we have empty "barcode" parameter for this form, but that not taken into account in regular expression  warning emitted: "Use of uninitialized value $barcode in substitution (s///) at /usr/share/koha/intranet/cgi-bin/circ/renew.pl line 47." in renew.pl
Fixed by making $barcode to become an empty string by default.

To reproduce:
    1) Head over to the "Circulation -> Renew" page.
    2) Check intranet-error.log there will be a warning "Use of uninitialized value $barcode in substitution (s///) at /usr/share/koha/intranet/cgi-bin/circ/renew.pl line 47".
    3) Apply the patch, refresh the "Renew" page.
    4) Ensure that the new "use of uninitialized value" warnings didn't appear in the console.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 1af07787032275813e1e458cfed8504b482cd1c6)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit fa472369c034cbcda80f6025ab3fbdbed58bda7c)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
(cherry picked from commit b3a2e405a4ff7330771b7bc81f724e2992e0d904)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
circ/renew.pl