]> git.koha-community.org Git - koha.git/commit
Bug 7904 Change SIP modules to use standard LIB path
authorColin Campbell <colin.campbell@ptfs-europe.com>
Thu, 30 Oct 2014 15:36:09 +0000 (15:36 +0000)
committerChris Cormack <chrisc@catalyst.net.nz>
Wed, 20 May 2015 22:24:02 +0000 (10:24 +1200)
commit26396b5c3571420d0e28634f216fcd4c05432dca
tree5a6b597fb48679a49e50ef80a678ace44585d706
parent7c82ec31ff7deb6f7e3321eb0f0b237b78960711
Bug 7904 Change SIP modules to use standard LIB path

For historical reasons the SIPServer and SIP modules
have used an extra module path in addition to the
standard Koha one. This has caused numerous irritants
in attempting to set up scripts and basic tests. It
does not help in attempting to modify or debug
this code

This patch changes the package value in the modules
under the C4/SIP directory and makes calls to
them use the full package name.

Where the export mechanism was being short circuited
routines have been explicitly exported and imported
declarations of 'use ILS' when that module was
not being used and which only generated warnings
have been removed.

As a lot of the changes affect lines where
an object is instantiated with new. The opportunity
has been taken to replace the ambiguous indirect
syntax with the preferred direct call

In intializing ILS the full path is added as this
will not require any changes to existing configs.
I suspect this feature is unused, and adds
obfuscation rather than flexibility but have kept
the feature as we need this change in order to
rationalize and extend the testing of the server.

The visible difference is that with the normal Koha
PERL5LIB setting. Compilation of Modules under C4/SIP
should be successful and not fail with unlocated modules,
allowing developers to see any perl warnings

All the SIP modules can now be run through the tests
in t/00-load.t now except for SIPServer itself

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit d85f757ce7bf446705a8d76bc0d2280705a2d88d)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Conflicts:
C4/SIP/ILS.pm
C4/SIP/ILS/Transaction/Checkout.pm
41 files changed:
C4/SIP/ILS.pm
C4/SIP/ILS/Item.pm
C4/SIP/ILS/Patron.pm
C4/SIP/ILS/Transaction.pm
C4/SIP/ILS/Transaction/Checkin.pm
C4/SIP/ILS/Transaction/Checkout.pm
C4/SIP/ILS/Transaction/FeePayment.pm
C4/SIP/ILS/Transaction/Hold.pm
C4/SIP/ILS/Transaction/Renew.pm
C4/SIP/ILS/Transaction/RenewAll.pm
C4/SIP/SIPServer.pm
C4/SIP/Sip.pm
C4/SIP/Sip/Checksum.pm
C4/SIP/Sip/Configuration.pm
C4/SIP/Sip/Configuration/Account.pm
C4/SIP/Sip/Configuration/Institution.pm
C4/SIP/Sip/Configuration/Service.pm
C4/SIP/Sip/Constants.pm
C4/SIP/Sip/MsgType.pm
C4/SIP/example_institution_dump.sh
C4/SIP/interactive_item_dump.pl
C4/SIP/interactive_patron_check_password.pl
C4/SIP/interactive_patron_dump.pl
C4/SIP/interactive_renew_all_dump.pl
C4/SIP/t/000_sc_config_auth.t
C4/SIP/t/00sc_status.t
C4/SIP/t/01patron_status.t
C4/SIP/t/02patron_info.t
C4/SIP/t/03checkout.t
C4/SIP/t/04patron_status.t
C4/SIP/t/05block_patron.t
C4/SIP/t/06patron_enable.t
C4/SIP/t/07hold.t
C4/SIP/t/08checkin.t
C4/SIP/t/09renew.t
C4/SIP/t/10renew_all.t
C4/SIP/t/11item_info.t
C4/SIP/t/SIPtest.pm
C4/SIP/xmlparse.pl
t/00-load.t
t/SIP_Sip.t