]> git.koha-community.org Git - koha.git/commit
Bug 10258: offer to create basket group only when staff user has correct permission
authorGalen Charlton <gmc@esilibrary.com>
Mon, 17 Jun 2013 01:05:31 +0000 (18:05 -0700)
committerBernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Sun, 4 Aug 2013 22:02:20 +0000 (19:02 -0300)
commit5af5bdea94717c348f1f71610665d7a4467db653
treea43a0f5c51c3ec233a89d50c934dc78720f616e8
parent4c3032a22c9e9f713b95df38e990c451d7cf5506
Bug 10258: offer to create basket group only when staff user has correct permission

If the staff user does not have the group_manage acquisition permission,
do not offer to create a new basket group when closing an order basket.

This avoids a situation where if a staff member without that permission tries
to close a basket and chose the option to create a bakset group, they would
be redirected to the login page.

To test:

[1] Log in as a staff user that does not have
    the acquisition/group_manage permission.
[2] Create a new order basket, attach at least one
    order line to it, then close it.
[3] Verify that the confirmation page does not
    offer to create a basket group with the
    same name as the order basket.
[4] Log in as a staff user that has the
    acquisition/group_manage permission.
[5] Create and close an order basket.
[6] Verify that this time, the confirmation page
    *does* offer to create a basket group.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 14a1bd0e420fd895f989ba88e0cad927697b6173)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit fdf6c3790a8e942be8a3615252b6c214064dd21e)
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
(cherry picked from commit fdf6c3790a8e942be8a3615252b6c214064dd21e)
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt