]> git.koha-community.org Git - koha.git/commit
Bug 17901: Fix possible SQL injection in shelf editing
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 13 Jan 2017 16:03:41 +0000 (17:03 +0100)
committerJulian Maurice <julian.maurice@biblibre.com>
Mon, 30 Jan 2017 15:28:57 +0000 (16:28 +0100)
commit5b03c19c124cae4312e1d7aa3b8fd979927b606d
tree933b43c972d9ff7b41ed372683e150a21b8daa68
parent72d905d8dc0547c0ecff34b99eacaf43ea37c4c9
Bug 17901: Fix possible SQL injection in shelf editing

It has been reported that
/cgi-bin/koha/opac-shelves.pl?op=edit&referer=view&shelfnumber=146&owner=4&shelfname=testX&sortfield=titleaaaaaa\`&category=1

Could lead to SQL injection
Actually it explodes because the generated SQL query is not correctly formated.

However it would be good to limit the possible values for sortfield.

This vulnerability has been reported by MDSec.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 45cffd874c62c7b090390c5fb3c955c31f524608)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
opac/opac-shelves.pl
virtualshelves/shelves.pl