]> git.koha-community.org Git - koha.git/commit
Bug 12876 - Reserve in waiting/transfer status may be cancelled by user
authorRafal Kopaczka <rkk0@poczta.onet.pl>
Fri, 5 Sep 2014 12:50:15 +0000 (14:50 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 2 Oct 2014 07:42:56 +0000 (09:42 +0200)
commit6014b9699e921312f38848543b2eaf72a419dfeb
tree8706d57497478e4bb5d4eef12636946bb67cb5dd
parent214e87d886faaf7abf64c1dc83d3b590d6adc8dc
Bug 12876 - Reserve in waiting/transfer status may be cancelled by user

User may cancel his own reservation at waiting or in transit status
through calling opac-modrequest.pl. Cancel button is disabled in
interface but possibility to cancel should be checked also in
opac-moderequest.pl, before calling CancelReserve().
Similar situation is with opac-modrequest-suspend.pl

This patch provides new soubroutine to chceck if user can cancel given
reserve. It's possible only when he's owner of hold and hold isn't in
transfer or waiting status.

Additionaly there are new test for this function in Reserves.t

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests, QA script and new tests.
Works as described, tested with:
.../cgi-bin/koha/opac-modrequest.pl?reserve_id=XXX

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Conflicts:
t/db_dependent/Reserves.t

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit c0ab862f4a902ce261b9b8870c169f6fe27711e1)

Conflicts:
opac/opac-modrequest-suspend.pl
C4/Reserves.pm
opac/opac-modrequest.pl
t/db_dependent/Reserves.t