]> git.koha-community.org Git - koha.git/commit
Bug 37316: Treat empty string barcodes as undef
authorLucas Gass <lucas@bywatersolutions.com>
Thu, 11 Jul 2024 17:17:29 +0000 (17:17 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Wed, 17 Jul 2024 21:11:42 +0000 (21:11 +0000)
commit8bd61eba3dbfd9bdb664ac35045b79f7fccb9c1f
tree3c27d35acdf23ef5f3cee3535d624de1d31b6029
parent9a50edfa7fa11d617059f1eeb484187e1876395f
Bug 37316: Treat empty string barcodes as undef

To test:
1.Add the following to MarcItemFieldsToOrder:

homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
price: 949$g|949$j
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l
coded_location_qualifier: 949$f
enumchron: 949$h

2. Add the following to MarcFieldsToOrder:

price: 949$g
quantity: 949$k
budget_code: 949$l
discount: 949$m
sort1: 949$n
sort2: 949$q

3. Acquisitions > Find a vendor
4. Create a new basket -> Add to basket -> From new file
5. Use the file uplodaded in this bug report.
6. Set format to MARCXML and stage for import.
7. Add staged files to basket
8. Select all, make sure you add an item type, and choose 'Do not look for matching records'
9. Save and kaboom.
10. APPLY PATCH and restart_all
11. Follow the steps again, this time no kaboom.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit b68373ae429408fb5291c6dbe5e7bebe27e40e5f)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Koha/Item.pm