]> git.koha-community.org Git - koha.git/commit
Bug 11912: (refactoring followup) make GetMarcISBN implement its advertised API
authorTomas Cohen Arazi <tomascohen@gmail.com>
Mon, 10 Mar 2014 14:52:19 +0000 (11:52 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 13 Aug 2014 07:40:21 +0000 (09:40 +0200)
commitc4d72c760f758063efca8a0b1875084f625dada5
tree09a58c30d8731428e4210ded8b0b8a76a9cd2899
parentd2d5600cdc8d629a77e3eaad42b24ffdd3b1b59e
Bug 11912: (refactoring followup) make GetMarcISBN implement its advertised API

The current implementation of GetMarcISBN contradicts the documented API.
It currently returns an array of hashes with only one key (marcisbn)
which doesn't add any value to it.

I chose to fix GetMarcISBN to honour the API instead of changing thex
 docs, because it seems a really silly change.

To test:
- Run:
  prove t/db_dependent/Biblio.t
=> SUCCESS
- catalogue/detail.pl should correctly show ISBNs.
- opac/opac-detail.pl should correctly show ISBNs in both prog and bootstrap.
- opac-opac-sendshelf.pl should correctly show ISBNs in the email.

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 774483772b2a7ff8ebdb8a9aeac82881e7c858cf)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Biblio.pm
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
koha-tmpl/opac-tmpl/prog/en/modules/opac-sendshelf.tt
t/db_dependent/Biblio.t