]> git.koha-community.org Git - koha.git/commit
Bug 9454: Use placeholders when adding basket
authorColin Campbell <colin.campbell@ptfs-europe.com>
Wed, 23 Jan 2013 10:52:28 +0000 (10:52 +0000)
committerChris Cormack <chris@bigballofwax.co.nz>
Sat, 16 Feb 2013 05:28:29 +0000 (18:28 +1300)
commitf4bc342e74f785f5c598c1d1e03e5dc3f6388159
tree90c4ac17ce3835cb5a26366c42455856e0ba17f7
parent1e02a2a4d1094703334b0dec7588da6b0dd7a51c
Bug 9454: Use placeholders when adding basket

Should always use placeholders when passing variables
to DBI; avoids unforeseen bugs and security issues.

Also:

- reformated the long lists of parameters to add CR
- moved the setting of defaults out of the call to ModBasket to
  clarify code
- Setting parameters to undef if they were not defined
  was unnecessary bloat and obscuration

Testing:
Patch should not change functional behaviour. To test check that
order baskets can still be correctly created.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass.
Created a new basket, added order lines and closed basket.
Checked everything worked in the staff interface, also checked
the entry for the new basket in aqbasket in the database.
Logs are clean too.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
C4/Acquisition.pm