From fa13ec2e9360ce08728644a48165d0eadda9752c Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Mon, 11 Apr 2022 21:36:16 +0000 Subject: [PATCH] Bug 30510: Add Patron reason column to suggestion tables To test: 1. Make some patron reasons for suggestion via Home > Administration > Authorized values > OPAC_SUG 2. Give those reasons a description. 3. Make several suggestions via staff client and/or OPAC and apply some of the reasons you just made 4. Apply patch 5. Go to Home > Acquistions > Suggestions management 6. Give some of the suggestions some different status (PENDING/REJECTED/ACCEPTED/ect) 7. Make sure on each of the tables you can see the column 'Patron reason' 8. Go to Administration > Table settings and attempt to hide the column. 9. Confirm that the column is properly hidden on the Suggestions management page Signed-off-by: Rhonda Kuiper Signed-off-by: Katrin Fischer Signed-off-by: Fridolin Somers --- admin/columns_settings.yml | 2 ++ .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 2 ++ 2 files changed, 4 insertions(+) diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml index bd83299c2c..6760a30c42 100644 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@ -174,6 +174,8 @@ modules: columnname: suggested_by - columnname: suggested_on + - + columnname: patron_reason - columnname: managed_by - diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt index 78da04cc78..8a06dceea3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ -731,6 +731,7 @@ Suggestion Suggested by Suggested on + Patron reason Managed by Managed on Last modification by @@ -791,6 +792,7 @@ [% IF ( suggestions_loo.suggesteddate ) %][% suggestions_loo.suggesteddate | $KohaDates %][% END %] + [% AuthorisedValues.GetByCode( 'OPAC_SUG', suggestions_loo.patronreason ) | html %] [% suggestions_loo.surnamemanagedby | html %][% IF ( suggestions_loo.firstnamemanagedby ) %], [% suggestions_loo.firstnamemanagedby | html %][% END %] -- 2.39.5