From aceb98983267f6ef0ac735ec334ffd6674275936 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 5 Oct 2017 12:17:33 -0300 Subject: [PATCH] Bug 15685: Add tests for Koha::Acquisition::Order->basket Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart --- Koha/Acquisition/Order.pm | 2 +- t/db_dependent/Koha/Acquisition/Order.t | 57 +++++++++++++++++++++++++ 2 files changed, 58 insertions(+), 1 deletion(-) create mode 100644 t/db_dependent/Koha/Acquisition/Order.t diff --git a/Koha/Acquisition/Order.pm b/Koha/Acquisition/Order.pm index 5f7b7d940d..bbad104117 100644 --- a/Koha/Acquisition/Order.pm +++ b/Koha/Acquisition/Order.pm @@ -109,7 +109,7 @@ Returns the basket associated to the order. sub basket { my ( $self ) = @_; - return Koha::Acquisition::Baskets->find( $self->{basketno} ); + return Koha::Acquisition::Baskets->find( $self->basketno ); } =head2 Internal methods diff --git a/t/db_dependent/Koha/Acquisition/Order.t b/t/db_dependent/Koha/Acquisition/Order.t new file mode 100644 index 0000000000..f597453f8d --- /dev/null +++ b/t/db_dependent/Koha/Acquisition/Order.t @@ -0,0 +1,57 @@ +#!/usr/bin/perl + +# Copyright 2017 Koha Development team +# +# This file is part of Koha +# +# Koha is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# Koha is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with Koha; if not, see . + +use Modern::Perl; + +use Test::More tests => 1; + +use t::lib::TestBuilder; +use t::lib::Mocks; + +use Koha::Database; + +my $schema = Koha::Database->schema; +my $builder = t::lib::TestBuilder->new; + +subtest 'basket() tests' => sub { + + plan tests => 2; + + $schema->storage->txn_begin; + + my $basket = $builder->build_object( + { + class => 'Koha::Acquisition::Baskets' + } + ); + my $order = $builder->build_object( + { + class => 'Koha::Acquisition::Orders', + value => { basketno => $basket->basketno } + } + ); + + my $retrieved_basket = $order->basket; + is( ref($retrieved_basket), 'Koha::Acquisition::Basket', + 'Type is correct for ->basket' ); + is_deeply( $retrieved_basket->unblessed, + $basket->unblessed, "Correct basket found and updated" ); + + $schema->storage->txn_rollback; +}; -- 2.39.5