From 7c0ed91c80b58dcb9d7bc9cedaf4b67ca10928b3 Mon Sep 17 00:00:00 2001 From: Matt Blenkinsop Date: Thu, 23 May 2024 08:32:22 +0000 Subject: [PATCH] Bug 36935: Remove warning if file parsing is successful This patch removes the logged warning if a file parse is successful. Test plan: 1) prove t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t 2) The output will have a logged message - 'EOF - End of data in parsing input stream' 3) Apply patch 4) Repeat step 1 5) The warning will be gone Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer --- Koha/BackgroundJob/ImportKBARTFile.pm | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/Koha/BackgroundJob/ImportKBARTFile.pm b/Koha/BackgroundJob/ImportKBARTFile.pm index d17dcf502f..b1da1bb06f 100644 --- a/Koha/BackgroundJob/ImportKBARTFile.pm +++ b/Koha/BackgroundJob/ImportKBARTFile.pm @@ -241,14 +241,16 @@ sub read_file { my $headers_to_check = $csv->getline($fh); my $column_headers = rescue_EBSCO_files($headers_to_check); my $lines = $csv->getline_all( $fh, 0 ); - - my ( $cde, $str, $pos ) = $csv->error_diag(); - my $error = $cde ? "$cde, $str, $pos" : ""; - warn $error if $error; - close($fh); - return ( $column_headers, $lines, $error ); + unless($csv->eof()) { + my ( $cde, $str, $pos ) = $csv->error_diag(); + my $error = $cde ? "$cde, $str, $pos" : ""; + warn $error if $error; + return ( $column_headers, $lines, $error ); + } + + return ( $column_headers, $lines ); } =head3 create_title_hash_from_line_data -- 2.39.5