]> git.koha-community.org Git - koha.git/commit
Bug 13502: Code introcduced in 1861 wrongly assumes a null userid is unique
authorChris Cormack <chrisc@catalyst.net.nz>
Tue, 30 Dec 2014 21:20:59 +0000 (10:20 +1300)
committerChris Cormack <chrisc@catalyst.net.nz>
Wed, 31 Dec 2014 19:34:01 +0000 (08:34 +1300)
commit05f2fa17eb82fa43042841cd5d69f91aff0744df
tree1929076f10e291977a95feba1d1c6773b7590e9c
parent5311ae87f567c7a48005d0642c86532163b8679d
Bug 13502: Code introcduced in 1861 wrongly assumes a null userid is unique

To test

1/ Create a borrower with '' as their userid, you may have to edit a
   row in the db to do this
2/ Run  perl t/db_dependent/Circulation/CheckIfIssuedToPatron.t
3/ Notice some tests fail and you see
   DBD::mysql::st execute failed: Duplicate entry '' for key 'userid'
   at /home/chrisc/git/catalyst-koha/C4/SQLHelper.pm line 184.
4/ Apply the patch
5/ Run the tests again, notice they now pass

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
C4/Members.pm