From 03de9b36bb2e282476c5ef6c0cb4920c371b3f6d Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Tue, 28 Sep 2021 13:39:58 +0000 Subject: [PATCH] Bug 27173: Add tests Test plan: Run t/db_dependent/Koha/Plugins/authority_hooks.t Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b0a570a856316b7fb34414239fdc559a33b0fe9f) Signed-off-by: Fridolin Somers --- t/db_dependent/Koha/Plugins/authority_hooks.t | 70 +++++++++++++++++++ t/lib/Koha/Plugin/Test.pm | 7 ++ 2 files changed, 77 insertions(+) create mode 100755 t/db_dependent/Koha/Plugins/authority_hooks.t diff --git a/t/db_dependent/Koha/Plugins/authority_hooks.t b/t/db_dependent/Koha/Plugins/authority_hooks.t new file mode 100755 index 0000000000..75faee5ddc --- /dev/null +++ b/t/db_dependent/Koha/Plugins/authority_hooks.t @@ -0,0 +1,70 @@ +#!/usr/bin/perl + +# This file is part of Koha. +# +# Koha is free software; you can redistribute it and/or modify it under the +# terms of the GNU General Public License as published by the Free Software +# Foundation; either version 3 of the License, or (at your option) any later +# version. +# +# Koha is distributed in the hope that it will be useful, but WITHOUT ANY +# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR +# A PARTICULAR PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License along +# with Koha; if not, see . + +use Modern::Perl; + +use MARC::Record; +use Test::More tests => 4; +use Test::Warn; + +use File::Basename; + +use C4::AuthoritiesMarc (); +use Koha::Database; + +use t::lib::Mocks; +use t::lib::TestBuilder; + +BEGIN { + # Mock pluginsdir before loading Plugins module + my $path = dirname(__FILE__) . '/../../../lib'; + t::lib::Mocks::mock_config( 'pluginsdir', $path ); + + use_ok('Koha::Plugins'); + use_ok('Koha::Plugins::Handler'); + use_ok('Koha::Plugin::Test'); +} + +my $schema = Koha::Database->new->schema; +my $builder = t::lib::TestBuilder->new; + +t::lib::Mocks::mock_config( 'enable_plugins', 1 ); + +subtest 'after_authority_action hook' => sub { + plan tests => 3; + + $schema->storage->txn_begin; + + my $plugins = Koha::Plugins->new; + $plugins->InstallPlugins; + my $plugin = Koha::Plugin::Test->new->enable; + my $id; + + warning_like { ( $id ) = C4::AuthoritiesMarc::AddAuthority( MARC::Record->new, undef, 'PERSO_NAME' ); } + qr/after_authority_action called with action: create, id: \d+/, + 'AddAuthority calls the hook with action=create, id passed'; + + warning_like { C4::AuthoritiesMarc::ModAuthority( $id, MARC::Record->new, 'PERSO_NAME', { skip_merge => 1 } ); } + qr/after_authority_action called with action: modify, id: $id/, + 'ModAuthority calls the hook with action=modify, id passed'; + + warning_like { C4::AuthoritiesMarc::DelAuthority({ authid => $id, skip_merge => 1 }); } + qr/after_authority_action called with action: delete, id: $id/, + 'DelAuthority calls the hook with action=delete, id passed'; + + $schema->storage->txn_rollback; + Koha::Plugins::Methods->delete; +}; diff --git a/t/lib/Koha/Plugin/Test.pm b/t/lib/Koha/Plugin/Test.pm index b08ac89954..0087f4d368 100644 --- a/t/lib/Koha/Plugin/Test.pm +++ b/t/lib/Koha/Plugin/Test.pm @@ -164,6 +164,13 @@ sub after_item_action { } } +sub after_authority_action { + my ( $self, $params ) = @_; + my $action = $params->{action} // q{}; + my $id = $params->{authority_id} // 0; + Koha::Exceptions::Exception->throw("after_authority_action called with action: $action, id: $id"); +} + sub after_circ_action { my ( $self, $params ) = @_; -- 2.39.5