From c8718bd4af3e5b1329878cee6ff27a7a5a27091b Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 17 Feb 2020 14:58:02 +0100 Subject: [PATCH] Bug 24672: (bug 24430 follow-up) Do not get active orders on deleted biblio record On bug 24430 we replaced the call to CountBiblioInOrders with Koha::Biblio->active_orders In case the bibliographic record is deleted, the count must be set to 0. This prevent the app to crash with: Can't call method "active_orders" on an undefined value at /home/vagrant/kohaclone/acqui/parcel.pl line 244 Test plan: Create 2+ orders Receive one, delete it, delete the bibliographic record Receive the order one => Without this patch, on the parcel page you should get the error => With this patch applied you must be allowed to finish the receive Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize --- acqui/parcel.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acqui/parcel.pl b/acqui/parcel.pl index 3fcc211b20..8d094d8ffe 100755 --- a/acqui/parcel.pl +++ b/acqui/parcel.pl @@ -241,7 +241,7 @@ unless( defined $invoice->{closedate} ) { my $biblionumber = $line{'biblionumber'}; my $biblio = Koha::Biblios->find( $biblionumber ); - my $countbiblio = $biblio->active_orders->count; + my $countbiblio = $biblio ? $biblio->active_orders->count : 0; my $ordernumber = $line{'ordernumber'}; my $order_object = Koha::Acquisition::Orders->find($ordernumber); my $cnt_subscriptions = $biblio ? $biblio->subscriptions->count: 0; -- 2.39.5