From d1172b98d9a2b8dde3c700b0d116816b4d45fa26 Mon Sep 17 00:00:00 2001 From: Colin Campbell Date: Fri, 7 Jan 2011 11:44:03 +0000 Subject: [PATCH] Bug 5589: Remove duplicated Exports in Suggestions.pm Rather bizarrely Suggestions.pm was setting up @EXPORT, @ISA and $VERSION twice. Have removed one invocation Signed-off-by: Chris Cormack --- C4/Suggestions.pm | 50 ++++++++++++----------------------------------- 1 file changed, 13 insertions(+), 37 deletions(-) diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm index 5ea6c77a9c..81ff731696 100644 --- a/C4/Suggestions.pm +++ b/C4/Suggestions.pm @@ -29,46 +29,22 @@ use C4::SQLHelper qw(:all); use C4::Debug; use C4::Letters; use List::MoreUtils qw; -use base 'Exporter'; # parent would be better there +use C4::Dates qw(format_date_in_iso); +use base qw(Exporter); our $VERSION = 3.01; our @EXPORT = qw< - &ConnectSuggestionAndBiblio - &CountSuggestion - &DelSuggestion - &GetSuggestion - &GetSuggestionByStatus - &GetSuggestionFromBiblionumber - &ModStatus - &ModSuggestion - &NewSuggestion - &SearchSuggestion + ConnectSuggestionAndBiblio + CountSuggestion + DelSuggestion + GetSuggestion + GetSuggestionByStatus + GetSuggestionFromBiblionumber + ModStatus + ModSuggestion + NewSuggestion + SearchSuggestion >; -use C4::Dates qw(format_date_in_iso); -use vars qw($VERSION @ISA @EXPORT); - -BEGIN { - # set the version for version checking - $VERSION = 3.01; - require Exporter; - @ISA = qw(Exporter); - @EXPORT = qw( - &NewSuggestion - &SearchSuggestion - &GetSuggestion - &GetSuggestionByStatus - &DelSuggestion - &CountSuggestion - &ModSuggestion - &ConnectSuggestionAndBiblio - &GetSuggestionFromBiblionumber - &ConnectSuggestionAndBiblio - &DelSuggestion - &GetSuggestion - &GetSuggestionByStatus - &GetSuggestionFromBiblionumber - &ModStatus - ); -} + =head1 NAME -- 2.39.5