]> git.koha-community.org Git - koha.git/log
koha.git
23 months agoBug 27920: (QA follow-up) Remove now obsolete JavaScript lines
Katrin Fischer [Thu, 27 Oct 2022 21:28:15 +0000 (21:28 +0000)]
Bug 27920: (QA follow-up) Remove now obsolete JavaScript lines

There JS lines were left over from the first suggested GUI
using a checkbox.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 27920: (QA follow-up) Fix POD in cli tool
Kyle Hall [Wed, 19 Oct 2022 15:05:38 +0000 (11:05 -0400)]
Bug 27920: (QA follow-up) Fix POD in cli tool

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 27920: (QA follow-up) Change radios to a single select pulldown
Kyle Hall [Wed, 19 Oct 2022 14:59:08 +0000 (10:59 -0400)]
Bug 27920: (QA follow-up) Change radios to a single select pulldown

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 27920: (QA follow-up) Fix syntax error
Kyle Hall [Thu, 11 Aug 2022 11:39:06 +0000 (07:39 -0400)]
Bug 27920: (QA follow-up) Fix syntax error

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 27920: (QA follow-up) Update expiration date Checkbox should be enabled when...
Kyle Hall [Thu, 11 Aug 2022 11:38:03 +0000 (07:38 -0400)]
Bug 27920: (QA follow-up) Update expiration date Checkbox should be enabled when overwriting existing patrons

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 27920: Add ability to update patron expiration dates when importing patrons
Kyle Hall [Wed, 3 Aug 2022 11:13:49 +0000 (07:13 -0400)]
Bug 27920: Add ability to update patron expiration dates when importing patrons

Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Patrons/Import.t

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31896: (QA follow-up) Fix rollback
Marcel de Rooy [Fri, 28 Oct 2022 08:45:02 +0000 (08:45 +0000)]
Bug 31896: (QA follow-up) Fix rollback

Yes, it should be the last statement.
Actually the preceding delete is unneeded.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31896: (QA follow-up) Fix modules
Marcel de Rooy [Fri, 28 Oct 2022 08:43:28 +0000 (08:43 +0000)]
Bug 31896: (QA follow-up) Fix modules

Triggered by seeing Koha::Account. Copy and paste ;)
But a bunch of other modules should (at least formally) be there.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31896: New after_recall_action hook
Stefan Berndtsson [Mon, 17 Oct 2022 14:48:30 +0000 (16:48 +0200)]
Bug 31896: New after_recall_action hook

Hooks added:
after_recall_action with new action add

How to test:
Run tests in t/db_dependent/Koha/Plugins/Recall_hooks.t

Sponsored by: Gothenburg University Library

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT} Adding get_from_storage ;) For current consistency.
See further bug 32107.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 30250: DBRev 22.06.00.082
Tomas Cohen Arazi [Wed, 9 Nov 2022 17:18:07 +0000 (14:18 -0300)]
Bug 30250: DBRev 22.06.00.082

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 30250: Fix atomicupdate permissions
Tomas Cohen Arazi [Wed, 9 Nov 2022 17:12:50 +0000 (14:12 -0300)]
Bug 30250: Fix atomicupdate permissions

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 30250: (follow-up) Clarify syspref wording around importing
Aleisha Amohia [Wed, 7 Sep 2022 02:35:42 +0000 (14:35 +1200)]
Bug 30250: (follow-up) Clarify syspref wording around importing

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 30250: Use ApplyFrameworkDefaults when importing a record
Aleisha Amohia [Tue, 22 Mar 2022 21:26:35 +0000 (21:26 +0000)]
Bug 30250: Use ApplyFrameworkDefaults when importing a record

This patch adds the case of importing a record to the
ApplyFrameworkDefaults options.

To test:
1. Update database
2. Confirm the ApplyFrameworkDefaults system preference now has the
'when importing a record via z39.50' option. Do not select it.
3. Go to Cataloguing. Import a record from z39.50, or replace an
existing record.
4. Confirm framework defaults are not applied.
5. Go back to the system preference and check the 'when importing a
record via z39.50' option.
6. Repeat step 3. This time framework defaults should be applied. Only
fields that are empty in the imported record will be replaced by
framework defaults.
7. Repeat for authorities.

Sponsored-by: Catalyst IT
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 30250: Add ApplyFrameworkDefaults system preference
Aleisha Amohia [Wed, 9 Mar 2022 01:13:03 +0000 (01:13 +0000)]
Bug 30250: Add ApplyFrameworkDefaults system preference

(cherry picked from commit 684a04deb6ec7e94ca60f5cb38811176fbb9c230)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 30250: Use ApplyFrameworkDefaults when cataloguing
Aleisha Amohia [Wed, 9 Mar 2022 01:13:32 +0000 (01:13 +0000)]
Bug 30250: Use ApplyFrameworkDefaults when cataloguing

This patch adds a system preference ApplyFrameworkDefaults to configure
when to apply framework defaults - when cataloguing a new record, when
editing a record as new (duplicating), or when changing the framework
while editing an existing record. This applies to both bibliographic
records and authority records.

To test:
1. Update database
2. Go to Administration -> system preferences. Find the
ApplyFrameworkDefaults system preference. Confirm "when cataloguing new
records" is selected by default.
3. Keep the system preference open in one tab, and open the staff client
in another tab.
4. Go to Administration -> bibliographic frameworks. Choose a framework,
edit the subfields for a tag, and give a subfield a default value. For
example, set 500$a for the BOOKS framework to have a default value of
"TEST". This will be Framework A.
5. Ensure you have another framework that does not have the same default
value for a subfield as Framework A. This will be Framework B.
6. Go to Cataloguing. Add a new record using Framework A. Confirm your
subfield has the default value filled. Cancel and do not save the
record.
7. In your System preferences tab, uncheck the option "when cataloguing
new records" and save. No options should now be selected.
8. In our other tab, go to cataloguing, add a new record using Framework
A. Confirm your subfield does NOT have the default value filled. Fill
the required fields, including the subfield that should have a default
value, and Save the record.
9. In your system preferences tab, select all options and save.
10. In your other tab, click Edit, then "Edit as new (duplicate)".
Confirm your subfield has maintained the value from the source record.
Cancel and do not save the record.
11. Edit your original record and delete the value in your subfield that
could be filled with a default value by the framework. Save the record
with no value in the subfield.
12. Click Edit, then "Edit as new (duplicate)". Confirm your subfield
has the default value filled. Framework defaults will only apply to
emplty fields. Save the record.
13. Do a catalogue search and find a record that uses Framework B.
14. If you need to, edit the record to make sure there is nothing in your
subfield that should have a default value if this record were to use
Framework A, and Save.
15. Edit the record. Using the settings dropdown, change the framework
to Framework A. Confirm your subfield has the default value filled.
16. Repeat steps 4 to 12 with authority types and authority records.

Sponsored-by: Education Services Australia SCIS
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31902: Next header row inside a thead
Martin Renvoize [Tue, 8 Nov 2022 15:51:15 +0000 (15:51 +0000)]
Bug 31902: Next header row inside a thead

This sets the proper markup for table headers in the holds page and thus
grabs the proper header row underline.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 26635: (follow-up) Rename av_expand to strings
Martin Renvoize [Mon, 7 Nov 2022 12:25:33 +0000 (12:25 +0000)]
Bug 26635: (follow-up) Rename av_expand to strings

This patch updates the `av_expand` occurences to `strings` to match the
change of the return structure of `_strings`.

We replace `+av_expand` in the headers with `+strings`, the expected
object method name from `api_av_mapping` to `api_strings_mapping` and
the internal hash key from `av_expand` to `strings`.

Test plan
1) Run the included unit tests.. all should still pass.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 26635: (QA follow-up) Rename key _str to _strings
Kyle M Hall [Fri, 4 Nov 2022 18:07:28 +0000 (18:07 +0000)]
Bug 26635: (QA follow-up) Rename key _str to _strings

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 26635: (QA follow-up) Remove test for x-koha-av-expand header
Martin Renvoize [Thu, 3 Nov 2022 11:14:20 +0000 (11:14 +0000)]
Bug 26635: (QA follow-up) Remove test for x-koha-av-expand header

This patch updates the last remaining test that mentioned the now defunkt
x-koha-av-expand header.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 26635: Move expand syntax to x-koha-embed
Tomas Cohen Arazi [Wed, 2 Nov 2022 15:48:29 +0000 (12:48 -0300)]
Bug 26635: Move expand syntax to x-koha-embed

Instead of a global av-expand flag (through a header) this patch
proposes to allow specifying +av_expand at the x-koha-embed header
level. This allows a more fine-grained control on what objects get avs
expanded. e.g.:

GET /patrons/123
x-koha-expand: +av_expand,checkouts.item+av_expand
=>
{
    "_str": {
        "city": { "str": "Córdoba", ... }
    },
    ...
    "checkouts": [
        {
            ...,
            "item": {
                "_str": {
                    "not_for_loan_status": { "str": "Reference material", ... },
                    ...
                },
                ...
            }
        }
    ]
}

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/Koha/REST/Plugin/Query.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
2. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 26635: Refined data structure and methods
Tomas Cohen Arazi [Fri, 28 Oct 2022 22:25:46 +0000 (19:25 -0300)]
Bug 26635: Refined data structure and methods

This patch makes the returned data structure be simpler:

_str => {
    attribute_1 => {
        category => 'some_category_name',
        str      => 'description',
        type     => 'av'
    },
    ...
}

The description is sensible to context, so if public => 1 is passed,
then lib_opac is passed, and lib is returned otherwise. Whenever we add
language to the combo, we will add it to the implementation.

Tests are adjusted accordingly, also to reflect the public => 1 use
case.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 26635: AV expansion should ackowledge $params->{public}
Tomas Cohen Arazi [Fri, 28 Oct 2022 14:50:13 +0000 (11:50 -0300)]
Bug 26635: AV expansion should ackowledge $params->{public}

This patch simplifies the original implementation so it is more
readable, removing extra loops and methods and just dealing with the
coded values inline on the existing loops.

It also adds non-public attributes removal from the original list, to
address the changes introduced by bug 28948.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 26635: Add tests for av-expand => 0
Jonathan Druart [Tue, 31 Aug 2021 08:03:46 +0000 (10:03 +0200)]
Bug 26635: Add tests for av-expand => 0

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 26635: Expand authorised values in to_api method
Agustin Moyano [Fri, 9 Oct 2020 12:59:41 +0000 (09:59 -0300)]
Bug 26635: Expand authorised values in to_api method

This patch adds the posibility to expand authorised values when to_api
method is called.

The classes where authorised values should expand must implememnt the
_fetch_authorised_values method, and must return a hash like the
following

{
  column_name => Koha::AuthorisedValue->unblessed
  ...
}

This patch will be used in bug 8179, so please test there.

Sponsored-by: Virginia Polytechnic Institute and State University
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 26635: Add tests
Agustin Moyano [Fri, 9 Oct 2020 12:59:46 +0000 (09:59 -0300)]
Bug 26635: Add tests

Add tests in t/db_dependent/Koha/Object.t and
t/db_dependent/Koha/REST/Plugin/Objects.t

Sponsored-by: Virginia Polytechnic Institute and State University
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32004: Compiled CSS
Tomas Cohen Arazi [Wed, 9 Nov 2022 16:58:13 +0000 (13:58 -0300)]
Bug 32004: Compiled CSS

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32004: (follow-up) Increase padding between menu items
Owen Leonard [Wed, 9 Nov 2022 13:48:26 +0000 (13:48 +0000)]
Bug 32004: (follow-up) Increase padding between menu items

I think the increased font size means we need slightly more padding
between items for good legibility.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32004: Match font size for dropdowns to header
Martin Renvoize [Tue, 8 Nov 2022 16:13:25 +0000 (16:13 +0000)]
Bug 32004: Match font size for dropdowns to header

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31414: (QA follow-up) Re-add required class
Katrin Fischer [Wed, 9 Nov 2022 13:57:38 +0000 (13:57 +0000)]
Bug 31414: (QA follow-up) Re-add required class

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31414: Set focus to name in additional fields.
Isobel Graham [Sun, 6 Nov 2022 14:28:42 +0000 (14:28 +0000)]
Bug 31414: Set focus to name in additional fields.

Focus is set to name on additional fields on
administation add fields.

Test plan
1. Go to administation and manange additional
fields.
2. If you then add field the focus should
automatically go to the field name.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32088: Consistent classes for primary buttons: Patron card creator
Owen Leonard [Thu, 3 Nov 2022 13:01:45 +0000 (13:01 +0000)]
Bug 32088: Consistent classes for primary buttons: Patron card creator

This patch makes changes the button markup in patron card creator
templates so that all submit buttons and any buttons that should should
be styled as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view patron card creator pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32087: Consistent classes for primary buttons: Course reserves
Owen Leonard [Thu, 3 Nov 2022 12:09:56 +0000 (12:09 +0000)]
Bug 32087: Consistent classes for primary buttons: Course reserves

This patch makes changes the button markup in course reserves templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view course reserves pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32138: Fix OIDC default mapping
David Cook [Wed, 9 Nov 2022 00:43:53 +0000 (00:43 +0000)]
Bug 32138: Fix OIDC default mapping

This patch fixes the OIDC default mapping to have the Koha fields on
the left (ie key) and the OIDC standard claim fields on the right (ie value).

1. Apply the patch
2. Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form
3. Choose "OIDC" for "Protocol"
4. Click "Add default OIDC mapping"
5. Note the following is displayed:
{
  "email": "email",
  "firstname": "given_name",
  "surname": "family_name"
}

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32141: Add missing fieldset legends and titlecase "matchpoint"
David Cook [Wed, 9 Nov 2022 02:10:55 +0000 (02:10 +0000)]
Bug 32141: Add missing fieldset legends and titlecase "matchpoint"

This patch adds missing fieldset legends and titlecases "matchpoint",
so that the "Edit" UI is consistent with the "New" UI for adding
and modifying Identity Providers.

Test plan:
1) Apply patches
2) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form
3) Fill out the fields to add an identity provider
4) Click "Edit" next to the Identity Provider in the list
5) In a new tab, go to
http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form
6) Compare the two screens and note that all the labels, inputs, and help text
are the same on both screens.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32141: Fix textbox formatting on edit IdP screen
David Cook [Wed, 9 Nov 2022 02:07:03 +0000 (02:07 +0000)]
Bug 32141: Fix textbox formatting on edit IdP screen

This patch makes the textbox have the same number of rows and columns
on the "Edit" page as it does on the "New" page for Identity Providers.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32139: Set "update on login" correctly when creating new IdP
David Cook [Wed, 9 Nov 2022 01:59:28 +0000 (01:59 +0000)]
Bug 32139: Set "update on login" correctly when creating new IdP

This patches allows "Update on Login" to be set to "Yes" when
creating a domain as part of a new Identity Provider.

Test plan:
1) Apply patch
2) koha-plack --reload kohadev
3) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl
4) Click "New identity provider"
5) Fill in "Code" and "Description" with "test"
6) Click "Add default OAuth configuration"
7) Click "Add default OAUth mapping"
8) Fill in "Domain" with "*"
9) Change "Allow OPAC", "Allow staff", "Auto register", and "Update on login"
to "Yes"
10) Click "Submit"
11) Click "Manage Domains" for your new Identity Provider
12) Note that "Allow opac", "Allow staff", "Auto register", and "Update on login"
are all set to "Yes"

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32028: (follow-up) Fix headings levels
Martin Renvoize [Wed, 9 Nov 2022 13:23:39 +0000 (13:23 +0000)]
Bug 32028: (follow-up) Fix headings levels

This patch corrects the headings levels on cash_registers,
patron-attr-types and restrictions admin pages.

We also move the h2 headings inside the page-section div as appropriate.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Add missing sponsors
Tomas Cohen Arazi [Wed, 9 Nov 2022 15:25:32 +0000 (12:25 -0300)]
Bug 32030: Add missing sponsors

Sponsored-by: ByWater Solutions
Sponsored-by: BibLibre
Sponsored-by: PTFS-Europe
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31894: (QA follow-up) Move rollbacks to the end
Marcel de Rooy [Tue, 25 Oct 2022 14:29:35 +0000 (14:29 +0000)]
Bug 31894: (QA follow-up) Move rollbacks to the end

Obvious fix. This test removed my method records.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31894: Extend after_hold_action hook
Stefan Berndtsson [Mon, 17 Oct 2022 14:47:06 +0000 (16:47 +0200)]
Bug 31894: Extend after_hold_action hook

Hook actions added:
after_hold_action adds new actions transfer, waiting and processing

How to test:
Run tests in t/db_dependent/Koha/Plugins/Holds_hooks.t

Sponsored by: Gothenburg University Library

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31271: Preselect previous search index
Nick Clemens [Thu, 3 Nov 2022 12:29:59 +0000 (12:29 +0000)]
Bug 31271: Preselect previous search index

This patch passes the constructed value of the preselect to search_indexes.inc

To test:
1 - Perform an advanced search, making sure to select different indexes
2 - Click 'Edit search' on results page
3 - Confirm index selections are preselected
4 - Enable  IntranetCatalogSearchPulldown
5 - Do a search form the top bar using an index
6 - Confirm 'Edit search' correctly popluates the chosen index

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32114: Add missing html_helpers.inc
Owen Leonard [Sat, 5 Nov 2022 16:02:55 +0000 (16:02 +0000)]
Bug 32114: Add missing html_helpers.inc

This patch makes a minor modification to the OPAC
search results RSS template so that an error isn't
triggered. The html_helpers include was missing.

To test, apply the patch and perform a catalog
search in the OPAC which will return results.

At the end of the "Your search results" heading
you should see an orange RSS icon. Clicking on it
should take you to an RSS feed instead of an
error page.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31818: Enable table elements in keyboard shortcuts popover
Nick Clemens [Thu, 3 Nov 2022 15:20:34 +0000 (15:20 +0000)]
Bug 31818: Enable table elements in keyboard shortcuts popover

This patch updates the whitelist for the popover to ensrue our shortcuts table displays

To test:
1 - Open the advanced cataloging editor
2 - Click 'Keyboard shortcuts'
3 - Is empty, be sad
4 - Apply patch
5 - Reload
6 - Click it again
7 - Shortcuts!

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32111: Remove disabled from date input for curbside pickup
Jonathan Druart [Fri, 4 Nov 2022 12:30:24 +0000 (13:30 +0100)]
Bug 32111: Remove disabled from date input for curbside pickup

The date input is always disabled and it's not possible to select or enter a date.

git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true"

I don't really know what's happening here, but it's impossible to
interact with the date widget if the input is disabled when it's
initialized.

The solution I have here is to play with hide/show instead of disabled.

Other suggestions welcome.

Test plan:
Schedule a curbside pickup from the OPAC and confirm that the date input
is working as expected.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32028: (follow-up) Improve smart rules formatting
Martin Renvoize [Wed, 9 Nov 2022 12:47:34 +0000 (12:47 +0000)]
Bug 32028: (follow-up) Improve smart rules formatting

I correct the indenting here, so remember to diff ignoring whitespace ;)

I remove some of the page-section divs introduced by the previous patch
and instead replace the 'container' classes with the new 'page-section
class on existing divs.

This brings the page-sections more in line with elsewhere in the
codebase.

I also update the 'h3' headings to 'h2' as we were somehow skipping that
heading level page wide and update the final 'h4' heading to 'h2' to
match the other section headings appropriately.

Finally, I break up the top section more, using bg-info for the top
block of instructions.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32028: Add page-section to smart-rules.tt and fix markup errors
Lucas Gass [Fri, 4 Nov 2022 14:52:23 +0000 (14:52 +0000)]
Bug 32028: Add page-section to smart-rules.tt and fix markup errors

To test:
1. Apply patch
2. Go to Adminstration > Circulation and fine rules
3. Look at the page-section added and make sure each looks good.
4. Use an HTML validator to check and make sure the HTML looks good.

Note: There are indentation changes and some fixes to bad markup ( stray tags, etc ).

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
https://bugs.koha-community.org/show_bug.cgi?id=32082
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32028: Add page-section to various admin pages
Lucas Gass [Thu, 3 Nov 2022 17:46:15 +0000 (17:46 +0000)]
Bug 32028: Add page-section to various admin pages

This patch adds the page section to div to the following administration pages:

admin/cash_registers.tt
admin/cities.tt
admin/credit_types.tt
admin/debit_types.tt
admin/patron-attr-types.tt
admin/restrictions.tt
plugins/plugins-home.tt

To test go the following pages and make sure everything looks good:

Administration > Cash registers. You must enable the sys pref 'UseCashRegisters'
Administration > Cities and towns.
Administration > Credit types
Administration > Debit types
Administration > Patron restrictions
Adminstration > Patron attribute types
Administration > Manage plugins

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
https://bugs.koha-community.org/show_bug.cgi?id=32082
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 12758: (QA follow-up) Enhance POD
Tomas Cohen Arazi [Wed, 9 Nov 2022 12:58:56 +0000 (09:58 -0300)]
Bug 12758: (QA follow-up) Enhance POD

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 12758: Add new module call in Koha::XSLT::Base
Marcel de Rooy [Wed, 24 Sep 2014 15:01:00 +0000 (17:01 +0200)]
Bug 12758: Add new module call in Koha::XSLT::Base

Reviving a report back from 2014. The workaround is now moved to a
separate helper module from another patch.

Test plan:
Test OPACXSLTDetailsDisplay with an https reference.
You may try:
https://library.rijksmuseum.nl/opac-tmpl/bootstrap/en/xslt/zztest.xsl

If you flush and restart, the opac detail pages will contain the
text 'This is my MARC record.'.

NOTE: If you point to an xslt file over https that contains includes or
imports, you will still get the error: Failed to load external entity.
To address that, we need to extend the _resolve_includes sub.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 12758: Introduce Koha::XSLT::HTTPS
Marcel de Rooy [Wed, 29 Jun 2022 12:16:46 +0000 (12:16 +0000)]
Bug 12758: Introduce Koha::XSLT::HTTPS

This module now fetches a https stylesheet and returns it as a
string to Base. (As a workaround waiting for a real solution
in the underlying libraries.)

The module can be extended to resolve includes but this requires
parsing the xslt code.

Test plan:
[1] Run t/Koha_XSLT_HTTPS.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 12758: Make LWP::Protocol::https required module
Marcel de Rooy [Wed, 29 Jun 2022 11:23:34 +0000 (11:23 +0000)]
Bug 12758: Make LWP::Protocol::https required module

Moving from recommends to required in cpanfile.

Reference info: Debian package liblwp-protocol-https-perl is
available for Buster (6.07-2) and Bullseye (6.10-1).

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Add missing additionalProperties to /erm/eholdings/local/titles/import
Jonathan Druart [Wed, 9 Nov 2022 08:12:47 +0000 (09:12 +0100)]
Bug 32030: Add missing additionalProperties to /erm/eholdings/local/titles/import

This fixes xt/api.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Fix Makefile.t
Jonathan Druart [Wed, 9 Nov 2022 08:04:33 +0000 (09:04 +0100)]
Bug 32030: Fix Makefile.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Fix perlcritic errors
Jonathan Druart [Wed, 9 Nov 2022 08:00:47 +0000 (09:00 +0100)]
Bug 32030: Fix perlcritic errors

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Remove maintenance file
Jonathan Druart [Wed, 9 Nov 2022 07:58:19 +0000 (08:58 +0100)]
Bug 32030: Remove maintenance file

This script is actually not used.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: (follow-up) Fix t/Koha/Auth/Permissions.t
Tomas Cohen Arazi [Wed, 9 Nov 2022 02:40:30 +0000 (23:40 -0300)]
Bug 31378: (follow-up) Fix t/Koha/Auth/Permissions.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Add erm/ dir to Makefile.PL
Tomas Cohen Arazi [Wed, 9 Nov 2022 00:18:21 +0000 (21:18 -0300)]
Bug 32030: Add erm/ dir to Makefile.PL

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Wrong permissions on maintenance script
Tomas Cohen Arazi [Wed, 9 Nov 2022 00:04:10 +0000 (21:04 -0300)]
Bug 32030: Wrong permissions on maintenance script

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: (follow-up) Wrong permissions on controller script file
Tomas Cohen Arazi [Wed, 9 Nov 2022 00:02:18 +0000 (21:02 -0300)]
Bug 31378: (follow-up) Wrong permissions on controller script file

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: (follow-up) MySQL 8 doens't allow default for longtext
Tomas Cohen Arazi [Tue, 8 Nov 2022 22:28:03 +0000 (19:28 -0300)]
Bug 31378: (follow-up) MySQL 8 doens't allow default for longtext

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: DBRev 22.06.00.081
Tomas Cohen Arazi [Tue, 8 Nov 2022 17:46:17 +0000 (14:46 -0300)]
Bug 31378: DBRev 22.06.00.081

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: DBIC schema
Tomas Cohen Arazi [Tue, 8 Nov 2022 17:41:43 +0000 (14:41 -0300)]
Bug 31378: DBIC schema

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add domain settings to IdP add page
Tomas Cohen Arazi [Tue, 8 Nov 2022 14:20:39 +0000 (11:20 -0300)]
Bug 31378: Add domain settings to IdP add page

This patch introduces a small form for an initial domain configuration
to the 'New identity provider' page, to avoid confusion on testers about
required settings for things to work.

To test:
1. Apply this patch
2. Verify you are now offered a configuration section for domain
   settings. Fields like 'Default category' and 'Default library' are
   mandatory.
3. Choosing some values makes them get stored on 'Submit'

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: (QA follow-up) Tidy tests
Tomas Cohen Arazi [Fri, 4 Nov 2022 14:20:50 +0000 (11:20 -0300)]
Bug 31378: (QA follow-up) Tidy tests

This patch perltidys the tests added lately. It also removes some
commented debugging lines.

Note: There's an attempt to write tests on the full auth workflow that
is commented out but left there on purpose for now.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: (follow-up) catch startup error when missing Oauth provider table
David Cook [Thu, 3 Nov 2022 12:32:03 +0000 (09:32 -0300)]
Bug 31378: (follow-up) catch startup error when missing Oauth provider table

In theory, this shouldn't come up with a package install, but
it could happen with other installations, so best to let it get to
the web installer.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Use base URLs for redirect uri
Nick Clemens [Thu, 3 Nov 2022 12:25:53 +0000 (09:25 -0300)]
Bug 31378: Use base URLs for redirect uri

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: (follow-up) Fix QA concerns
Agustin Moyano [Thu, 3 Nov 2022 00:44:32 +0000 (21:44 -0300)]
Bug 31378: (follow-up) Fix QA concerns

Several FIXME comments added on the report addressed here.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Rename Auth Provider to Identity Provider and add Client.t tests
Agustin Moyano [Wed, 26 Oct 2022 12:00:09 +0000 (09:00 -0300)]
Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add an administration interface for authentication sources
Agustin Moyano [Fri, 23 Sep 2022 18:02:48 +0000 (15:02 -0300)]
Bug 31378: Add an administration interface for authentication sources

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add authentication provider endpoints
Tomas Cohen Arazi [Tue, 30 Aug 2022 13:33:14 +0000 (10:33 -0300)]
Bug 31378: Add authentication provider endpoints

This patch adds routes for handling authentication providers to the REST
API.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_providers.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter
Tomas Cohen Arazi [Tue, 30 Aug 2022 13:19:24 +0000 (10:19 -0300)]
Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add manage_authentication_providers permission
Tomas Cohen Arazi [Tue, 30 Aug 2022 13:16:44 +0000 (10:16 -0300)]
Bug 31378: Add manage_authentication_providers permission

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add accessor methods for JSON attributes
Tomas Cohen Arazi [Wed, 24 Aug 2022 15:21:08 +0000 (12:21 -0300)]
Bug 31378: Add accessor methods for JSON attributes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add STAFF support for authentication providers
Agustin Moyano [Tue, 27 Sep 2022 12:20:49 +0000 (09:20 -0300)]
Bug 31378: Add STAFF support for authentication providers

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add OPAC support for authentication providers
Agustin Moyano [Tue, 23 Aug 2022 15:00:47 +0000 (12:00 -0300)]
Bug 31378: Add OPAC support for authentication providers

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth
Agustin Moyano [Tue, 23 Aug 2022 15:00:10 +0000 (12:00 -0300)]
Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add auth providers template plugin
Agustin Moyano [Tue, 23 Aug 2022 14:58:58 +0000 (11:58 -0300)]
Bug 31378: Add auth providers template plugin

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add API routes
Agustin Moyano [Thu, 18 Aug 2022 19:42:10 +0000 (16:42 -0300)]
Bug 31378: Add API routes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add Auth mojo plugin
Agustin Moyano [Thu, 18 Aug 2022 19:41:03 +0000 (16:41 -0300)]
Bug 31378: Add Auth mojo plugin

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add Koha::Auth::Client* modules
Agustin Moyano [Thu, 18 Aug 2022 19:29:19 +0000 (16:29 -0300)]
Bug 31378: Add Koha::Auth::Client* modules

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add Koha::Auth::Provider(s) class(es)
Agustin Moyano [Thu, 18 Aug 2022 19:27:06 +0000 (16:27 -0300)]
Bug 31378: Add Koha::Auth::Provider(s) class(es)

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add Koha::Auth::Provider::Domain(s) class(es)
Tomas Cohen Arazi [Wed, 24 Aug 2022 14:58:44 +0000 (11:58 -0300)]
Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es)

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: Add dependencies
Agustin Moyano [Thu, 18 Aug 2022 19:09:54 +0000 (16:09 -0300)]
Bug 31378: Add dependencies

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 31378: DB changes
Agustin Moyano [Thu, 18 Aug 2022 19:08:20 +0000 (16:08 -0300)]
Bug 31378: DB changes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: (QA follow-up) Enable BasicAuth for ERM tests
Tomas Cohen Arazi [Tue, 8 Nov 2022 14:55:23 +0000 (11:55 -0300)]
Bug 32030: (QA follow-up) Enable BasicAuth for ERM tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 30880: DBRev 22.06.00.080
Tomas Cohen Arazi [Tue, 8 Nov 2022 13:02:22 +0000 (10:02 -0300)]
Bug 30880: DBRev 22.06.00.080

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 30880: (QA follow-up) Add exec flag
Nick Clemens [Fri, 19 Aug 2022 11:43:19 +0000 (11:43 +0000)]
Bug 30880: (QA follow-up) Add exec flag

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 30880: Add 'branchonly' to OPACResultsUnavailableGroupingBy
Aleisha Amohia [Wed, 1 Jun 2022 22:35:06 +0000 (22:35 +0000)]
Bug 30880: Add 'branchonly' to OPACResultsUnavailableGroupingBy

This patch adds a third option 'branch only' to the
OPACResultsUnavailableGroupBy system preference. This option will group
unavailable items by branch in the OPAC search results and NOT show
individual callnumbers or substatuses.

Note: This assumes OPACXSLTResultsDisplay is set to default.

To test:
1. Create a biblio record with 3 items with the following home branches:
Item A: Branch A
Item B: Branch A
Item C: Branch B
2. Check out Item A to yourself
3. Edit Item B to have a lost status
4. Go to Administration -> global system preferences. Search for
OPACResultsUnavailableGroupingBy.
5. By default, this preference will be set to 'branch'.
6. Open the OPAC in another tab, and search for your record.
7. Confirm the search results shows an Availability line with "Not
available: Branch A: Checked out (1). Branch A: Lost (1)." i.e. showing
both branch and substatus.
8. In your staff client tab, set OPACResultsUnavailableGroupingBy to
'substatus'.
9. Go back to your OPAC tab and search for your record. Confirm the
search results shows an Availability line with "Not available: Checked
out (1). Lost (1)." i.e. showing substatus only.
10. Apply patch, update database, restart services.
11. In your staff client tab, refresh the page. Confirm the options for
OPACResultsUnavailableGroupingBy have now changed to:
- branch and substatus
- substatus only
- branch only
12. Set OPACResultsUnavailableGroupingBy to 'branch only'.
13. Go back to your OPAC tab and search for your record. Confirm the
search results shows an Availability line with "Not available: Branch A
(2)." i.e. showing branch only.
14. Confirm the other two options still work as expected.

Sponsored-by: Chartered Accountants Australia and New Zealand
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Add dist dir to .gitignore
Tomas Cohen Arazi [Tue, 8 Nov 2022 12:49:57 +0000 (09:49 -0300)]
Bug 32030: Add dist dir to .gitignore

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: DBRev 22.06.00.079
Tomas Cohen Arazi [Tue, 8 Nov 2022 12:41:13 +0000 (09:41 -0300)]
Bug 32030: DBRev 22.06.00.079

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Create erm_user_roles after erm_licenses
Jonathan Druart [Tue, 8 Nov 2022 07:33:38 +0000 (08:33 +0100)]
Bug 32030: Create erm_user_roles after erm_licenses

Or the update will fail with the following error

ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Can't create table `koha_kohadev`.`erm_user_roles` (errno: 150 "Foreign key constraint is incorrectly formed") at /kohadevbox/koha/C4/Installer.pm line 739

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Add lib for agreement's relationships values
Jonathan Druart [Mon, 7 Nov 2022 08:08:35 +0000 (09:08 +0100)]
Bug 32030: Add lib for agreement's relationships values

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Add margin in agreement's filters block
Jonathan Druart [Fri, 4 Nov 2022 16:29:07 +0000 (17:29 +0100)]
Bug 32030: Add margin in agreement's filters block

Quick & dirty fix, this is not very nice and can be improved

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Move cypress to t - fix build_js/watch_js
Pedro Amorim [Fri, 4 Nov 2022 11:19:44 +0000 (10:19 -0100)]
Bug 32030: Move cypress to t - fix build_js/watch_js

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Move cypress to t/
Jonathan Druart [Fri, 4 Nov 2022 09:04:29 +0000 (10:04 +0100)]
Bug 32030: Move cypress to t/

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Fix for vue warning
Pedro Amorim [Wed, 2 Nov 2022 10:51:47 +0000 (09:51 -0100)]
Bug 32030: Fix for vue warning

We were getting the following warning in the console:
runtime-core.esm-bundler.js:5122 Feature flags VUE_OPTIONS_API, VUE_PROD_DEVTOOLS are not explicitly defined. You are running the esm-bundler build of Vue, which expects these compile-time feature flags to be globally injected via the bundler config in order to get better tree-shaking in the production bundle.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Fix date input length
Jonathan Druart [Fri, 4 Nov 2022 08:56:16 +0000 (09:56 +0100)]
Bug 32030: Fix date input length

Caused by 31943.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: (follow-up) Fix date handling - conflicts with bug 30718
Jonathan Druart [Thu, 3 Nov 2022 17:00:08 +0000 (18:00 +0100)]
Bug 32030: (follow-up) Fix date handling - conflicts with bug 30718

Fix "Filter by expired" returns 400 when no date provided

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: Replace this.setError with setError
Jonathan Druart [Tue, 1 Nov 2022 15:59:59 +0000 (16:59 +0100)]
Bug 32030: Replace this.setError with setError

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
23 months agoBug 32030: DBIC Specific
Jonathan Druart [Wed, 25 May 2022 11:59:00 +0000 (13:59 +0200)]
Bug 32030: DBIC Specific

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>