]> git.koha-community.org Git - koha.git/log
koha.git
6 years agoBug 21279: Fix   in transport cost matrix
Marcel de Rooy [Wed, 10 Oct 2018 11:43:40 +0000 (13:43 +0200)]
Bug 21279: Fix   in transport cost matrix

Test plan:
On Home › Administration › Transport cost matrix you should no longer
see " ".
Fill some values and save, you should see the correct values.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19687: (RM follow-up) Export correct function name
Nick Clemens [Mon, 15 Oct 2018 13:07:11 +0000 (13:07 +0000)]
Bug 19687: (RM follow-up) Export correct function name

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19687: Undefined subroutine in bulkmarcimport
David Gustafsson [Wed, 26 Sep 2018 15:25:44 +0000 (17:25 +0200)]
Bug 19687: Undefined subroutine in bulkmarcimport

Bulkmarcimport produces undefined subroutine error for
C4::Items::TransformMarcToKoha and C4::Items::GetMarcStructure
probably caused by mutually recursive modules. Put exports in
BEGIN clause before all the other imports.

To test:
1) Run bulkmarcimport.pl before applying patch and verify
that undefined subroutine error occurs
2) Apply patch
3) Run bulkmarcimport.pl again and verify that no errors are
produced

Sponsored-by: Gothenburg University Library
Signed-off-by: George Veranis <gveranis@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21320: Holds to pull should honor syspref AllowHoldsOnDamagedItems
Dobrica Pavlinusic [Thu, 6 Sep 2018 11:21:53 +0000 (13:21 +0200)]
Bug 21320: Holds to pull should honor syspref AllowHoldsOnDamagedItems

Test plan:

1. Set syspref AllowHoldsOnDamagedItems to Allow
2. Create a hold on record with item which is damaged
3. Verify that it doesn't appear in report
4. Apply patch and verify that it's now visible

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 10382: Course reserves: handle empty values
Alex Arnaud [Wed, 21 Feb 2018 13:10:50 +0000 (13:10 +0000)]
Bug 10382: Course reserves: handle empty values

Test Plan:
1) Create an item, do not set a collection code
2) Add the item to a course, and choose to set a collection code
3) Ensure the course is enabled, and the collection code is now visible
4) Disable the course, ensure the collection code is no longer visible

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 10382: Add unit tests for course items
Alex Arnaud [Thu, 9 Mar 2017 13:42:04 +0000 (13:42 +0000)]
Bug 10382: Add unit tests for course items

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 10382: collection not returning to null when removed from course reserves
Kyle M Hall [Wed, 5 Jun 2013 14:01:17 +0000 (10:01 -0400)]
Bug 10382: collection not returning to null when removed from course reserves

Test Plan:
1) Create an item, do not set a collection code
2) Add the item to a course, and choose to set a collection code
3) Ensure the course is enabled, and the collection code is now visible
4) Disable the course, ensure the collection code is no longer visible

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20797: (QA follow-up) Fix ill requests table
Katrin Fischer [Fri, 5 Oct 2018 12:18:11 +0000 (12:18 +0000)]
Bug 20797: (QA follow-up) Fix ill requests table

... by adding a missing comma.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20797: (follow-up) Conditionally link
Andrew Isherwood [Thu, 7 Jun 2018 10:14:50 +0000 (11:14 +0100)]
Bug 20797: (follow-up) Conditionally link

We don't want to display the link to the biblio if the biblio_id is null

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20797: Add link to biblio detail view from ILL detail view
Andrew Isherwood [Wed, 23 May 2018 11:26:25 +0000 (12:26 +0100)]
Bug 20797: Add link to biblio detail view from ILL detail view

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 17084: Automatic debian/control updates (unstable/master)
Mirko Tietgen [Thu, 11 Oct 2018 14:21:41 +0000 (16:21 +0200)]
Bug 17084: Automatic debian/control updates (unstable/master)

I added libwebservice-ils-perl 0.17 to the repository, so it
goes into debian/control too.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20772: (QA follow-up) 'readonly' is a boolean
Tomas Cohen Arazi [Sat, 13 Oct 2018 11:05:34 +0000 (08:05 -0300)]
Bug 20772: (QA follow-up) 'readonly' is a boolean

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20772: DBRev 18.06.00.041
Tomas Cohen Arazi [Sat, 13 Oct 2018 10:47:12 +0000 (07:47 -0300)]
Bug 20772: DBRev 18.06.00.041

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20772: (follow-up) Add unit test
Andrew Isherwood [Mon, 8 Oct 2018 16:48:39 +0000 (17:48 +0100)]
Bug 20772: (follow-up) Add unit test

Add unit test for price_paid

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20772: (QA follow-up) Add a missing html filter
Katrin Fischer [Fri, 5 Oct 2018 11:38:26 +0000 (13:38 +0200)]
Bug 20772: (QA follow-up) Add a missing html filter

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20772: (follow-up) Fix DB updates and templates
Andrew Isherwood [Fri, 5 Oct 2018 10:56:31 +0000 (11:56 +0100)]
Bug 20772: (follow-up) Fix DB updates and templates

Carry out changes requested in commenbt #27

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20772: Bug preventing backend JS execution
Barry Cannon [Tue, 24 Jul 2018 14:56:30 +0000 (15:56 +0100)]
Bug 20772: Bug preventing backend JS execution

We should be 'PROCESS'ing any backend JS, not 'INCLUDE'ing it

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20772: Display and edit of price_paid
Andrew Isherwood [Mon, 21 May 2018 09:40:59 +0000 (10:40 +0100)]
Bug 20772: Display and edit of price_paid

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20772: Return cost & price_paid in API
Andrew Isherwood [Thu, 17 May 2018 10:36:50 +0000 (11:36 +0100)]
Bug 20772: Return cost & price_paid in API

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20772: Fix malformed class name
Andrew Isherwood [Thu, 17 May 2018 10:29:49 +0000 (11:29 +0100)]
Bug 20772: Fix malformed class name

Supplier metadata elements have a dynamically formed class name, part of
the name is formed from the metadata key, this breaks if the key has a
space, so we replace spaces

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20772: Borrowernumber should be read only
Andrew Isherwood [Thu, 17 May 2018 09:58:02 +0000 (10:58 +0100)]
Bug 20772: Borrowernumber should be read only

On the Manage Request page, borrowernumber should be read only, we do
not want users modifying the destination user once a request is placed

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20772: Add 'illrequest.price_paid'
Andrew Isherwood [Thu, 17 May 2018 09:47:52 +0000 (10:47 +0100)]
Bug 20772: Add 'illrequest.price_paid'

This patch adds a 'price_paid' column to 'illrequests'

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20772: Add 'illrequestattributes.readonly'
Andrew Isherwood [Thu, 17 May 2018 08:22:03 +0000 (09:22 +0100)]
Bug 20772: Add 'illrequestattributes.readonly'

This patch adds a 'readonly' column to illrequestattributes. On a DB
upgrade it also populates all existing rows with 1, indicating 'read
only'

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 21178: (QA follow-up) Add a test to verify that the hash is correct
Julian Maurice [Fri, 5 Oct 2018 15:18:57 +0000 (17:18 +0200)]
Bug 21178: (QA follow-up) Add a test to verify that the hash is correct

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 21178: (QA follow-up) whitespace characters fix
Tomas Cohen Arazi [Fri, 14 Sep 2018 23:15:13 +0000 (16:15 -0700)]
Bug 21178: (QA follow-up) whitespace characters fix

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 21178: Add Koha::Patron::set_password
Tomas Cohen Arazi [Thu, 16 Aug 2018 10:13:56 +0000 (07:13 -0300)]
Bug 21178: Add Koha::Patron::set_password

This patch introduces the 'set_password' method for Koha::Patron
objects. The main point is to make password changing atomic
(update_password touches the userid on the DB, which should be done
carefully with better error handling, and it is done there only for
legacy backwards compatibility).

A follow-up bug will make the codebase use this instead of
update_password, and use a proper method for changing the userid if
required.

To test:
- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests pass!
- Sign off! :-D

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 21178: Unit tests
Tomas Cohen Arazi [Thu, 16 Aug 2018 10:13:36 +0000 (07:13 -0300)]
Bug 21178: Unit tests

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 21541: Use raw filter for report results
Nick Clemens [Wed, 10 Oct 2018 16:30:15 +0000 (16:30 +0000)]
Bug 21541: Use raw filter for report results

To test:
 1 - Create new report
 SELECT CONCAT('<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=',borrowernumber,'">',"",firstname,"",surname,'</a>')
 AS people
 FROM borrowers
 2 - Run this report
 3 - Note the results contain raw text, they are not hyperlinks
 4 - Apply patch
 5 - Reload the results
 6 - They should now be links

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 21464: Hide patron's title not biblio's title
Jonathan Druart [Tue, 9 Oct 2018 17:01:07 +0000 (14:01 -0300)]
Bug 21464: Hide patron's title not biblio's title

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 21464: Fix overdue list export
Jonathan Druart [Mon, 1 Oct 2018 20:18:18 +0000 (17:18 -0300)]
Bug 21464: Fix overdue list export

  commit e09ed656af5f75a82ccfa29318081e217618c32d
  Bug 18403: Only display libraries from group in dropdown lists
and
  commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d
  Bug 18789: Send Koha::Patron object to the templates

broke the overdue list export.

Test plan:
Create some overdues
Export them: "Home › Circulation › Overdues" then click the link on top
of the table.
All the different columns of the generated CSV file must be filled
correctly

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 20260: Use CodeMirror for the SQL reports editor
Owen Leonard [Wed, 10 Oct 2018 16:44:10 +0000 (16:44 +0000)]
Bug 20260: Use CodeMirror for the SQL reports editor

This patch adds CodeMirror syntax highlighting to the SQL reports
editor. Newly added is a file containing the sql-specific syntax
highlighting code, in both compressed and uncompressed versions.

Unrelated changes:

 - Some JavaScript has been moved from inside the body of the page to
   the footer.
 - Paths to some assets have been corrected to no use relative paths.

To test, apply the patch and go to Reports -> Saved SQL reports

- Edit an existing report and confirm that the SQL is correctly
  highlighted and that there are no display problems when editing.
- Confirm that changes are saved successfully.
- Perform the same test when creating a new SQL report.
- View an existing report and confirm that the SQL is syntax-highlighted
  but is read-only.

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 21479: Remove the trace if the node does not exist
Jonathan Druart [Fri, 12 Oct 2018 18:37:44 +0000 (15:37 -0300)]
Bug 21479: Remove the trace if the node does not exist

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 21479: Add regression tests
Jonathan Druart [Tue, 9 Oct 2018 16:30:54 +0000 (13:30 -0300)]
Bug 21479: Add regression tests

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 21479: Fix remove from cart links at the OPAC (should remove only 1)
Owen Leonard [Wed, 3 Oct 2018 14:13:49 +0000 (14:13 +0000)]
Bug 21479: Fix remove from cart links at the OPAC (should remove only 1)

This patch changes the way biblionumbers are passed to the cart script
for adding and removing single items. The title's biblionumber is now
stored in a data-attribute on the links for adding and removing. This
should be a more robust, unified way to handle these single-item
operations.

To test, apply the patch and enable the opacbookbag system preference.

Test adding and removing items from the cart from various pages using
various methods:

 - By clicking an "Add to your cart" / "Remove" link in search results
 - By clicking an "Add to your cart" / "Remove" link on a detail page
 - By checking boxes in search results and adding via the dropdown

Each operation should work correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 21553: Remove JS error on the Rota view
Jonathan Druart [Fri, 12 Oct 2018 14:18:17 +0000 (11:18 -0300)]
Bug 21553: Remove JS error on the Rota view

JS error was:
 ReferenceError: _ is not defined

The strings after staff-global.js (for the function _)

Test plan:
Turn on StockRotation system preference

1) Go to a staff detail page
2) Switch to rota page
3) Check web developer tools

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
Mirko Tietgen [Wed, 10 Oct 2018 14:17:17 +0000 (16:17 +0200)]
Bug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled

t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
if WebService::ILS is not available.

Test plan:
- have a system without Webservice::ILS available
- in koha-shell, do
  prove t/Koha_ExternalContent_RecordedBooks.t
- tests should be skipped and tests count as "passed"

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 11897: Add mising semi-colon to user*.sql
Jonathan Druart [Tue, 9 Oct 2018 17:11:28 +0000 (14:11 -0300)]
Bug 11897: Add mising semi-colon to user*.sql

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: (follow-up) Add Stock Rotation atomic update schema
Jonathan Druart [Tue, 9 Oct 2018 17:08:33 +0000 (14:08 -0300)]
Bug 11897: (follow-up) Add Stock Rotation atomic update schema

Remove the duplicate entry for RoutingListAddReserves
I guess it has been caused by a bad merge resolution conflict

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7143: (follow-up) remove trailing apostrophe
Nick Clemens [Tue, 9 Oct 2018 16:12:59 +0000 (16:12 +0000)]
Bug 7143: (follow-up) remove trailing apostrophe

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: Add Boolean handling to dbic classes.
Martin Renvoize [Tue, 4 Sep 2018 13:34:14 +0000 (14:34 +0100)]
Bug 11897: Add Boolean handling to dbic classes.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: DBIX::Class::Ordered in Stockrotationstage.
Alex Sassmannshausen [Fri, 9 Dec 2016 08:47:02 +0000 (09:47 +0100)]
Bug 11897: DBIX::Class::Ordered in Stockrotationstage.

* Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add
  grouping_column.

Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: DBRev 18.06.00.040
Nick Clemens [Tue, 9 Oct 2018 15:51:34 +0000 (15:51 +0000)]
Bug 11897: DBRev 18.06.00.040

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: (QA follow-up) Convert atomic update to perl
Martin Renvoize [Tue, 9 Oct 2018 14:03:23 +0000 (15:03 +0100)]
Bug 11897: (QA follow-up) Convert atomic update to perl

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: Translatability and wrong escaping fix
Tomas Cohen Arazi [Fri, 5 Oct 2018 14:34:42 +0000 (11:34 -0300)]
Bug 11897: Translatability and wrong escaping fix

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: (QA follow-up) Move menu to 'Catalog'
Martin Renvoize [Fri, 5 Oct 2018 14:15:25 +0000 (15:15 +0100)]
Bug 11897: (QA follow-up) Move menu to 'Catalog'

Originally this menu item was placed under the 'Patrons' section of the
tools page, this patch moves it to the more appropriate 'Catalog'
section.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: (QA follow-up) Update of tools-menu.js
Martin Renvoize [Fri, 5 Oct 2018 14:05:22 +0000 (15:05 +0100)]
Bug 11897: (QA follow-up) Update of tools-menu.js

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: (QA follow-up) Fixes for JS12
Martin Renvoize [Fri, 5 Oct 2018 13:43:41 +0000 (14:43 +0100)]
Bug 11897: (QA follow-up) Fixes for JS12

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: 'superlibrarian' has 'stockrotation' perms
Tomas Cohen Arazi [Fri, 5 Oct 2018 12:44:15 +0000 (09:44 -0300)]
Bug 11897: 'superlibrarian' has 'stockrotation' perms

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: (QA follow-up) Template filter fixes
Tomas Cohen Arazi [Thu, 4 Oct 2018 19:44:50 +0000 (16:44 -0300)]
Bug 11897: (QA follow-up) Template filter fixes

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: Add sample notices for all languages
Tomas Cohen Arazi [Thu, 4 Oct 2018 19:44:06 +0000 (16:44 -0300)]
Bug 11897: Add sample notices for all languages

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: Use 'stockrotation' permission for the endpoint
Tomas Cohen Arazi [Thu, 4 Oct 2018 17:24:16 +0000 (14:24 -0300)]
Bug 11897: Use 'stockrotation' permission for the endpoint

This patch makes the tests for 'authorized' session use the
'stockrotation' permission instead of 'superlibrarian'.

The path x-koha-permission is fixed accordingly.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: (QA follow-up) Fix tests
Tomas Cohen Arazi [Thu, 4 Oct 2018 17:08:05 +0000 (14:08 -0300)]
Bug 11897: (QA follow-up) Fix tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: (QA follow-up) Remove rebase leftover
Tomas Cohen Arazi [Thu, 4 Oct 2018 16:45:15 +0000 (13:45 -0300)]
Bug 11897: (QA follow-up) Remove rebase leftover

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: Stockrotation
Martin Renvoize [Mon, 1 Oct 2018 16:46:40 +0000 (17:46 +0100)]
Bug 11897: Stockrotation

The stock rotation feature adds a batch process to automate rotation of
catalgue items with a staff client page under tools to manage rotas/schedules.

Once a rota is configured, and your staff user has the right permissions
to allocate items, then an additional tab will appear on biblio records
allowing the management of of which rota, if any, individual items belong to.

It also includes a cron script to process the items on a daily basis.

Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit: I removed a temporary file

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 11897: Add Stock Rotation atomic update schema.
Alex Sassmannshausen [Mon, 17 Oct 2016 16:20:44 +0000 (18:20 +0200)]
Bug 11897: Add Stock Rotation atomic update schema.

* installer/data/mysql/atomicupdate/stockrot_tables.sql: New file.
* installer/data/mysql/kohastructure.sql (stockrotationrotas)
  (stockrotationstages, stockrotationitems): New tables.
* installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs.
* installer/data/mysql/userflags.sql: Add Stockrotaiton userflag.
* installer/data/mysql/userpermissions.sql: Add Stockrotation
  userpermissions.
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref:
  Add Stockrotation menu.

Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 15734: Use To.json to filter audio alerts
Jonathan Druart [Tue, 9 Oct 2018 13:47:11 +0000 (10:47 -0300)]
Bug 15734: Use To.json to filter audio alerts

Test Plan:
1) Enable audio alerts
2) Note audio alerts don't work
3) Apply this patch
4) Note audio alerts now work

Use complex selectors to test:
  #circ_returns p.problem:contains('Not checked out.')
  #doc3 > #bd

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 15520: DBRev 18.06.00.039
Nick Clemens [Tue, 9 Oct 2018 12:55:05 +0000 (12:55 +0000)]
Bug 15520: DBRev 18.06.00.039

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 15520: (QA follow-up) Fix renaming of circ rules permission
Josef Moravec [Mon, 1 Oct 2018 20:15:21 +0000 (20:15 +0000)]
Bug 15520: (QA follow-up) Fix renaming of circ rules permission

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 15520: Rename permission to manage_circ_rules_from_any_libraries
Jonathan Druart [Mon, 23 Jul 2018 22:11:59 +0000 (19:11 -0300)]
Bug 15520: Rename permission to manage_circ_rules_from_any_libraries

Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 15520: Add permission to restrict circ rules editing to own library
Jesse Weaver [Thu, 31 Aug 2017 23:02:42 +0000 (17:02 -0600)]
Bug 15520: Add permission to restrict circ rules editing to own library

Test plan:

1) Ensure that you have four users:
 a) A superlibrarian
 b) A user with all `parameters` permissions (the toplevel `parameters`
    box is checked).
 c) A user with the `manage_circ_rules` permission (and, of course,
    `catalogue`).
 d) A user with the `manage_circ_rules`, `manage_circ_rules_restricted`
    and `catalogue` permissions.
2) As all four users, load the "Circulation and fine rules"
   administration page (admin/smart-rules.pl).
3) The page should be unchanged for the first three users. It should be
   possible to view and edit the circ rules for all libraries.
4) The last (restricted) user should only be able to view and edit the
   circ rules for their own library.

Amended by JD: In a second version of this patch
manage_circ_rules_restricted has been replaced by
manage_circ_rules_from_any_libraries and 'no_inherit' related code has
been removed

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19625: Enable Shibboleth auto-provisioning for Plack
Matthias Meusburger [Wed, 15 Nov 2017 10:50:27 +0000 (10:50 +0000)]
Bug 19625: Enable Shibboleth auto-provisioning for Plack

Test plan:
1. In $KOHA_CONF, check that //shibboleth/autocreate is set to 1
2. Find a user in Shibboleth that is not in Koha (or remove it from
   Koha)
3. Login with that user
4. Verify that the userid is not set correctly in Koha database
5. Apply the patch (restart starman)
6. Repeat steps 2 and 3
7. Verify that the userid is set correctly and the other
mapped fields if there are some

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 17776: (QA follow-up) Remove shibboleth package variables
Marcel de Rooy [Fri, 5 Oct 2018 08:19:14 +0000 (10:19 +0200)]
Bug 17776: (QA follow-up) Remove shibboleth package variables

This is about $shib and $shib_login.
We move in the right direction by calling get_login_shib in
get_template_and_user and checkauth. In the same line we can do the
shib_ok check at that time (just checking cached values). This paves
the way for the third subroutine using the two package vars: checkpw.
Note that checkpw is also called outside Auth.pm. So I would be more
comfortable if we do the same calls like in checkauth and remove both
variables from the package level (especially under Plack of course).

The former changes actually justify a 'use C4::Auth_with_shibboleth'
instead of the current require and import.

Note: When calling checkpw from checkauth, we are calling get_login_shib
twice now. But the time involved for doing so is around zero (cache), so
not really an argument for extra parameters and complexer code.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 17776: (QA follow-up) Consistent regex for Plack detection
Marcel de Rooy [Fri, 5 Oct 2018 08:25:43 +0000 (10:25 +0200)]
Bug 17776: (QA follow-up) Consistent regex for Plack detection

Synchronizing:
C4/Auth_with_shibboleth.pm:    if ( any { /(^psgi|^plack)/i } keys %ENV ) {
Koha/AuthUtils.pm:    if ( ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) && $ENV{SCRIPT_NAME} =~ m,^/(intranet|opac)(.*), ) {
about.pl:if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) {

Actually we should move it to a subroutine. New report please.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 17776: (follow-up) Add note about NativeSPSpoofChecking
Martin Renvoize [Fri, 28 Sep 2018 12:31:13 +0000 (13:31 +0100)]
Bug 17776: (follow-up) Add note about NativeSPSpoofChecking

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Amended the text a bit:
Hopefully, an uppercase important attracts slightly more attention :)
Added the bug number too.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 17776: Enable Shibboleth for Plack
Martin Renvoize [Thu, 2 Mar 2017 16:40:11 +0000 (16:40 +0000)]
Bug 17776: Enable Shibboleth for Plack

https://bugs.koha-community.org/show_bug.cgi?id=17776

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21426: Handle USE_MEMCACHED=no in koha-create
Jonathan Druart [Sat, 29 Sep 2018 18:16:46 +0000 (15:16 -0300)]
Bug 21426: Handle USE_MEMCACHED=no in koha-create

Signed-off-by: Andreas Roussos <arouss1980@gmail.com>
Works as intended. I've set USE_MEMCACHED to "no" and created a new
Koha instance. Home > About now reports this information: Memcached:
Servers: undefined | Namespace: undefined | Status: unknown | Config
read from: Nowhere [...] | Effective caching method: Cache::Memory

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21493: Compiled CSS
Nick Clemens [Tue, 9 Oct 2018 12:38:28 +0000 (12:38 +0000)]
Bug 21493: Compiled CSS

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21493: Remove incomplete icon style from serial issues tabs
Owen Leonard [Thu, 4 Oct 2018 18:45:39 +0000 (18:45 +0000)]
Bug 21493: Remove incomplete icon style from serial issues tabs

This patch adds CSS to exclude serial issues history links from having
an icon background. There is no part of the icon sprite which is
designed for that purpose.

This patch also tweaks the positioning of a couple of icons and makes
other minor corrections to related CSS.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Open the detail page for a bibliographic record in the OPAC which has
  subscriptions.
- Click the "More details" link.
- Confirm that the "Brief history" and "Full history" links have no
  icon.
- Click the "Full history" link and do the same.
- On the normal, MARC, and ISBD views, confirm that the icons for those
  links look correct.
- View the purchase suggestions page as a logged-in user. Confirm that
  the "new purchase suggestion" link looks correct.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20151: always use current language for stemming
Fridolin Somers [Wed, 7 Feb 2018 14:06:56 +0000 (15:06 +0100)]
Bug 20151: always use current language for stemming

When stemming is enabled, in catalog searching "C4::Search::_build_stemmed_operand" will transform query operand into stemmed operand using stemmer Lingua::Stem::Snowball with a specified language.
This stemmer returns undef stemmed operand if no language is defined.

In main catalog search (catalogue/search.pl) current language is used.
But in other pages "acqui/neworderbiblio.pl" and "cataloguing/addbooks.pl" no language is defined so stemmed operand is empty and so stemming is not applied.

This patch corrects by returning in "C4::Search::_build_stemmed_operand" operand without change if no langage is defined.
And uses current langage in pages "acqui/neworderbiblio.pl" and "cataloguing/addbooks.pl" so all catalog search uses stemming.

Test plan :
1) Enable system preferences QueryStemming and QueryWeightFields
2) Disable system preferences QueryAutoTruncate, QueryFuzzy and UseQueryParser
3) Go to intranet main page and click on "Search the catalog" tab
4) Perform a search (without index) that uses the stemming, for example searching for "years" will also match "year"
5) Note how many results you get, for example "year" gets 24 results and "years" gets 24 results
6) Go to "Cataloging" module
7) Perform a search on same word in "Cataloging search" tab
8) Note how many results you get
9) Without patch you get fewer results than first search (step 5) because stemming is not applied, for example "year" gets 11 results and "years" gets 15 results
10) With patch you get the same results as first search (step 5) because stemming is applied, for example "year" and "years" gets 24 results
11) Same tests in aquisition module
12) On a basket, click "Add to basket" and perform a search in "From an existing record"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21389: Correct Javascript error on article requests page
Fridolin Somers [Fri, 21 Sep 2018 09:17:25 +0000 (11:17 +0200)]
Bug 21389: Correct Javascript error on article requests page

Bug 21076 fixed a Javascript error on article requests page when patron is found.

There is also an error when patron is not found, with message :
  Patron not found
  No patron with this name, please, try another

This patch fixes by replacing TT condition by a JS condition testing the existance of the patron input.

Test plan:
1 - Do not apply patch
2 - Enable article requests
3 - Search on staff client and click 'Request article'
4 - Search for a patron that does not exist
5 - You get a yellow message "Patron not found"
6 - View error in console
7 - Apply patch
8 - Reload
9 - Not error is gone
10 - Search for a patron that does exist
11 - Check there is no error in console
12 - Check that autocompletion works

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20548: (follow-up) Fix unit tests
Andrew Isherwood [Wed, 26 Sep 2018 13:04:00 +0000 (14:04 +0100)]
Bug 20548: (follow-up) Fix unit tests

Removed the "Backend create: copyright clearance" unit test since we no
longer have a "copyrightclearance" stage, hence we don't have a block in
the template handling it, hence the test failure!

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20548: Remove copyright clearance for staff
Andrew Isherwood [Mon, 9 Apr 2018 14:04:35 +0000 (15:04 +0100)]
Bug 20548: Remove copyright clearance for staff

This patch removes the erroneously added workflow that requires staff
users to agree to the copyright clearance declaration defined in the
ILLModuleCopyrightClearance preference. Only OPAC users should be
required to accept the declaration.

To test:
1) Ensure you have at least one ILL backend available:
  https://wiki.koha-community.org/wiki/ILL_backends
2) Ensure you have the "ILLModule" preference enabled
3) Add some text to the "ILLModuleCopyrightClearance" preference
4) As an OPAC user make an ILL request:
  a) Navigate to a search results page in the catalog
  b) Click the "Make an Interlibrary Loan request" link at the bottom
  c) Choose "Create a new request", then select a backend
  d) Observe the text you added earlier is displayed with buttons for
  agreeing or disagreeing
5) As a staff user, select the "ILL requests" button on the front page of
the intranet site
  a) Choose "Create a new request", then select a backend
  b) Observe that you are NOT prompted to agree to the text you added
  earlier

Assigned-to: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Signed-off-by: Barry Cannon <bc@interleaf.ie>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 16420: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialo...
Owen Leonard [Fri, 5 Oct 2018 17:05:19 +0000 (17:05 +0000)]
Bug 16420: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin

This patch makes minor changes to the text of hold confirmation buttons
in the checkin process in order to make them more consistent.

Also changed: Removed the "danger" class from the "Ignore" button for
readability and consistency's sake.

To test, apply the patch and check in an item which is on hold for a
patron at your logged-in library. The hold confirmation dialog's buttons
should read "Confirm hold," "Print slip and confirm," and "Ignore."

Confirm the hold, then check in the same item again.

In the dialog, the buttons should read "Confirm hold," "Print slip and
confirm," and "Cancel hold."

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21500: Remove warnings in rotating collections
Tomas Cohen Arazi [Thu, 4 Oct 2018 17:08:32 +0000 (14:08 -0300)]
Bug 21500: Remove warnings in rotating collections

To test:
- Go to Tools > Rotating collections
=> FAIL: Some warinings on the logs
- Apply this patch
- Reload page
=> SUCCESS: No warinings
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21506: DataTables four button pagination uses the wrong icon for First and Last...
Andreas Roussos [Sat, 6 Oct 2018 07:15:26 +0000 (10:15 +0300)]
Bug 21506: DataTables four button pagination uses the wrong icon for First and Last buttons

Pages with DataTables' four button pagination use the wrong
icon for 'First' and 'Last'. Also, the icons for all four
buttons are truncated at the bottom.

This patch fixes that.

Test plan:
1) Go to a page that uses four button pagination (e.g. Home >
   Administration > MARC frameworks) and notice how the
   pagination icons for First/Previous and Next/Last are the
   same. Also notice all four icons are clipped at the bottom.
2) Apply the patch.
3) Refresh the page; the First and Last buttons' icons now
   include a vertical bar, and there is no clipping visible.
4) For completeness, check other affected pages as well.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21417: DBRev 18.06.00.038
Nick Clemens [Tue, 9 Oct 2018 11:30:23 +0000 (11:30 +0000)]
Bug 21417: DBRev 18.06.00.038

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21417: (QA follow-up) Display default EAN as such in admin display
Colin Campbell [Thu, 27 Sep 2018 15:07:37 +0000 (16:07 +0100)]
Bug 21417: (QA follow-up) Display default EAN as such in admin display

A branch value of null is interpreted as the default
Add text 'All libraries' to this case in the display
rather than blank so that its function is clear to the
user

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21417: EDI ordering fails when basket and EAN libraries do not match
Kyle M Hall [Thu, 27 Sep 2018 10:51:27 +0000 (06:51 -0400)]
Bug 21417: EDI ordering fails when basket and EAN libraries do not match

When clicking Create EDIFACT Order on /acqui/basket.pl, an EDIFACT message will not be generated if aqbasket.branch does not match edifact_ean.branchcode. This failure does not generate any sort of error message, it just fails to produce a message.

We should allow ean's to not require a branch to be set, then if we don't find a branch specific each, we can look for the default version of the ean.

Test Plan:
1) Apply this patch set
2) Run updatedatabase
3) Verify you can create a Library EAN without setting a branchcode for it
4) Verify you can use this EAN to send an EDI order where the basket has a branchcode set

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21455: Authority search options get shuffled around when you click on 'Search'
Andreas Roussos [Sat, 29 Sep 2018 16:51:45 +0000 (19:51 +0300)]
Bug 21455: Authority search options get shuffled around when you click on 'Search'

In the staff client, when you perform an authority search the
selected values for the 'Search all headings:' and 'Search
entire record:' options get shuffled around when you click on
the 'Search' button.

This patch fixes that.

Test plan:
1) Perform an authority search and set the 'Search all headings:'
   option to 'starts with'.
2) Click on the 'Search' button.
3) Notice how the 'Search all headings:' option is now 'contains',
   and 'starts with' has moved down to the 'Search entire record:'
   option.
4) Apply the patch.
5) Hit 'Search' again. This time the selected search options do
   not move around.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21470: Compiled CSS
Nick Clemens [Tue, 9 Oct 2018 11:13:46 +0000 (11:13 +0000)]
Bug 21470: Compiled CSS

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21470: Due date no longer shown in red when viewing checkouts for a patron
Owen Leonard [Tue, 2 Oct 2018 13:50:28 +0000 (13:50 +0000)]
Bug 21470: Due date no longer shown in red when viewing checkouts for a patron

This patch corrects an error in the staff client CSS which was causing
overdue items on the checkout screen to not be highlighted.

To test, apply the patch and regenerate the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Check out to a patron who has overdues. The overdue items should have
due dates styled bold and red.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20910: Tidy 773 handling XSLT code
Tomas Cohen Arazi [Mon, 11 Jun 2018 15:05:27 +0000 (12:05 -0300)]
Bug 20910: Tidy 773 handling XSLT code

There's happiness too. You know.

Sponsored-by: Escuela de Orientacion Lacaniana
Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20910: Display 773$g when $0 is present too
Tomas Cohen Arazi [Mon, 11 Jun 2018 14:34:22 +0000 (11:34 -0300)]
Bug 20910: Display 773$g when $0 is present too

This patch makes the XSLT logic add the $g subfield in the 773 display
in both the OPAC and staff interface MARC21 record detail pages.

The XSLT chooses between different ways to create the link for the
related content, but then it only adds the $g in two of the cases.
There's no obvious reason for a different display.

To test:
- Have  a record with:

=773   $tHost title $gp4.

=> SUCCESS: Notice the Detail view shows:
  In: Host title p4.

- Have another record with:

=773   $tHost title $gp4. $w100
- Enable UseControlNumber (only to cover the case):
=> SUCCESS: Notice the detail view shows
  In: Host title p4.

- Have another record with:

=773   $tHost title $gp4. $0456

=> FAIL: The Detail view doesn't show p4.
- Apply this patch
- Reload
=> SUCCESS: The Detail view displays p4.!
- Sign off :-D

Sponsored-by: Escuela de Orientacion Lacaniana
Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20177: [sql_modes] Fix GROUP BY clause in GetCourses
Jonathan Druart [Mon, 5 Feb 2018 21:13:06 +0000 (18:13 -0300)]
Bug 20177: [sql_modes] Fix GROUP BY clause in GetCourses

Fix for:
'koha_kohadev.courses.department' isn't in GROUP BY

t/db_dependent/CourseReserves.t

A better fix would be to remove the joins and only return values from
the courses table. But more work is needed to acchieve that goal.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Test passes and the behavior of Course reserves appears to be unchanged
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 9968: Fix wrong index for Standard number in advanced and label search
Katrin Fischer [Wed, 16 May 2018 01:05:07 +0000 (01:05 +0000)]
Bug 9968: Fix wrong index for Standard number in advanced and label search

'Standard number' indicates that you can search ISBN, ISSN and other
standard numbers, but we are using the wrong index and only get a
very limited search for biblionumber instead.

This patch changes the index from sn to ident.

To test:
- Check both staff and OPAC advanced search:
  - Search for Standard number = ISBN
  - Search for Standard number = ISSN
  Both should work.
  Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences
- Check the label creator
  - Add a new batch
  - Use 'add items' option and search for Standard number

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21082: (RM follow-up) address QA issues
Nick Clemens [Tue, 9 Oct 2018 10:56:43 +0000 (10:56 +0000)]
Bug 21082: (RM follow-up) address QA issues

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21082: DBRev 18.06.00.037
Nick Clemens [Tue, 9 Oct 2018 10:41:03 +0000 (10:41 +0000)]
Bug 21082: DBRev 18.06.00.037

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21082: Update OverDrive authentication method
Nick Clemens [Tue, 17 Jul 2018 14:16:33 +0000 (14:16 +0000)]
Bug 21082: Update OverDrive authentication method

Testing will require an OverDrive account, you should be able to obtain a
developer account here:
https://developer.overdrive.com/

You will need to register a SIP connection for patron authentication

To test authentication:
 1 - Set authname default in OD prefs
 2 - Sign in as a patron whose branch matches authname
 3 - Verify the patron can sign into OverDrive
 4 - Set the patrons branch authname to be incorrect
 5 - Verify branch specific authname is used and patron cannot sign in
 6 - Set the default authname to be incorrect and patron's branch
 authname to be correct
 7 - Verofy patron can sign in

To test circulation:
 1 - Fill out all OD prefs and enable circulation
 2 - Sign in to opac
 3 - Verify you have an OverDrive tab
 4 - Click 'Login to Overdrive'
 5 - If password required you shoudl be prompted, otherwise you should be
signed in and see account info
 6 - Test logging out and in
 7 - Log-in, perform a search on the opac - you should see hold/checkout
buttons
 8 - Test the buttons
 9 - After holding/checking out items, check your account page
10 - Verify info is correct
11 - Log out of overdrive
12 - Search catalog click overdrive results
13 - Test "Login to Overdrive" link on OD results
14 - Verify page is reloaded, buttons show and work

Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21082: Add new admin page for overdrive
Nick Clemens [Tue, 17 Jul 2018 14:08:13 +0000 (14:08 +0000)]
Bug 21082: Add new admin page for overdrive

The 'authname' field required for OverDrive can differ per branch.
This patch adds Koha Objects for dealing with OD info and submitting
authnames per branch. The description is left open so future branch info
can be added.

To test:
1 - prove -v t/db_dependent/Koha/Library/OverDriveInfos.t
2 - visit cgi-bin/koha/admin/overdrive.pl
3 - Add some authnames for various branches
4 - Verify data saves correctly

Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21082: Database updates
Nick Clemens [Tue, 17 Jul 2018 13:50:43 +0000 (13:50 +0000)]
Bug 21082: Database updates

Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21463: (bug 18789 follow-up) Fix library display on the overdue list view
Jonathan Druart [Mon, 1 Oct 2018 16:42:07 +0000 (13:42 -0300)]
Bug 21463: (bug 18789 follow-up) Fix library display on the overdue list view

branchcode is no longer retrieved from the SQL query, we should use the
Koha::Patron object instead.

Test plan:
Create some overdues and list them on Home › Circulation › Overdues
=> With this patch applied you should see that the "Library" column is
correctly filled with the patron's library name

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21440: koha-create expects the file passed by $DEFAULTSQL to be in gzip format
Andreas Roussos [Thu, 27 Sep 2018 16:05:48 +0000 (19:05 +0300)]
Bug 21440: koha-create expects the file passed by $DEFAULTSQL to be in gzip format

koha-create contains a call to `zcat` which fails if the file passed
as an argument is not in gzip format.

This patch fixes the issue by adding the -f flag to the zcat call in
koha-create, as per the top-voted answers in the following SE URLs:
https://unix.stackexchange.com/a/77309
https://unix.stackexchange.com/a/131944

Test plan:
1) in /etc/koha/koha-sites.conf, set the DEFAULTSQL variable to point
   to an _uncompressed_ SQL database dump
2) run `koha-create --create-db instance` and notice how it fails with:
   gzip: /path/to/dump.sql: not in gzip format
3) apply the patch
4) notice the extra line of information "The SQL file can be optionally
   compressed with gzip" in koha-sites.conf
5) run the `koha-create` command again, this time it should work
6) repeat with DEFAULTSQL pointing to a gzip'd dump, it should work too

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21352: (QA follow-up) - correction to testplan
Martin Renvoize [Mon, 8 Oct 2018 12:46:15 +0000 (13:46 +0100)]
Bug 21352: (QA follow-up) - correction to testplan

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21481: (QA follow-up) Remove last reference to text-extract2
Julian Maurice [Fri, 5 Oct 2018 12:25:34 +0000 (14:25 +0200)]
Bug 21481: (QA follow-up) Remove last reference to text-extract2

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21481: Remove reference of *-staff-help.po from koha-translate
Josef Moravec [Wed, 3 Oct 2018 10:42:44 +0000 (10:42 +0000)]
Bug 21481: Remove reference of *-staff-help.po from koha-translate

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21481: Remove obsolete files from translation toolkit
Josef Moravec [Wed, 3 Oct 2018 10:39:58 +0000 (10:39 +0000)]
Bug 21481: Remove obsolete files from translation toolkit

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Conflicts:
misc/translator/text-extract.pl
misc/translator/text-extract2.pl

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21481: Remove *-staf-help.po files
Josef Moravec [Wed, 3 Oct 2018 10:20:29 +0000 (10:20 +0000)]
Bug 21481: Remove *-staf-help.po files

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21481: Remove references to help from LangInstaller
Josef Moravec [Wed, 3 Oct 2018 10:19:40 +0000 (10:19 +0000)]
Bug 21481: Remove references to help from LangInstaller

Test plan:
1) Aply the patches
2) cd misc/translator
3) Run these command one by one:
    ./translate install <lang-code>
    ./translate update <lang-code>
    ./translate create <lang-code>
4) All should not end with error and must do what is documented (see
    ./translate --help)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 18887: DBRev 18.06.00.036
Nick Clemens [Fri, 5 Oct 2018 14:49:13 +0000 (14:49 +0000)]
Bug 18887: DBRev 18.06.00.036

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 18887: Make DB update idempotent
Jonathan Druart [Wed, 3 Oct 2018 14:04:45 +0000 (11:04 -0300)]
Bug 18887: Make DB update idempotent

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>