]> git.koha-community.org Git - koha.git/commit
Bug 11369: fix issue that can cause staff client searches to stop working
authorOlli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
Wed, 11 Dec 2013 12:28:53 +0000 (14:28 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 7 May 2014 16:33:08 +0000 (18:33 +0200)
commite597446b9934e8216ccccf4a12cfe1657a959efd
tree5dad76badc17cc451037a3d68ad490198cd41006
parent5a280ab8e360cf46c852872c9687b075c74af7eb
Bug 11369: fix issue that can cause staff client searches to stop working

This patch fixes an issue where too many search cursor cookies overflow
the HTTP-header size after making multiple searches in the staff client.

To replicate this issue, make multiple searches in catalogue/search.pl.
50+ Should be enough to cause the HTTP-request header to overgrow.
One can verify this issue by observing the searchCookie growth in
browser's stored cookies.

-------------
- TEST PLAN -
-------------

Keep making searches.
One should never have more than 10 searchCookies. Browser might display
only 9, because for some reason the newest js-generated cookie is not
included in Firefox's cookies listing.

------------
- DRAWBACK -
------------

Removing these cookies disables the search cursor for traversing search
results (next/previous) for the removed cookie. This maybe be problematic
in some cases,
(for ex when multiple search tabs need to be open and they need to be
 traversed)
One easy solution is to grow the amount of stored searchCookies from 10 to
20, but 10 is chosen so there will be plenty of room for other cookies as
well.

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 0cada7a323db7f9871b67a07e3343642543b64e0)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
catalogue/search.pl
koha-tmpl/intranet-tmpl/js/browser.js