From 3c50683e0d6412b29144962e7f5d539fec28da04 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 22 Nov 2013 10:42:42 +0100 Subject: [PATCH] Bug 11286: fix bug preventing adding a new subfield to an authority framework Bug 10602 introduces a bug when adding a new subfield to an authority framework. A new parameter is added in a sql query but the placeholder is missing. Test plan: - edit an authority framework - add a new subfield - save - boom! DBD::mysql::st execute failed: called with 16 bind variables when 15 are needed at /home/home/src/admin/auth_subfields_structure.pl line 454. - apply the patch and try again Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors Tested trying to add subfield to 100, 2 for example. Without patch silently fails (but error is logged) With patch subfield creation or elimination is fine Signed-off-by: Katrin Fischer One line fix for a bad bug. Confirmed the bug on master and the fix. Passes all tests and QA script. Signed-off-by: Galen Charlton --- admin/auth_subfields_structure.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/admin/auth_subfields_structure.pl b/admin/auth_subfields_structure.pl index d9f10b4e70..fb0e59c7c0 100755 --- a/admin/auth_subfields_structure.pl +++ b/admin/auth_subfields_structure.pl @@ -388,7 +388,7 @@ if ($op eq 'add_form') { # my $sth=$dbh->prepare("replace auth_subfield_structure (authtypecode,tagfield,tagsubfield,liblibrarian,libopac,repeatable,mandatory,kohafield,tab,seealso,authorised_value,frameworkcode,value_builder,hidden,isurl) # values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)"); my $sth_insert = $dbh->prepare("insert into auth_subfield_structure (authtypecode,tagfield,tagsubfield,liblibrarian,libopac,repeatable,mandatory,kohafield,tab,seealso,authorised_value,frameworkcode,value_builder,hidden,isurl,defaultvalue) - values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)"); + values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)"); my $sth_update = $dbh->prepare("update auth_subfield_structure set authtypecode=?, tagfield=?, tagsubfield=?, liblibrarian=?, libopac=?, repeatable=?, mandatory=?, kohafield=?, tab=?, seealso=?, authorised_value=?, frameworkcode=?, value_builder=?, hidden=?, isurl=?, defaultvalue=? where authtypecode=? and tagfield=? and tagsubfield=?"); my @tagsubfield = $input->param('tagsubfield'); -- 2.39.5