From d18b6ab84df6f6171f22e5799089dc2a4334bda4 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Joonas=20Kylm=C3=A4l=C3=A4?= Date: Sun, 4 Sep 2022 14:37:46 +0300 Subject: [PATCH] Bug 31364: Check length of the multiple syspref array instead whether it is null The multiple systempreferences are always defined as an empty array at the minimum, so in order to determine whether we need to remove all the selections from the systempreference we should check whether the array is empty and not whether the array doesn't exist. To test: 1) Set at least 1 value for OPACHoldsIfAvailableAtPickupExceptions 2) Remove all the values for OPACHoldsIfAvailableAtPickupExceptions and notice you get the message "Nothing to save" 3) Apply patch and repeat, removing all the values should work now. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit ce1efe7de0d71362f930a8fc5415fda797531a0b) Signed-off-by: Lucas Gass (cherry picked from commit 191aad389e84fa60b4ef168b9fc97878cb6fcdfa) Signed-off-by: Arthur Suzuki --- koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js index e7d8dad01a..1cc4660a4e 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js +++ b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js @@ -13,7 +13,7 @@ KOHA.Preferences = { // If a multiple select has all its entries unselected var unserialized = new Array(); $(modified_prefs).each(function(){ - if ( $(this).attr('multiple') && $(this).val() == null ) { + if ( $(this).attr('multiple') && $(this).val().length == 0 ) { unserialized.push($(this)); } }); -- 2.39.5