From a2e92b90840ce5faeab587dd113dc4253b312d99 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 29 Oct 2015 14:43:58 +0000 Subject: [PATCH] Bug 15083: Remove acqui/currency.pl This script has scary FIXMEs and can be removed. It is never called from Koha code. On the way, this patch remove the C4::Budgets::ModCurrencies subroutine, which was only called from this script. Test plan: git grep 'acqui/currency.pl and git grep ModCurrencies should not return anything. Signed-off-by: Bernardo Gonzalez Kriegel No more ModeCurrencies, no call to acqui/currency.pl No errors Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- C4/Budgets.pm | 20 -------------------- acqui/currency.pl | 42 ------------------------------------------ 2 files changed, 62 deletions(-) delete mode 100755 acqui/currency.pl diff --git a/C4/Budgets.pm b/C4/Budgets.pm index f2f376a34d..d90246c1ba 100644 --- a/C4/Budgets.pm +++ b/C4/Budgets.pm @@ -61,7 +61,6 @@ BEGIN { &GetCurrency &GetCurrencies - &ModCurrencies &ConvertCurrency &GetBudgetsPlanCell @@ -956,25 +955,6 @@ sub GetCurrency { return $r; } -=head2 ModCurrencies - -&ModCurrencies($currency, $newrate); - -Sets the exchange rate for C<$currency> to be C<$newrate>. - -=cut - -sub ModCurrencies { - my ( $currency, $rate ) = @_; - my $dbh = C4::Context->dbh; - my $query = qq| - UPDATE currency - SET rate=? - WHERE currency=? |; - my $sth = $dbh->prepare($query); - $sth->execute( $rate, $currency ); -} - # ------------------------------------------------------------------- =head2 ConvertCurrency diff --git a/acqui/currency.pl b/acqui/currency.pl deleted file mode 100755 index b7154b72f8..0000000000 --- a/acqui/currency.pl +++ /dev/null @@ -1,42 +0,0 @@ -#!/usr/bin/perl - -#script to display and update currency rates - -# Copyright 2000-2002 Katipo Communications -# Copyright 2008-2009 BibLibre SARL -# -# This file is part of Koha. -# -# Koha is free software; you can redistribute it and/or modify it -# under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 3 of the License, or -# (at your option) any later version. -# -# Koha is distributed in the hope that it will be useful, but -# WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with Koha; if not, see . - -use strict; -use warnings; -use CGI qw ( -utf8 ); -use C4::Acquisition; -use C4::Biblio; -use C4::Budgets; - -# FIXME: CHECK AUTH -# FIXME: This should be part of another script, not a throwaway standalone. -# FIXME: params should have better checks before passed to ModCurrencies -# FIXME: need error handling if ModCurrencies FAILS. - -my $input = new CGI; - -foreach my $param ($input->param) { - if ($param ne 'type' && $param !~ /submit/) { - ModCurrencies($param, $input->param($param)); - } -} -print $input->redirect('/cgi-bin/koha/acqui/acqui-home.pl'); -- 2.39.5