From 74b584adfb27fa4ab22c1e0cf383f7658f21021c Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 14 Oct 2021 12:28:30 +0000 Subject: [PATCH] Bug 29225: Don't hide subgroup filter on pag load When we auto select the last used tab, we hit code that hides the Subgroup dropdown Clicking to other tabs shows the dropdown again There is code on the tab selection to hide subgroups on the 'All' tab, the other line seems superfluous To test: 1 - Create a report and assign a group and subgroup, creating if necessary 2 - Browse to "Reports->Use saved" 3 - Click on the tab for the report you just created, see the subgroups dropdown 4 - Reload the page, Subgroups dropdown disappears 5 - Apply patch 6 - Relaod the page 7 - It's back! 8 - Confirm dropdown filters as expected Signed-off-by: Donna Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 56a98a83e7ef6b070aa1d616eb92ce3be124d273) Signed-off-by: Fridolin Somers --- .../prog/en/modules/reports/guided_reports_start.tt | 1 - 1 file changed, 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index ed5da2ac7c..e24fa91311 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -1590,7 +1590,6 @@ if( activeTab ){ $("#tabs").tabs("option","active", activeTab ); } - $("#subgroup_filter_block").hide(); $("#subgroup_filter").change(function() { var selected = $(this).find('option:selected'); -- 2.39.5