From 23c4078e905118de8a72dda86f2cdecf2c8441f3 Mon Sep 17 00:00:00 2001 From: Mason James Date: Thu, 29 Dec 2016 14:59:17 +1300 Subject: [PATCH] Revert "Bug 14598: (QA followup) Don't die on bad barcode" This reverts commit 575bbbeaba5a2c808725697b1db263dcef9520da. --- C4/Circulation.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 40a8ce5eb3..36abfa20da 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -1813,17 +1813,17 @@ sub AddReturn { my $stat_type = 'return'; # get information on item - my $item = GetItem( undef, $barcode ); - unless ($item) { - return ( 0, { BadBarcode => $barcode } ); # no barcode means no item or borrower. bail out. - } - + my $item = GetItem( undef, $barcode ) + or die "GetItem( undef, $barcode ) failed"; my $itemnumber = $item->{ itemnumber }; my $biblio = GetBiblioData( $item->{ biblionumber } ); my $itemtype = ( C4::Context->preference("item-level_itypes") ) ? $item->{ itype } : $biblio->{ itemtype }; + unless ($itemnumber) { + return (0, { BadBarcode => $barcode }); # no barcode means no item or borrower. bail out. + } my $issue = GetItemIssue($itemnumber); if ($issue and $issue->{borrowernumber}) { $borrower = C4::Members::GetMemberDetails($issue->{borrowernumber}) -- 2.39.5