From 6909c637bdaf2b8dcaf6d895be62d690068ca1a2 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Mon, 25 Sep 2023 15:07:37 +0000 Subject: [PATCH] Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. Test plan: prove t/db_dependent/Koha/Illbackend.t Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize (cherry picked from commit a9f6f47afb1ef16734d89ec0f4c3c3de497e0860) Signed-off-by: Lucas Gass --- Koha/ILL/Request.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Koha/ILL/Request.pm b/Koha/ILL/Request.pm index 49050abd90..e0a9456dc3 100644 --- a/Koha/ILL/Request.pm +++ b/Koha/ILL/Request.pm @@ -299,7 +299,7 @@ correct category and records the fact that the status has changed sub status_alias { my ($self, $new_status_alias) = @_; - my $current_status_alias = $self->SUPER::status_alias; + my $current_status_alias = $self->get_column('status_alias'); if ($new_status_alias) { # Keep a record of the previous status before we change it, @@ -334,7 +334,7 @@ sub status_alias { my $alias = Koha::AuthorisedValues->search( { category => 'ILL_STATUS_ALIAS', - authorised_value => $self->SUPER::status_alias + authorised_value => $current_status_alias }, {}, $self->branchcode @@ -360,8 +360,8 @@ and sends a notice if appropriate sub status { my ( $self, $new_status) = @_; - my $current_status = $self->SUPER::status; - my $current_status_alias = $self->SUPER::status_alias; + my $current_status = $self->get_column('status'); + my $current_status_alias = $self->get_column('status_alias'); if ($new_status) { # Keep a record of the previous status before we change it, -- 2.39.5