From 8e22d67f27a9117d30a72489a2eb80104b5125f6 Mon Sep 17 00:00:00 2001 From: Oliver Behnke Date: Tue, 20 Aug 2024 19:37:36 +0300 Subject: [PATCH] Bug 37525: [SCO] Regression in 32256: "Return this item" doesn't show up despite SCOAllowCheckin being allowed There's a regression in bug 32256 and commit bb059abe respectively: https://gitlab.com/koha-community/Koha/-/commit/bb059abe90#a22dc682a84c41672294c66e441329a451b5cd5a_137_137 The refactoring of "renew" -> "c.renew" missed this line (at least), so the condition is never met. This fixes the issue and restores the original functionality. Test plan: 1. log in with a patron at http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 2. check out an item 3. scan it again 4. see that the "return this item" choice isn't proposed. This is the bug 5. apply patches 6. rescan the item in the self-check out 7. returning is proposed 8. check it in and confirms that it's not checked out anymore Signed-off-by: Oliver Behnke Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize --- koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt index e883f92460..c57c2cadff 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt @@ -135,7 +135,7 @@

This item is already checked out to you: [% c.confirm | html %] ([% c.barcode | html %])

[% END %] - [% IF ( renew && Koha.Preference('SCOAllowCheckin') ) %] + [% IF ( c.renew && Koha.Preference('SCOAllowCheckin') ) %]
[% INCLUDE 'csrf-token.inc' %] Return -- 2.39.5