From ba61c6b8054b34c58dc5914088c200fac529c402 Mon Sep 17 00:00:00 2001 From: Lee Jamison Date: Fri, 11 Aug 2017 18:58:53 +0000 Subject: [PATCH] Bug 19088: plugins-upload causes error log noise After uploading a plugin the error log indicates use of uninitialized value in $op. This patch silences the noise. To test: 1) Set to 1 (one) in koha-conf.xml. 2) Set the UseKohaPlugins system preference to 'Enable'. 3) Navigate to Administration -> Manage plugins. 4) Install the test plugin KPZ file attached to this bug. 5) Notice the uninitialized value noise in the error log. 6) Uninstall the plugin (plack restart may be required if plack is enabled). 7) Apply patch. 8) Install the plugin again. 9) Notice no noise in the error log. 10) Run qa tools. 11) Run prove t/db_dependent/Plugins.t Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart (cherry picked from commit 1076a0edf32b621da54c53ea71595885f7e14c38) Signed-off-by: Fridolin Somers (cherry picked from commit cdcc0458b796aff59a50e0f5d4c7b7140682eacf) Signed-off-by: Katrin Fischer --- plugins/plugins-upload.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/plugins-upload.pl b/plugins/plugins-upload.pl index 853b2acea4..7e1ee197bb 100755 --- a/plugins/plugins-upload.pl +++ b/plugins/plugins-upload.pl @@ -47,7 +47,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( my $uploadfilename = $input->param('uploadfile'); my $uploadfile = $input->upload('uploadfile'); -my $op = $input->param('op'); +my $op = $input->param('op') || q{}; my ( $total, $handled, @counts, $tempfile, $tfh ); -- 2.39.5