From 0f5208ebe160fd49601d3720392c9af55c7ec267 Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Wed, 18 Jan 2023 21:12:48 -1000 Subject: [PATCH] Bug 32678: Add new line in authorized values tests in search_for_data_inconsistencies.pl In search_for_data_inconsistencies.pl, the test for authorized values is a list in one line : * The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }): {94 => AV} {95 => AV} {96 => AV} {97 => AV} {98 => AV} {99 => AV} {100 => AV} {101 => AV} {102 => AV} {103 => AV} It would be more clear with new lines, especially for scripts (grep, awk ...) : * The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }): {94 => AV} {95 => AV} {96 => AV} {97 => AV} {98 => AV} {99 => AV} {100 => AV} {101 => AV} {102 => AV} {103 => AV} Test plan : 1) In koha-testing-docker 2) Delete in authorized values LOC the value AV 3) Run misc/maintenance/search_for_data_inconsistencies.pl => You see the new line in result Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 45323886ae4b73007e2ae2f822ae70a0f46435d0) Signed-off-by: Jacob O'Mara (cherry picked from commit 1453472e93bc9a5d747b7f8ed08985a6726227a1) Signed-off-by: Lucas Gass (cherry picked from commit 519b4f2b59832f5ce5975add20dc8461ad7ca9bc) Signed-off-by: Arthur Suzuki --- misc/maintenance/search_for_data_inconsistencies.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/maintenance/search_for_data_inconsistencies.pl b/misc/maintenance/search_for_data_inconsistencies.pl index 458e107f29..a7969d6643 100755 --- a/misc/maintenance/search_for_data_inconsistencies.pl +++ b/misc/maintenance/search_for_data_inconsistencies.pl @@ -198,7 +198,7 @@ use C4::Biblio qw( GetMarcFromKohaField ); : $table eq 'biblio' ? $i->biblio->$column : $i->biblioitem->$column; - $output .= " {" . $i->itemnumber . " => " . $value . "}"; + $output .= " {" . $i->itemnumber . " => " . $value . "}\n"; } new_item( sprintf( -- 2.39.5