From 81d184dd1d77e277057452d432519f7cc79d5b34 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 6 Jan 2022 09:27:45 -0300 Subject: [PATCH] Bug 29806: Fix POST /holds use of pickup_locations This patch makes Koha::Item->pickup_locations and Koha::Biblio->pickup_locations explicitly call ->as_list in list context. This way we workaround bug 28871. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail, the route gives a 500 (unhandled exception) 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass, the route correctly returns a 400 with a message about the pickup location being invalid 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall (cherry picked from commit 78b5f207cbe8eeb41d6a7ce10944a6e56100bb83) Signed-off-by: Andrew Fuerste-Henry --- Koha/REST/V1/Holds.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Koha/REST/V1/Holds.pm b/Koha/REST/V1/Holds.pm index 08bf1a1fe3..dcfb098f41 100644 --- a/Koha/REST/V1/Holds.pm +++ b/Koha/REST/V1/Holds.pm @@ -149,13 +149,13 @@ sub add { $valid_pickup_location = any { $_->branchcode eq $pickup_library_id } $item->pickup_locations( - { patron => $patron } ); + { patron => $patron } )->as_list; } else { $valid_pickup_location = any { $_->branchcode eq $pickup_library_id } $biblio->pickup_locations( - { patron => $patron } ); + { patron => $patron } )->as_list; } return $c->render( -- 2.39.5