]> git.koha-community.org Git - koha.git/log
koha.git
12 years agoBug 8850: Export CanItemBeReserved in C4::ILSDI::Services
Julian Maurice [Tue, 2 Oct 2012 09:26:39 +0000 (11:26 +0200)]
Bug 8850: Export CanItemBeReserved in C4::ILSDI::Services

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8850: Export CanBookBeReserved in C4::ILSDI::Services
Julian Maurice [Mon, 1 Oct 2012 09:56:22 +0000 (11:56 +0200)]
Bug 8850: Export CanBookBeReserved in C4::ILSDI::Services

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
12 years agocirc/circulation.pl: force issuedate to a string to fix bug 8738
MJ Ray [Fri, 7 Sep 2012 14:17:05 +0000 (15:17 +0100)]
circ/circulation.pl: force issuedate to a string to fix bug 8738

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Installed DataTime version 0.53, verified the error occurs.
Applied patch, verified patch removes the error.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8811 - can't run report after saving
Owen Leonard [Mon, 24 Sep 2012 14:47:27 +0000 (10:47 -0400)]
Bug 8811 - can't run report after saving

The fix for Bug 7993 removed some lines from guided_reports.pl
which passed a new report's name and id to the template after
saving. For some reason this was removed, making it impossible
to run or edit a new report immediately after saving.

This patch adds back that part of the script which passes those
variables to the template. Before this patch, after adding a new
SQL report you would not see a "run this report" link. The
"run this report" and "edit" buttons in the toolbar would not
work. After applying the patch these should work.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested creating reports and was able to run them after saving.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8796 - patron cards not starting on designated card
Marc Veron [Mon, 24 Sep 2012 20:19:56 +0000 (22:19 +0200)]
Bug 8796 - patron cards not starting on designated card

Better wording for the meaning of 'Position' to prevent mistakes on behaviour.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8860 - can't merge if you don't have fast cataloging permissions
Kyle M Hall [Tue, 2 Oct 2012 13:25:16 +0000 (09:25 -0400)]
Bug 8860 - can't merge if you don't have fast cataloging permissions

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8497: Strange behavior when modifying the timeout system preference
Fridolyn SOMERS [Tue, 2 Oct 2012 11:49:32 +0000 (13:49 +0200)]
Bug 8497: Strange behavior when modifying the timeout system preference

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Tested standard login, patron auto-complete, and system preferences.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8810 - Opac: Cart should display branchname instead of branchcode
Marc Veron [Mon, 24 Sep 2012 13:05:12 +0000 (15:05 +0200)]
Bug 8810 - Opac: Cart should display branchname instead of branchcode

In Opac, the cart should display the branchname instead of the branchcode.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8370: Change term issues (smart-rules)
Jonathan Druart [Mon, 17 Sep 2012 12:18:33 +0000 (14:18 +0200)]
Bug 8370: Change term issues (smart-rules)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_8233'
Paul Poulain [Fri, 5 Oct 2012 10:00:06 +0000 (12:00 +0200)]
Merge remote-tracking branch 'origin/new/bug_8233'

12 years agoBug 8233 - SolR-related /etc/ files break deb building
Tomas Cohen Arazi [Mon, 17 Sep 2012 19:55:52 +0000 (16:55 -0300)]
Bug 8233 - SolR-related /etc/ files break deb building

Remove them using debian/rules when building .deb packages until
we figure out what to do with them in a .deb install.

To do this I ran the build script like this:

sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -distribution precise -D precise -r ~/ubuntu -v 3.9.0-046~git -d

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7621'
Paul Poulain [Fri, 5 Oct 2012 09:58:28 +0000 (11:58 +0200)]
Merge remote-tracking branch 'origin/new/bug_7621'

12 years agoBug 7621: Follow up to clarify preference language
Nicole C. Engard [Thu, 27 Sep 2012 04:10:11 +0000 (00:10 -0400)]
Bug 7621: Follow up to clarify preference language

This patch changes strings only, not functionality. It will
clarify the meaning of the  AgeRestrictionMarker preference.

Signed-off-by: Marc Veron <veron@veron.ch>
Better wording of preference instructions. No code echange involved.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_8382'
Paul Poulain [Fri, 5 Oct 2012 09:56:39 +0000 (11:56 +0200)]
Merge remote-tracking branch 'origin/new/bug_8382'

12 years agoBug 8382 [Follow-up] It is not possible to cancel an order when receiving on a filter...
Owen Leonard [Wed, 5 Sep 2012 16:32:32 +0000 (12:32 -0400)]
Bug 8382 [Follow-up] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

In order to be valid XHTML ampersands must be encoded ("&amp;").

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8827 - YUI CSS files no longer found on Yahoo servers
Owen Leonard [Wed, 26 Sep 2012 12:59:45 +0000 (08:59 -0400)]
Bug 8827 - YUI CSS files no longer found on Yahoo servers

This patch removes the [% yuipath %] variable from the link
to the YUI CSS files in the OPAC and adds a hard-coded path
to the local files.

To test, set your yuipath system preference to "from Yahoo's
servers," clear your browser cache, and view the OPAC. The
style and layout should look the same as if your yuipath
preference were set to "local."

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fixes broken display.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8623 follow-up: make sure CCSR theme loads YUI
Jared Camins-Esakov [Thu, 27 Sep 2012 13:12:23 +0000 (09:12 -0400)]
Bug 8623 follow-up: make sure CCSR theme loads YUI

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_8623'
Paul Poulain [Fri, 5 Oct 2012 09:49:08 +0000 (11:49 +0200)]
Merge remote-tracking branch 'origin/new/bug_8623'

12 years agoMerge remote-tracking branch 'origin/new/bug_8623' into new/bug_8623
Paul Poulain [Fri, 5 Oct 2012 09:48:37 +0000 (11:48 +0200)]
Merge remote-tracking branch 'origin/new/bug_8623' into new/bug_8623

12 years agoBug 8623 - Fix YUI path for OPAC in debian/rules
Tomas Cohen Arazi [Mon, 17 Sep 2012 18:45:57 +0000 (15:45 -0300)]
Bug 8623 - Fix YUI path for OPAC in debian/rules

After the changes to YUI path the build process is broken. For testing this I had
to set the build process to ommit the tests as there are some db_dependent test being
called (which failed).

To do this I ran the build script like this:

sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -distribution precise -D precise -r ~/ubuntu -v 3.9.0-046~git -d

Note: Even when this is fixed, there are still issues with some files missing

dh_install: etc/koha/searchengine/solr/config.yaml exists in debian/tmp but is not installed to anywhere
dh_install: etc/koha/searchengine/solr/indexes.yaml exists in debian/tmp but is not installed to anywhere
dh_install: etc/koha/solr/indexes.yaml exists in debian/tmp but is not installed to anywhere
dh_install: missing files, aborting
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Please note that debian/rules *must* use tabs. If you have a git hook
that automatically replaces tabs with spaces, please undo those changes.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8623: Move YUI out of prog
Jared Camins-Esakov [Mon, 13 Aug 2012 01:17:21 +0000 (21:17 -0400)]
Bug 8623: Move YUI out of prog

This patch moves the YUI assets from koha-tmpl/opac-tmpl/prog/en/lib/yui
to koha-tmpl/opac-tmpl/lib/yui.

NOTE: This was tested on Chrome, FF, and Safari on a Mac, and IE and FF
on Windows.

To test:
1) View a smattering of pages on the OPAC and intranet. If the move
   did not work flawlessly, layout will be way off.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8379 don't close dbh
Paul Poulain [Mon, 24 Sep 2012 20:48:30 +0000 (22:48 +0200)]
Bug 8379 don't close dbh

don't close the DBH handler, because under plack this cause a lot of problem
and in CGI mode, closing the dbh handler is useless

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
12 years agoBug 8379 removing another useless ->disconnect line
Paul Poulain [Mon, 24 Sep 2012 20:55:45 +0000 (22:55 +0200)]
Bug 8379 removing another useless ->disconnect line

and s/tab/spaces/

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
12 years agoBug 7963 follow-up: die nicely if AnyEvent libraries not installed
Paul Poulain [Tue, 2 Oct 2012 14:55:32 +0000 (16:55 +0200)]
Bug 7963 follow-up: die nicely if AnyEvent libraries not installed

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7963 Parallel HTTP requests when checking URLs
Frédéric Demians [Sat, 14 Apr 2012 13:04:41 +0000 (15:04 +0200)]
Bug 7963 Parallel HTTP requests when checking URLs

Current script check-url.pl checks URL found in 856$u by sending HTTP
requests, one by one. The next request can't be sent before the previous
one get a result, which can be very slow for dead URL. I propose a new
script which send multiple requests simultaneously which improve
drastically URL checking execution time.

This script is based on AnyEvent and AnyEvent::HTTP CPAN modules.
Add new dependencies AnyEvent & AnyEvent::HTTP.

See doc: perldoc check-url-quick.pl

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
12 years agoBug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup...
Owen Leonard [Tue, 2 Oct 2012 13:50:18 +0000 (09:50 -0400)]
Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen

Return library name to message about hold requiring transfer.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup...
Owen Leonard [Thu, 23 Aug 2012 15:49:38 +0000 (11:49 -0400)]
Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen

This patch re-implements and adapts the changes dcook@prosentient.com.au
submitted in a patch which no longer applies. I have changed the
"alert" style messages to "message" style to match the style
which is applied to "hold found" messages elsewhere.

I have also revised the language in a way that I think is more
clear and accurate.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7986'
Paul Poulain [Thu, 4 Oct 2012 16:12:14 +0000 (18:12 +0200)]
Merge remote-tracking branch 'origin/new/bug_7986'

12 years agoBug 7986: Followup: Hide the export link unless sysprefs are set
Jonathan Druart [Fri, 14 Sep 2012 09:39:35 +0000 (11:39 +0200)]
Bug 7986: Followup: Hide the export link unless sysprefs are set

If at least one of both sysprefs (ExportRemoveFields and
ExportWithCsvProfile) is filled, the export link is displayed

Signed-off-by: Marc Veron <veron@veron.ch>
Tested with both sysprefs filled/not filled, patch behaves as expected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6716: Update biblioitems tables
Nicole C. Engard [Thu, 27 Sep 2012 04:55:32 +0000 (00:55 -0400)]
Bug 6716: Update biblioitems tables

This patch documents the cn_sort and agerestriction fields
in the biblioitems and deletedbiblioitems tables.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6716 - Fix alt contact field documentation
Nicole C. Engard [Thu, 6 Sep 2012 04:22:00 +0000 (00:22 -0400)]
Bug 6716 - Fix alt contact field documentation

The borrowers table has the wrong documentation for the alternate
address3 and city fields. This fixes that.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8739 follow-up fixing perlcritic error
Paul Poulain [Wed, 3 Oct 2012 16:02:38 +0000 (18:02 +0200)]
Bug 8739 follow-up fixing perlcritic error

This patch is not related nor introduced by bug 8739, but while qa-ing it, I found those 2 perlcritic violation

this patch fixes it !

I also fixed a tiny indentation problem

12 years agoBug 8739 - Partial Fine Payments Saving Amount Paid Incorrectly
Kyle M Hall [Fri, 7 Sep 2012 15:44:22 +0000 (11:44 -0400)]
Bug 8739 - Partial Fine Payments Saving Amount Paid Incorrectly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Confirmed using test plan that the display is corrected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7589'
Paul Poulain [Wed, 3 Oct 2012 15:36:55 +0000 (17:36 +0200)]
Merge remote-tracking branch 'origin/new/bug_7589'

12 years agoBug 7589 - tinymce editor broken in .deb packages - in 'en' templates
Mason James [Tue, 8 May 2012 04:59:20 +0000 (16:59 +1200)]
Bug 7589 - tinymce editor broken in .deb packages - in 'en' templates

this patch fixes a glitchy symlink to tiny_mce

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Note that you have to *remove* koha-common then install fresh in order
to recreate the symlink.

VERY IMPORTANT!!! debian/rules MUST USE TABS. USE -n WHEN COMMITING
THIS PATCH, AND DO NOT REPLACE TABS WITH SPACES.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8454 - Holds to Pull : Show pull list on load. Otherwise, it looks like the pull...
David Cook [Tue, 17 Jul 2012 01:33:35 +0000 (11:33 +1000)]
Bug 8454 - Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty.

Currently, when you click "Holds to pull" from the Circulation menu, the only thing that you see is a white screen and a side navigation bar that says "Refine Results".

Since there appear to be no results to refine, the holds to pull list appears completely empty. Staff have to know to click "Submit" on the "Refine Results" form to get anything.

I propose that we have the "run_report" flag set to ON for the initial load. The report uses the default 2 days mentioned in the "Refine Results" form, so there is continuity across the board.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8454 - Holds to Pull : Show pull list on load. Otherwise, it looks like the pull...
David Cook [Tue, 17 Jul 2012 01:33:35 +0000 (11:33 +1000)]
Bug 8454 - Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty.

Currently, when you click "Holds to pull" from the Circulation menu, the only thing that you see is a white screen and a side navigation bar that says "Refine Results".

Since there appear to be no results to refine, the holds to pull list appears completely empty. Staff have to know to click "Submit" on the "Refine Results" form to get anything.

I propose that we have the "run_report" flag set to ON for the initial load. The report uses the default 2 days mentioned in the "Refine Results" form, so there is continuity across the board.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8759 - Add labels for library and sorting on opac advanced search
Kyle M Hall [Tue, 11 Sep 2012 14:23:38 +0000 (10:23 -0400)]
Bug 8759 - Add labels for library and sorting on opac advanced search

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8744: Thesaurus in authorities should not lock fields
Jared Camins-Esakov [Sun, 9 Sep 2012 12:55:12 +0000 (08:55 -0400)]
Bug 8744: Thesaurus in authorities should not lock fields

Although fields in the authority editor should support thesaurus
control, they should never be locked, as authority records commonly
refer to other records that may not be in use locally (and therefore
might not be in the authority file).

Test plan:
1) Make sure a 5xx field in one of your authority frameworks is
   thesaurus-controlled.
2) Note that you cannot edit the field directly.
3) Apply patch.
4) Note that you can now edit the field irectly.

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8585 follow-up Passing syspref to template
Paul Poulain [Wed, 3 Oct 2012 13:28:43 +0000 (15:28 +0200)]
Bug 8585 follow-up Passing syspref to template

Passing the syspref HoldsToPullStartDate to get the number of days displayed on the screen
(instead of "two" that was hardcoded)

Also s/tab/4 spaces/g

12 years agoBug 8585 follow-up DBRev number
Paul Poulain [Wed, 3 Oct 2012 13:19:35 +0000 (15:19 +0200)]
Bug 8585 follow-up DBRev number

12 years agoBug 8585 : Add System Preference to specify Holds to Pull List Start Date
David Cook [Fri, 10 Aug 2012 02:31:30 +0000 (12:31 +1000)]
Bug 8585 : Add System Preference to specify Holds to Pull List Start Date

Currently, Koha creates a default value of 2 days ago (-2) for the start date of the Holds to pull List. This system preference allows users to specify their own default start date for this list, since users might not want to have to manually change the date all the time when they already know the set date period they want to view.

The system preference value is specified as a positive integer, which is then passed as a negative integer in the handler script. This saves users from having to include a qualifer to the sys pref value.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
12 years agoBug 8737 - Incorrect icon at login in staff client
Mark Tompsett [Fri, 7 Sep 2012 05:34:04 +0000 (13:34 +0800)]
Bug 8737 - Incorrect icon at login in staff client

Added the following missing code to ensure the correct icon
is used when logged out:
   IntranetFavicon => C4::Context->preference('IntranetFavicon')
This was added into an existing $template->param() call.

Not to be confused with the koha logo on the login page, the
icon is a 16x16 pixel graphic in the browser tab. The default
is found at .../intranet-tmpl/prog/en/includes/favicon.ico.

If the "IntranetFavicon" system preference is set, it should be
used by the staff client regardless of login state. It was not
being used in the "AUTH rejected" section of Auth.pm, but the
OpacFavicon variable was being set. This explains why the
"OpacFavicon" system preference works for the OPAC client, but
not the staff client upon logout.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8728 : Adjust Reserves.t test for resdate and expdate and test setup/teardown
wajasu [Wed, 5 Sep 2012 16:35:42 +0000 (11:35 -0500)]
Bug 8728 : Adjust Reserves.t test for resdate and expdate and test setup/teardown

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Works better now, creats biblio records, and cleans up after itself as
well.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8711 - alternating colors messed up on reports
Owen Leonard [Thu, 6 Sep 2012 19:21:03 +0000 (15:21 -0400)]
Bug 8711 - alternating colors messed up on reports

Patch adds the "zebra-striping" option to the
table sorter initialization and changes the row
color CSS to match the tablesorter's to prevent
conflicts.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoAdd a warning if a Z39.50 search is started from biblio edition page.
Frédérick Capovilla [Fri, 30 Sep 2011 19:11:01 +0000 (15:11 -0400)]
Add a warning if a Z39.50 search is started from biblio edition page.

Warn the user that the current biblio record might be overwritten by
this action.

http://bugs.koha-community.org/show_bug.cgi?id=8583
Signed-off-by: Marc Veron <veron@veron.ch>
Woks as expected. I prefer this solution with an explicit warning,
since several times I acidentally changed a record  :-)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8674 follow-up Fix perlcritic error
Paul Poulain [Tue, 2 Oct 2012 15:48:03 +0000 (17:48 +0200)]
Bug 8674 follow-up Fix perlcritic error

12 years agoBug 8674: Followup: Add POD for misc/batchdeletebiblios.pl
Jonathan Druart [Thu, 30 Aug 2012 08:33:38 +0000 (10:33 +0200)]
Bug 8674: Followup: Add POD for misc/batchdeletebiblios.pl

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8674: Adds script batchdeletebiblios
Jonathan Druart [Thu, 23 Aug 2012 12:28:42 +0000 (14:28 +0200)]
Bug 8674: Adds script batchdeletebiblios

This script batch deletes biblios which contain a biblionumber
present in file passed in parameter.
If one biblio has items, it is not deleted.

http://bugs.koha-community.org/show_bug.cgi?id=8674

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created file with biblionumbers for bibs with and without items.
Only the bibs without items were deleted.

12 years agoBug 7992: New plugin stocknumberAV
Jonathan Druart [Thu, 30 Aug 2012 13:31:14 +0000 (15:31 +0200)]
Bug 7992: New plugin stocknumberAV

Bugzilla description (from delaye):
1 / Create a list of authorised values(INVENTORY_NUMBER). In which the
code is the prefix and the description the last number assigned.

2/A space between the prefix and number.

3 / From a holding record, after indicate the prefix when you click on
the plugin -> koha search the last number from authorised values
assigned in the list and increment n +1 level meter

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Works as advertised (see provisos below). Tested the following:
1) INVENTORY category has only authorised value 'PR' => PR prefix filled
   in, everything else gives an error.
2) INVENTORY category has two authorised values, both work.
3) INVENTORY category has no authorised values, nothing is incremented
4) Barcode contains numbers, nothing is changed.
Two potential gotchas (neither of them significant enough to warrant
changing, in my opinion):
1) Prefixes must consist only of uppercase alphabetical characters.
2) Negative numbers are padded with zeros to the left of the negative
   sign.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8350: warning in logs when searching for nonexistent ISBN
Mark Tompsett [Thu, 30 Aug 2012 07:06:07 +0000 (15:06 +0800)]
Bug 8350: warning in logs when searching for nonexistent ISBN

Searching for a 10 or 13 digit numeric string that does not exist in
one's catalog will fail to affect SQL statement correctly
in C4::Breeding. Moved string substitution, which was triggering error
when search was undefined, and fixed if statements accordingly.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8818: make sure we load modules before using them
Jared Camins-Esakov [Tue, 25 Sep 2012 23:38:32 +0000 (19:38 -0400)]
Bug 8818: make sure we load modules before using them

An eval { eval "require $module;" }; was replaced with
eval { eval { require $module; }; }; which is a no-op, meaning that
the linker was not getting loaded, and the catalog module was throwing
up a big nasty error every time someone tried to save a record with a
heading. This patch replaces the require with can_load from
Module::Load::Conditional, which is PBP-friendly, and offers equivalent
functionality.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5335 follow-up: fixing Perl error
Paul Poulain [Mon, 1 Oct 2012 16:47:28 +0000 (18:47 +0200)]
Bug 5335 follow-up: fixing Perl error

commenting wrong code, until Jonathan is back

see http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335#c52
and comment 53

12 years agoBug_7913-Follow-up, hide button for subs with items
Lyon3 Team [Mon, 1 Oct 2012 08:45:12 +0000 (04:45 -0400)]
Bug_7913-Follow-up, hide button for subs with items

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoReceiving serials in a loop
Lyon3 Team [Tue, 22 May 2012 13:43:02 +0000 (15:43 +0200)]
Receiving serials in a loop

generate the number of issues entered from a message box and apply
'arrived' status.

http://bugs.koha-community.org/show_bug.cgi?id=7913
Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
12 years agoBug 7642 follow-up fix POD
Paul Poulain [Mon, 1 Oct 2012 15:42:23 +0000 (17:42 +0200)]
Bug 7642 follow-up fix POD

The patch for bug 7642 did not introduce this error, but the QA tools detected it, so I fixed it

12 years agoBug 7642 - fix the lost display of tag sizes
Robin Sheat [Fri, 28 Sep 2012 23:34:32 +0000 (11:34 +1200)]
Bug 7642 - fix the lost display of tag sizes

This fixes the display of different sized words for differently popular
tags. It is a bit of a refactor of that part of the system, moving
logic to more sensible places (and removing an unused method on the
way.)

Note that it isn't an attempt to reproduce what was there previously,
just to do something similar, and in an easier to change fashion.

Sponsored-By: New Zealand Educational Institute
Signed-off-by: Marc Veron <veron@veron.ch>
Works as expected.

12 years agoBug 3387 follow-up: fix perlcritic error
Paul Poulain [Mon, 1 Oct 2012 15:35:45 +0000 (17:35 +0200)]
Bug 3387 follow-up: fix perlcritic error

12 years agoBug 3387 follow-up DBRev number
Paul Poulain [Mon, 1 Oct 2012 15:10:29 +0000 (17:10 +0200)]
Bug 3387 follow-up DBRev number

12 years agoBug 3387 - WITHDRAWN items shouldn't check in
Kyle M Hall [Tue, 17 Jul 2012 13:42:59 +0000 (09:42 -0400)]
Bug 3387 - WITHDRAWN items shouldn't check in

Adds a system preference BlockReturnOfWithdrawnItems to control
whether or not Koha should allow a withdrawn item to be returned
or not.

Also fixes the behavior where Koha will attempt to use a withdrawn
item to fill a hold.

Test Plan:
1) Set BlockReturnOfWithdrawnItems to "Block" ( this is the default )
2) Check an item out to a patron
3) Mark item as withdrawn
4) Attempt to return the item, you should still see the item on the
   borrower's record
5) Set BlockReturnOfWithdrawnItems to "Don't Block"
6) Attempt to return the item, you should see the item is no longer
   on the borrower's record.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoHolidays Test Plan - DB Dependent
Kyle M Hall [Mon, 18 Jun 2012 11:28:15 +0000 (07:28 -0400)]
Holidays Test Plan - DB Dependent

This test file is meant to be used with the sample database
with a minimum of the sample libraries and sample holidays installed.

http://bugs.koha-community.org/show_bug.cgi?id=8110
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug 8110 - add branchcode MPL to sample holidays to facilitate automated testing.
Liz Rea [Tue, 19 Jun 2012 15:36:23 +0000 (10:36 -0500)]
bug 8110 - add branchcode MPL to sample holidays to facilitate automated testing.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_8209'
Paul Poulain [Mon, 1 Oct 2012 14:39:52 +0000 (16:39 +0200)]
Merge remote-tracking branch 'origin/new/bug_8209'

12 years agoBug 8209 follow-up: another correction for BuildSummary API
Jared Camins-Esakov [Thu, 13 Sep 2012 15:33:44 +0000 (11:33 -0400)]
Bug 8209 follow-up: another correction for BuildSummary API

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8581: don't display parentheses when we don't have a type
Jared Camins-Esakov [Mon, 6 Aug 2012 18:04:32 +0000 (14:04 -0400)]
Bug 8581: don't display parentheses when we don't have a type

Prior to this patch, see also references in certain authority records
(most notably GND records) were being followed by empty parentheses in
the search results display. This patch resolves that problem.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8726: add CSS to CCSR theme
Jared Camins-Esakov [Mon, 24 Sep 2012 17:34:45 +0000 (13:34 -0400)]
Bug 8726: add CSS to CCSR theme

12 years agoBug 8726: Followup FIX save didyoumean syspref
Jonathan Druart [Thu, 20 Sep 2012 12:22:19 +0000 (14:22 +0200)]
Bug 8726: Followup FIX save didyoumean syspref

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8726 follow-up: fix QA issues
Jared Camins-Esakov [Thu, 20 Sep 2012 11:39:16 +0000 (07:39 -0400)]
Bug 8726 follow-up: fix QA issues

Fixes several perlcritic complaints, and some overflow in the
configuration page. Also notes that Did You Mean is not yet
enabled on the staff client.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Sorry about the problematic last attempt at uploading. I missed a
patch when squashing. It is now included.

12 years agoBug 8726: ExplodedTerms suggestion plugin (jQueryUI)
Jared Camins-Esakov [Fri, 14 Sep 2012 13:12:14 +0000 (09:12 -0400)]
Bug 8726: ExplodedTerms suggestion plugin (jQueryUI)

When working with hierarchical subject headings, it is sometimes helpful
to do a search for all records with a specific subject, plus
broader/narrower/related subjects. This patch adds a suggestion plugin for
these "exploded" subject searches to Koha. Note that this patch depends on
both bug 8211 AND bug 8209.

To test (NOTE: this test plan covers both 8211 and 8726):
1) Make sure you have a bunch of hierarchical subjects. I created
   geographical subjects for "Arizona," "United States," and "Phoenix,"
   and linked them together using 551s, and made sure I had a half
   dozen records linking to each (but not all to all three).
2) Do a search for su-br:Arizona (or choose "Subject and broader terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona" and the
   records with the subject "United States"
3) Do a search for su-na:Arizona (or choose "Subject and narrower terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona" and the
   records with the subject "Phoenix"
4) Do a search for su-rl:Arizona (or choose "Subject and related terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona," the
   records with the subject "United States," and the records with the
   subject "Phoenix"
5) Ensure that other searches still work (keyword, subject, ccl,
   whatever)
6) Use "Did you mean?" page in admin section to enable ExplodedTerms
   plugin
7) Do a keyword search on the OPAC, confirm that searching for exploded
   terms is suggested.
8) Do a subject search on the OPAC, confirm that searching for exploded
   terms is suggested.
9) Do a non-keyword, non-subject search on the OPAC, confirm that
   searching for exploded terms is NOT suggested.
10) Disable ExplodedTerms plugin and enable AuthorityFile plugin.
11) Do search on OPAC, confirm suggestions are made from authority file.
12) Sign off

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Split into two patches. This patch includes only the jQueryUI upgrade

12 years agoBug 8726: ExplodedTerms suggestion plugin (functionality)
Jared Camins-Esakov [Fri, 14 Sep 2012 13:08:10 +0000 (09:08 -0400)]
Bug 8726: ExplodedTerms suggestion plugin (functionality)

When working with hierarchical subject headings, it is sometimes helpful
to do a search for all records with a specific subject, plus
broader/narrower/related subjects. This patch adds a suggestion plugin for
these "exploded" subject searches to Koha. Note that this patch depends on
both bug 8211 AND bug 8209.

To test (NOTE: this test plan covers both 8211 and 8726):
1) Make sure you have a bunch of hierarchical subjects. I created
   geographical subjects for "Arizona," "United States," and "Phoenix,"
   and linked them together using 551s, and made sure I had a half
   dozen records linking to each (but not all to all three).
2) Do a search for su-br:Arizona (or choose "Subject and broader terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona" and the
   records with the subject "United States"
3) Do a search for su-na:Arizona (or choose "Subject and narrower terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona" and the
   records with the subject "Phoenix"
4) Do a search for su-rl:Arizona (or choose "Subject and related terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona," the
   records with the subject "United States," and the records with the
   subject "Phoenix"
5) Ensure that other searches still work (keyword, subject, ccl,
   whatever)
6) Use "Did you mean?" page in admin section to enable ExplodedTerms
   plugin
7) Do a keyword search on the OPAC, confirm that searching for exploded
   terms is suggested.
8) Do a subject search on the OPAC, confirm that searching for exploded
   terms is suggested.
9) Do a non-keyword, non-subject search on the OPAC, confirm that
   searching for exploded terms is NOT suggested.
10) Disable ExplodedTerms plugin and enable AuthorityFile plugin.
11) Do search on OPAC, confirm suggestions are made from authority file.
12) Sign off

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Split into two patches. This patch includes only the functionality.

12 years agoBug 7351 : feature that allows to delete a range of dates
christophe croullebois [Sun, 15 Jul 2012 13:10:47 +0000 (15:10 +0200)]
Bug 7351 : feature that allows to delete a range of dates

Four new options, one for single holidays, one for the repeatable holidays.
One to create exceptions on a range of dates, one to delete exceptions in a range of dates.
Note that the exceptions are not deleted if you delete a range of repeatable dates.
But if you delete a range of single holidays the exeptions inside will be deleted.

Signed-off-by: Stephane Delaye <stephane.delaye@biblibre.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5335 follow-up fixing template
Paul Poulain [Fri, 28 Sep 2012 09:26:23 +0000 (11:26 +0200)]
Bug 5335 follow-up fixing template

There were 2 invalid T::T construction, with a [% IF %] inside a HTML tag

12 years agoBug 5335 follow-up fix test
Paul Poulain [Fri, 28 Sep 2012 09:19:56 +0000 (11:19 +0200)]
Bug 5335 follow-up fix test

The gst column is now called gstrate.

12 years agoBug 8659 Remove and readd the inactive funds in javascript to make it work in all...
Maxime Pelletier [Tue, 21 Aug 2012 22:02:31 +0000 (18:02 -0400)]
Bug 8659 Remove and readd the inactive funds in javascript to make it work in all browsers

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8702: System preferences search does not allow accented letters
Fridolyn SOMERS [Tue, 18 Sep 2012 13:59:37 +0000 (15:59 +0200)]
Bug 8702: System preferences search does not allow accented letters

This bug enables accented/diacritic system preference text to be matched
when searching for sysprefs.

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8780 - Lower dependency version for DateTime::TimeZone
Mark Tompsett [Tue, 18 Sep 2012 05:15:18 +0000 (13:15 +0800)]
Bug 8780 - Lower dependency version for DateTime::TimeZone

The fresh install of Debian, with the debian.koha-community.org
repository, only has version 1.20 by default. As only the most
basic functionality is being used, this version number should be
lowered from 1.26 to 1.20 in ./C4/Installer/PerlDependencies.pm
to make git installations cleaner.

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5356 follow-up DBRev number
Paul Poulain [Mon, 24 Sep 2012 19:32:48 +0000 (21:32 +0200)]
Bug 5356 follow-up DBRev number

12 years agoBug 5356: Followup: remove useless code
Jonathan Druart [Fri, 21 Sep 2012 08:30:34 +0000 (10:30 +0200)]
Bug 5356: Followup: remove useless code

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5356: Followup: Add basket billing and delivery place on export pdf (layout3pages)
Jonathan Druart [Tue, 4 Sep 2012 08:03:27 +0000 (10:03 +0200)]
Bug 5356: Followup: Add basket billing and delivery place on export pdf (layout3pages)

12 years agoBug 5356: delivery place and billing place centralised in basket management
Jonathan Druart [Wed, 25 Jul 2012 08:25:16 +0000 (10:25 +0200)]
Bug 5356: delivery place and billing place centralised in basket management

- adding 2 select option in basdketheader.tmpl (delivery and billing
   place)
- adding 2 more fields in basket csv export

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested together with patches for bug 7302.

12 years agoMerge remote-tracking branch 'origin/new/bug_8523'
Paul Poulain [Fri, 21 Sep 2012 14:37:25 +0000 (16:37 +0200)]
Merge remote-tracking branch 'origin/new/bug_8523'

Conflicts:
kohaversion.pl

12 years agoBug 8523 follow-up OPAC styles for ccsr theme
Paul Poulain [Fri, 21 Sep 2012 14:35:20 +0000 (16:35 +0200)]
Bug 8523 follow-up OPAC styles for ccsr theme

12 years agoBug 8523 follow-up fixing perlcritic
Paul Poulain [Fri, 21 Sep 2012 14:30:36 +0000 (16:30 +0200)]
Bug 8523 follow-up fixing perlcritic

12 years agoBug 8523 follow-up DBRev number
Paul Poulain [Fri, 21 Sep 2012 13:16:30 +0000 (15:16 +0200)]
Bug 8523 follow-up DBRev number

12 years agoBug 8523: Display auth hierarchies w/all marcflavours
Jared Camins-Esakov [Wed, 1 Aug 2012 19:12:30 +0000 (15:12 -0400)]
Bug 8523: Display auth hierarchies w/all marcflavours

This commit adds support for displaying authority hierarchies for all
flavours of MARC, not just UNIMARC. Display now uses the jQuery
jstree plugin, selected with the help of Owen Leonard, resulting in a
much faster experience for users.

Be aware that the jstree file uses tabs rather than 4-space indentation,
which I left as-is so as to make it easier to integrate upstream
releases in the future.

To test:
1) Enable the AuthDisplayHierarchy syspref
2) Create authority records with a hierarchy of see also fields
   (in MARC21/NORMARC, you'll be using 5xx fields for this, with a
   subfield $w=g for broader terms and subfield $w=h for narrower
   terms)
3) View the authorities in the OPAC, noting the hierarchical view at
   the top of the page.

This initial patch does not create bidirection linkages from
unidirectional links in MARC21 authorities. This means that when moving
up the authority hierarchy, lower levels will disappear. This is
intentional, as the first patch is intended merely to ensure that
AuthDisplayHierarchy functions the same for all marcflavours. A future
patch will add a cron job to generate the bidirectional linkages, once
we are sure that the hierarchy functionality for UNIMARC and
MARC21/NORMARC coexists peaceably.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Resolved conflicts in updatedatabase.pl, sysprefs.sql and in one of
the CSS files.

Test plan:

1) Run t/AuthoritiesMarc.t
New tests complete without any errors.

2) Make sure updatedatabase works correctly.
Update works nicely, new system preference is also added to syspref.sql

3) Make sure new terms are translatable.
Created new po files for de-DE and checked for new terms.
All translations appear correctly.

4) Make sure everything works with AuthDisplayHieararchy OFF
- Add authority
- Edit authority
- Delete authority

5) Test feature with AuthDisplayHieararchy ON
- Add authority
- Edit authority
- Delete authority

6) Add a couple of hierarchically linked authorities
Note: links have to be created in both directions

Example:
151 $aGermany
  551 $a Baden-Württemberg $w h

151 $aBaden-Württemberg
  551 $a Konstanz $w h
  551 $a Germany $w g

151 $aKonstanz
  551 $a Baden-Württemberg $w g
  551 $a Fürstenberg $w h
  551 $a Paradies $w h

151 $a Fürstenberg
  551 $a Konstanz $w g

151 $a Paradies
  551 $a Konstanz $w g

Tree shows up nicely above the authority record
- in staff
- in OPAC
  - on the normal view tab
  - on the MARC view tab

7) Checking the logs for warnings
- no Javascript errors or warnings
- no warnings or errors in log files

12 years agoBug 5335 follow-up DBRev number
Paul Poulain [Fri, 21 Sep 2012 08:36:56 +0000 (10:36 +0200)]
Bug 5335 follow-up DBRev number

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5335 follow-up DBRev number
Paul Poulain [Fri, 21 Sep 2012 08:36:56 +0000 (10:36 +0200)]
Bug 5335 follow-up DBRev number

12 years agoBug 5335 - More granular VAT
Jonathan Druart [Fri, 24 Feb 2012 15:24:05 +0000 (16:24 +0100)]
Bug 5335 - More granular VAT

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_8606'
Paul Poulain [Thu, 20 Sep 2012 12:58:39 +0000 (14:58 +0200)]
Merge remote-tracking branch 'origin/new/bug_8606'

12 years agoRevert "Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModul...
Paul Poulain [Thu, 20 Sep 2012 12:49:18 +0000 (14:49 +0200)]
Revert "Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm"

This reverts commit afff4e8d6a427d231746b024a0d6f98438e7f2c6.

12 years agoBug 8606 - Talking Tech broken by user-configurable slips feature - QA Followup
Kyle M Hall [Wed, 19 Sep 2012 15:54:52 +0000 (11:54 -0400)]
Bug 8606 - Talking Tech broken by user-configurable slips feature - QA Followup

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(not tested it actually fixes talking tech, trusting signoff & sounds
logical)

12 years agoBug 8606 - Talking Tech broken by Bug 7001
Koha user [Tue, 7 Aug 2012 12:09:19 +0000 (08:09 -0400)]
Bug 8606 - Talking Tech broken by Bug 7001

The patches for bug 7001 removed the parseletter subroutine from
C4::Letters without updating the talking tech script to use the
new alternative. This patch rectifies that situation.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
12 years agoBug 8692: Authorities search form does not correspond to current search query
Fridolyn SOMERS [Mon, 27 Aug 2012 12:50:32 +0000 (14:50 +0200)]
Bug 8692: Authorities search form does not correspond to current search query

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
The correct tab is now visible on load. The problem with authtypecode
showing up in the search box is specific to UNIMARC, so I could not
check that it was gone, but I am comfortable signing off on this.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoRevert "Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm"
Paul Poulain [Thu, 20 Sep 2012 11:29:59 +0000 (13:29 +0200)]
Revert "Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm"

This reverts commit 48d5f30226c75b260ddfa6b85ee8f87878902e0e.

12 years agoBug 6679 - fix 3 perlcritic violations in C4/Auth.pm, and enabled warnings
Mason James [Tue, 26 Jun 2012 16:54:11 +0000 (04:54 +1200)]
Bug 6679 - fix 3 perlcritic violations in C4/Auth.pm, and enabled warnings

Subroutine prototypes used at line 561, column 1.  See page 194 of PBP.  (Severity: 5)

Bareword file handle opened at line 606, column 5.  See pages 202,204 of PBP.  (Severity: 5)

Two-argument "open" used at line 606, column 5.  See page 207 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch reintroduces 'use warnings' in C4/Auth.pm.
Keep attentive to new warning messages in your log

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm
Mason James [Tue, 26 Jun 2012 17:02:00 +0000 (05:02 +1200)]
Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm

Bareword file handle opened at line 80, column 9.  See pages 202,204 of PBP.  (Severity: 5)

Two-argument "open" used at line 80, column 9.  See page 207 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
http://perldoc.perl.org/functions/open.html
For three or more arguments if MODE is |- , the filename is interpreted
as a command to which output is to be piped, and if MODE is -| , the
filename is interpreted as a command that pipes output to us. I

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Creators/PDF.pm
Mason James [Tue, 26 Jun 2012 14:28:26 +0000 (02:28 +1200)]
Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Creators/PDF.pm

- "return" statement with explicit "undef" at line 171, column 8.  See page 199 of PBP.  (Severity: 5)

- "return" statement with explicit "undef" at line 201, column 8.  See page 199 of PBP.  (Severity: 5)

- Bareword file handle opened at line 212, column 11.  See pages 202,204 of PBP.  (Severity: 5)

- Two-argument "open" used at line 212, column 11.  See page 207 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Installer.pm
Mason James [Tue, 26 Jun 2012 14:20:58 +0000 (02:20 +1200)]
Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Installer.pm

- Bareword file handle opened at line 157, column 13.  See pages 202,204 of
PBP.  (Severity: 5)

- I/O layer ":utf8" used at line 157, column 13.  Use ":encoding(UTF-8)" to get strict validation.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
http://perldoc.perl.org/functions/open.html
    open(my $fh, "<:encoding(UTF-8)", "filename")
        || die "can't open UTF-8 encoded filename: $!";

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/BackgroundJob.pm
Mason James [Tue, 26 Jun 2012 17:09:10 +0000 (05:09 +1200)]
Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/BackgroundJob.pm

"return" statement with explicit "undef" at line 234, column 5.  See page 199 of PBP.  (Severity: 5)

"return" statement with explicit "undef" at line 256, column 9.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm
Mason James [Tue, 26 Jun 2012 17:07:46 +0000 (05:07 +1200)]
Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm

Expression form of "eval" at line 71, column 9.  See page 161 of PBP.  (Severity: 5)

Expression form of "eval" at line 85, column 13.  See page 161 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>