From 52298f420eee811f0e611e011e65cf668805cadb Mon Sep 17 00:00:00 2001 From: Victor Grousset/tuxayo Date: Tue, 5 Jan 2021 13:56:32 +0100 Subject: [PATCH] Bug 26847: (follow-up) fix get_attribute() call Since the upgrade to Selenium 3 in bug 27055, an additional parameter is required for get_attribute() to actually work. https://metacpan.org/pod/Selenium::Remote::WebElement#get_attribute Signed-off-by: Jonathan Druart (cherry picked from commit de739259298b323bb881b62b1bc96bc9e3589496) Signed-off-by: Fridolin Somers (cherry picked from commit 04a0e973331c9210ab8324efb9fb7575148081d7) Signed-off-by: Victor Grousset/tuxayo --- t/db_dependent/selenium/regressions.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t index a6a0a6d9a2..3867a0041e 100644 --- a/t/db_dependent/selenium/regressions.t +++ b/t/db_dependent/selenium/regressions.t @@ -67,7 +67,7 @@ subtest 'OPAC - borrowernumber, branchcode and categorycode as html attributes' is( $elt->get_attribute('data-borrowernumber', 1), $patron->borrowernumber, "Since bug 20921 span.loggedinusername should contain data-borrowernumber" ); - is( $elt->get_attribute('data-categorycode'), $patron->categorycode, + is( $elt->get_attribute('data-categorycode', 1), $patron->categorycode, "Since bug 26847 span.loggedinusername should contain data-categorycode" ); push @cleanup, $patron, $patron->category, $patron->library; -- 2.39.5