From e2e7dc62202957428fc0170573af8e347cbf5e58 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 16 Nov 2018 09:54:39 -0500 Subject: [PATCH] Bug 21849: Add unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens (cherry picked from commit 2dbaaa300877ff6d96ae84b5a703753d97b6c340) Signed-off-by: Martin Renvoize (cherry picked from commit aa565b8e9919ee414d0693f391b141985ebacb93) Signed-off-by: Lucas Gass (cherry picked from commit 0a6c0c32604ebbd89ccff8d2dc0ff4a11bd204dd) Signed-off-by: Fridolin Somers --- t/db_dependent/Circulation.t | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 263cacfde8..c1a3ddf20f 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -1865,7 +1865,7 @@ subtest '_FixAccountForLostAndReturned' => sub { }; subtest '_FixOverduesOnReturn' => sub { - plan tests => 6; + plan tests => 10; # Generate test biblio my $title = 'Koha for Dummies'; @@ -1918,9 +1918,12 @@ subtest '_FixOverduesOnReturn' => sub { C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $itemnumber, 1 ); $accountline->_result()->discard_changes(); + my $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'Forgiven' })->next(); is( $accountline->amountoutstanding, '0.000000', 'Fine has been reduced to 0' ); is( $accountline->accounttype, 'FFOR', 'Open fine ( account type FU ) has been set to fine forgiven ( account type FFOR )'); + is( ref $offset, "Koha::Account::Offset", "Found matching offset for fine reduction via forgiveness" ); + is( $offset->amount, '-99.000000', "Amount of offset is correct" ); ## Run again, with dropbox mode enabled $accountline->set( @@ -1933,9 +1936,12 @@ subtest '_FixOverduesOnReturn' => sub { C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $itemnumber, 0, 1 ); $accountline->_result()->discard_changes(); + $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'Dropbox' })->next(); is( $accountline->amountoutstanding, '90.000000', 'Fine has been reduced to 90' ); is( $accountline->accounttype, 'F', 'Open fine ( account type FU ) has been closed out ( account type F )'); + is( ref $offset, "Koha::Account::Offset", "Found matching offset for fine reduction via dropbox" ); + is( $offset->amount, '-9.000000', "Amount of offset is correct" ); }; subtest 'Set waiting flag' => sub { -- 2.39.5