From 0aec9e11d5fa355738cb3475ad72c4aad8efeafa Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 14 Sep 2017 10:57:40 -0300 Subject: [PATCH] Bug 19317: (bug 18966 follow-up) Remove leftover Nothing important here, but this line should have been removed by bug 18966: 2177 # Update the fines 2178 $dbh->do(q|UPDATE accountlines SET issue_id = ? WHERE issue_id = ?|, undef, $old_checkout->issue_id, $issue->issue_id); The issue_id is now the same when moved from issues to old_issues. We do not need to update the accountlines table. No test plan here, you need to understand previous changes to validate this patch. Signed-off-by: Colin Campbell Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart --- C4/Circulation.pm | 3 --- 1 file changed, 3 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index a5b2fceb81..eb0f6d59bc 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2176,9 +2176,6 @@ sub MarkIssueReturned { # Create the old_issues entry my $old_checkout = Koha::Old::Checkout->new($issue->unblessed)->store; - # Update the fines - $dbh->do(q|UPDATE accountlines SET issue_id = ? WHERE issue_id = ?|, undef, $old_checkout->issue_id, $issue->issue_id); - # anonymise patron checkout immediately if $privacy set to 2 and AnonymousPatron is set to a valid borrowernumber if ( $privacy == 2) { $dbh->do(q|UPDATE old_issues SET borrowernumber=? WHERE issue_id = ?|, undef, $anonymouspatron, $old_checkout->issue_id); -- 2.39.5