From 171d6cc32b4793f46a43b6e1941761845faf77da Mon Sep 17 00:00:00 2001 From: Magnus Enger Date: Wed, 29 Nov 2023 14:58:08 +0100 Subject: [PATCH] Bug 35414: Silence warn related to number_of_copies To test in ktd: - Tail the logs with "sudo tail -f /var/log/koha/kohadev/plack*.log" - Find a record in the staff client - Add an item to the record - Observe "[WARN] Argument "" isn't numeric in subroutine entry ..." in /var/log/koha/kohadev/plack-intranet-error.log - Apply this patch - restart_all - Tail the logs again - Add another item - Observe the absence of the earlier warning Thanks to Jonathan Druart for suggesting this particular solution! Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer (cherry picked from commit 8ba9ea8a87e0d6653261d90d743cd75328ad0b99) Signed-off-by: Fridolin Somers (cherry picked from commit aad41dd27a37ab42a6aa9606d56a031b6f67a180) Signed-off-by: Lucas Gass --- cataloguing/additem.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl index bd7b297109..f92e3467fd 100755 --- a/cataloguing/additem.pl +++ b/cataloguing/additem.pl @@ -238,7 +238,7 @@ if ($op eq "additem") { my $add_duplicate_submit = $input->param('add_duplicate_submit'); my $add_multiple_copies_submit = $input->param('add_multiple_copies_submit'); my $save_as_template_submit = $input->param('save_as_template_submit'); - my $number_of_copies = min( scalar $input->param('number_of_copies'), 1000 ); # TODO refine hardcoded maximum? + my $number_of_copies = min( scalar $input->param('number_of_copies') || 0, 1000 ); # TODO refine hardcoded maximum? my @columns = Koha::Items->columns; my $item = Koha::Item->new; -- 2.39.5