From 35cbbd8de9d858e38f87dcfdd4e19f8f4ec6e6a6 Mon Sep 17 00:00:00 2001 From: David Cook Date: Fri, 10 Aug 2018 18:08:13 +1000 Subject: [PATCH] Bug 21005: Missing row/column defaults cause unexpected results in report wizards Some report wizards are missing row/column defaults, which sometimes return blank pages (borrowers_stats.pl) or results always equalling 0, which a non-discerning user may interpret incorrectly. If the DEBUG environmental variable is enabled, missing row/column choices will actually cause fatal software errors as well, which is also undesirable for users. This patch adds default choices for row and column on report wizards that had no radio buttons selected, so that a user can't submit the form without choosing a row and column. This prevents errors. To test: 1) Apply patch 2) Visit /cgi-bin/koha/reports/issues_avg_stats.pl 3) Visit /cgi-bin/koha/reports/borrowers_stats.pl 4) Visit /cgi-bin/koha/reports/catalogue_stats.pl 5) Visit /cgi-bin/koha/reports/issues_stats.pl 6) Observe that default choices for row/column are there Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens (cherry picked from commit 6a451360b8fd0a56dd07be050cdecf538d890612) Signed-off-by: Martin Renvoize (cherry picked from commit 4edef313918d8930de54d532089ed66c981bbb6e) Signed-off-by: Fridolin Somers --- .../prog/en/modules/reports/borrowers_stats.tt | 4 ++-- .../prog/en/modules/reports/catalogue_stats.tt | 8 ++++---- .../prog/en/modules/reports/issues_avg_stats.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/reports/issues_stats.tt | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt index 005886d0cb..e492554345 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt @@ -77,7 +77,7 @@ Patron category - + + - - + + + - + [% INCLUDE 'date-format.inc' %] @@ -151,7 +151,7 @@ Patron category - + - + +