]> git.koha-community.org Git - koha.git/log
koha.git
7 months agoBug 34478: Add op to pay_individual
Martin Renvoize [Fri, 16 Feb 2024 09:32:57 +0000 (09:32 +0000)]
Bug 34478: Add op to pay_individual

I also move the writeoff handling out of it's own block in into the rest
of the x_individual handling.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Move writeoff-individual to paycollect.pl
Martin Renvoize [Thu, 15 Feb 2024 17:10:00 +0000 (17:10 +0000)]
Bug 34478: Move writeoff-individual to paycollect.pl

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Fix op check in table settings admin
Owen Leonard [Fri, 16 Feb 2024 11:46:50 +0000 (11:46 +0000)]
Bug 34478: Fix op check in table settings admin

The "action" hidden field was renamed to "op", but "action" was still
being looked for in the script.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for opac-shareshelf
Marcel de Rooy [Fri, 16 Feb 2024 10:42:16 +0000 (10:42 +0000)]
Bug 34478: Changes for opac-shareshelf

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for suggestion/suggestion
Marcel de Rooy [Thu, 15 Feb 2024 11:07:29 +0000 (11:07 +0000)]
Bug 34478: Changes for suggestion/suggestion

Too much changes needed. Main functionality works again.
Some improvements can still be made.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Make plack.psgi change more comprehensive
David Cook [Fri, 16 Feb 2024 00:11:10 +0000 (00:11 +0000)]
Bug 34478: Make plack.psgi change more comprehensive

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Classification config - Convert delete links to form POSTS
Owen Leonard [Thu, 15 Feb 2024 18:02:02 +0000 (18:02 +0000)]
Bug 34478: Classification config - Convert delete links to form POSTS

This patch converts the delete links on the classification
configuration page for sources, filing rules, and splitting rules to
POST forms.

A couple of op checks in the script are corrected to match.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Cities - Incorrect op check for cud-delete_confirm
Owen Leonard [Thu, 15 Feb 2024 17:35:32 +0000 (17:35 +0000)]
Bug 34478: Cities - Incorrect op check for cud-delete_confirm

On the cities administration page, the delete button is a GET operation
to a second form for confirmation.

This script should be checking for op=delete_confirm, not
cud-delete_confirm.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Convert authorised value delete link to POST form
Owen Leonard [Thu, 15 Feb 2024 17:07:01 +0000 (17:07 +0000)]
Bug 34478: Convert authorised value delete link to POST form

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Authority frameworks - first subfield delete button has incorrect op value
Owen Leonard [Thu, 15 Feb 2024 16:35:39 +0000 (16:35 +0000)]
Bug 34478: Authority frameworks - first subfield delete button has incorrect op value

From the list of a tag's subfields (e.g.
/cgi-bin/koha/admin/auth_subfields_structure.pl?tagfield=245&frameworkcode=)
the delete button is a GET operation to a second form for confirmation.

This script should be checking for op=delete_confirm, not cud-delete-confirm.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Frameworks - first subfield delete button has incorrect op value
Owen Leonard [Thu, 15 Feb 2024 16:19:56 +0000 (16:19 +0000)]
Bug 34478: Frameworks - first subfield delete button has incorrect op value

From the list of a tag's subfields (e.g.
/cgi-bin/koha/admin/marc_subfields_structure.pl?tagfield=245&frameworkcode=)
the delete button is a GET operation to a second form for confirmation.

This script should be checking for op=delete_confirm, not
cud-delete-confirm.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Convert EDIFACT messages deletion to POST
Owen Leonard [Thu, 15 Feb 2024 15:10:56 +0000 (15:10 +0000)]
Bug 34478: Convert EDIFACT messages deletion to POST

Modify DataTables rendering to put the delete button inside a POSTed
form.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Use op and cud in pay -> paycollect redirect
Martin Renvoize [Thu, 15 Feb 2024 15:25:17 +0000 (15:25 +0000)]
Bug 34478: Use op and cud in pay -> paycollect redirect

The pay to paycollect post/redirect flow here doesn't actually
consistute a state change, however it's much simpler to add the csrf
token check flow here than to refactor the code to a get (url's quickly
grow too large for a GET) or rework it in other ways.  I opted to do
this for now and work on a refactor at a future date.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Re-correct account-table pay
Martin Renvoize [Thu, 15 Feb 2024 13:03:39 +0000 (13:03 +0000)]
Bug 34478: Re-correct account-table pay

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Basket group export CSV option should not check cud-op
Owen Leonard [Thu, 15 Feb 2024 12:32:25 +0000 (12:32 +0000)]
Bug 34478: Basket group export CSV option should not check cud-op

The Export CSV operation is GET and uses op=export, so the script should
not check for "cud-op."

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for authorities/searchresultlist (new delete form)
Marcel de Rooy [Thu, 15 Feb 2024 09:13:15 +0000 (09:13 +0000)]
Bug 34478: Changes for authorities/searchresultlist (new delete form)

Replaces a delete with GET.
FIXME: Trouble with closing dropdown.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Regression - fix installer stuck
Jonathan Druart [Thu, 15 Feb 2024 09:43:06 +0000 (10:43 +0100)]
Bug 34478: Regression - fix installer stuck

Installer was stuck after "Set up database" with a blank page

It also fixes 00-onboarding.t

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Regression - fix change auth type
Jonathan Druart [Thu, 15 Feb 2024 09:24:02 +0000 (10:24 +0100)]
Bug 34478: Regression - fix change auth type

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Regression - fix change framework
Jonathan Druart [Thu, 15 Feb 2024 09:18:37 +0000 (10:18 +0100)]
Bug 34478: Regression - fix change framework

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: (follow-up) Change invoice files delete link to POST
Owen Leonard [Wed, 14 Feb 2024 18:51:57 +0000 (18:51 +0000)]
Bug 34478: (follow-up) Change invoice files delete link to POST

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - Fix controller op handling of self-checkout
David Cook [Thu, 15 Feb 2024 03:06:36 +0000 (03:06 +0000)]
Bug 34478: Manual fix - Fix controller op handling of self-checkout

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - Fix session cookie management of self-checkout
David Cook [Thu, 15 Feb 2024 00:35:16 +0000 (00:35 +0000)]
Bug 34478: Manual fix - Fix session cookie management of self-checkout

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - Remove csrf_token from GET to sco-patron-image.pl
David Cook [Wed, 14 Feb 2024 23:45:28 +0000 (23:45 +0000)]
Bug 34478: Manual fix - Remove csrf_token from GET to sco-patron-image.pl

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - Remove cud-search from z3950-admin-search.inc
David Cook [Wed, 14 Feb 2024 23:34:27 +0000 (23:34 +0000)]
Bug 34478: Manual fix - Remove cud-search from z3950-admin-search.inc

Convert POST to GET for z3950 server search

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change links to JS form submission - change action to op...
Nick Clemens [Wed, 14 Feb 2024 16:58:36 +0000 (11:58 -0500)]
Bug 34478: Manual fix - change links to JS form submission - change action to op - request.pl/.tt

Bug 34478: [TO SQUASH] Manual fix - change links to JS form submission - cleanup comments and unused routine - request.pl/.tt

Bug 34478: [TO SQUASH] Manual fix - link to js post and add op to form - request.tt

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change 'phase' to 'op' add cud- - mana-share-report
Nick Clemens [Wed, 14 Feb 2024 12:13:17 +0000 (07:13 -0500)]
Bug 34478: Manual fix - change 'phase' to 'op' add cud- - mana-share-report

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Rename the cud op for the statess account redirection form
Kyle M Hall [Wed, 14 Feb 2024 11:58:20 +0000 (06:58 -0500)]
Bug 34478: Rename the cud op for the statess account redirection form

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Update op for opac-account-pay
Martin Renvoize [Wed, 14 Feb 2024 09:54:48 +0000 (09:54 +0000)]
Bug 34478: Update op for opac-account-pay

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add op cud-stateless for account-table.inc
Kyle M Hall [Tue, 13 Feb 2024 19:57:54 +0000 (14:57 -0500)]
Bug 34478: Add op cud-stateless for account-table.inc

This form calls a payment plugin to prep a new form that submits to a
the payment site external to Koha.

This form does not change state but a change to GET would cause failures
if trying to pay more than 133 fees on Chrome ( but not Firefox ).

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Fix link to batch patron mod from reports
Jonathan Druart [Tue, 13 Feb 2024 08:06:47 +0000 (09:06 +0100)]
Bug 34478: Fix link to batch patron mod from reports

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Move to get for modborrowers
Jonathan Druart [Tue, 13 Feb 2024 08:06:13 +0000 (09:06 +0100)]
Bug 34478: Move to get for modborrowers

Bug 34478: [TO SQUASH] tools/modborrowers

We actually want to POST here to not reach the limit of a GET request.
It also fixes the following warning in the console:
  Form contains enctype=multipart/form-data, but does not contain method=post.  Submitting normally with method=GET and no enctype instead.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: guided_reports - run is stateless
Jonathan Druart [Tue, 13 Feb 2024 07:32:50 +0000 (08:32 +0100)]
Bug 34478: guided_reports - run is stateless

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - audio alerts
Kyle M Hall [Fri, 9 Feb 2024 16:08:49 +0000 (16:08 +0000)]
Bug 34478: Manual fix - audio alerts

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Clarify opac serial alert subscriptions
Martin Renvoize [Fri, 9 Feb 2024 14:37:07 +0000 (14:37 +0000)]
Bug 34478: Clarify opac serial alert subscriptions

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual - Replace link with submit button - circu-menu
Martin Renvoize [Fri, 9 Feb 2024 12:59:23 +0000 (12:59 +0000)]
Bug 34478: Manual - Replace link with submit button - circu-menu

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual - change to get and remove CSRF - boraccount
Martin Renvoize [Fri, 9 Feb 2024 12:41:25 +0000 (12:41 +0000)]
Bug 34478: Manual - change to get and remove CSRF - boraccount

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to GET - overdrive-checkout.inc
Nick Clemens [Fri, 9 Feb 2024 12:42:27 +0000 (07:42 -0500)]
Bug 34478: Manual fix - change to GET - overdrive-checkout.inc

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - convert link to form - boraccount.tt
Martin Renvoize [Fri, 9 Feb 2024 12:38:05 +0000 (12:38 +0000)]
Bug 34478: Manual fix - convert link to form - boraccount.tt

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get remove csrf token - installer/step2
Martin Renvoize [Fri, 9 Feb 2024 11:51:59 +0000 (11:51 +0000)]
Bug 34478: Manual fix - change to get remove csrf token - installer/step2

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get remove csrf token - installer/step1
Martin Renvoize [Fri, 9 Feb 2024 11:38:56 +0000 (11:38 +0000)]
Bug 34478: Manual fix - change to get remove csrf token - installer/step1

This form allows the user to select which language they wish to work
through the installer in, it doesn't update anything serverside.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get remove csrf token - barcode-print
Martin Renvoize [Fri, 9 Feb 2024 11:29:07 +0000 (11:29 +0000)]
Bug 34478: Manual fix - change to get remove csrf token - barcode-print

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get remove csrf token - downloadcard
Martin Renvoize [Fri, 9 Feb 2024 11:26:11 +0000 (11:26 +0000)]
Bug 34478: Manual fix - change to get remove csrf token - downloadcard

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add 'op' to reports/guided_reports - WIP
Jonathan Druart [Fri, 9 Feb 2024 11:23:59 +0000 (12:23 +0100)]
Bug 34478: Add 'op' to reports/guided_reports - WIP

Bug 34478: [TO SQUASH] Add 'op' to reports/guided_reports

Found bug 36071 when working on this. This is not a regression from this
patch.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add 'op' to sendbasketform
Martin Renvoize [Fri, 9 Feb 2024 11:23:35 +0000 (11:23 +0000)]
Bug 34478: Add 'op' to sendbasketform

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get remove csrf token - citites-admin-search
Martin Renvoize [Fri, 9 Feb 2024 11:19:43 +0000 (11:19 +0000)]
Bug 34478: Manual fix - change to get remove csrf token - citites-admin-search

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get remove csrf token - contracts-admin-search
Martin Renvoize [Fri, 9 Feb 2024 11:13:44 +0000 (11:13 +0000)]
Bug 34478: Manual fix - change to get remove csrf token - contracts-admin-search

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get remove csrf token - acquisitions-search
Martin Renvoize [Fri, 9 Feb 2024 11:12:04 +0000 (11:12 +0000)]
Bug 34478: Manual fix - change to get remove csrf token - acquisitions-search

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get remove csrf token - budgets-admin-search
Martin Renvoize [Fri, 9 Feb 2024 11:10:24 +0000 (11:10 +0000)]
Bug 34478: Manual fix - change to get remove csrf token - budgets-admin-search

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add 'op' to circ/renew.pl
Martin Renvoize [Fri, 9 Feb 2024 11:01:17 +0000 (11:01 +0000)]
Bug 34478: Add 'op' to circ/renew.pl

Added 'cud-renew' op check to circ/renew.pl and added corresponding op
params to:

* includes/renew-search-box.tt
* circ/renew.tt

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for labels/spinelabel-print.pl (no POST)
Marcel de Rooy [Fri, 9 Feb 2024 10:51:26 +0000 (10:51 +0000)]
Bug 34478: Changes for labels/spinelabel-print.pl (no POST)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for tools/cleanborrowers
Marcel de Rooy [Fri, 9 Feb 2024 10:48:12 +0000 (10:48 +0000)]
Bug 34478: Changes for tools/cleanborrowers

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get remove csrf token - member-search-box
Martin Renvoize [Fri, 9 Feb 2024 10:48:24 +0000 (10:48 +0000)]
Bug 34478: Manual fix - change to get remove csrf token - member-search-box

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get remove csrf token - preservation-search
Martin Renvoize [Fri, 9 Feb 2024 10:46:42 +0000 (10:46 +0000)]
Bug 34478: Manual fix - change to get remove csrf token - preservation-search

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get remove csrf token - letters-search
Martin Renvoize [Fri, 9 Feb 2024 10:45:05 +0000 (10:45 +0000)]
Bug 34478: Manual fix - change to get remove csrf token - letters-search

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get remove csrf token - patron-search-box
Martin Renvoize [Fri, 9 Feb 2024 10:42:29 +0000 (10:42 +0000)]
Bug 34478: Manual fix - change to get remove csrf token - patron-search-box

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: (QA follow-up) Rename change to delete
Marcel de Rooy [Fri, 9 Feb 2024 10:38:30 +0000 (10:38 +0000)]
Bug 34478: (QA follow-up) Rename change to delete

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for tools/upload
Marcel de Rooy [Fri, 9 Feb 2024 10:09:22 +0000 (10:09 +0000)]
Bug 34478: Changes for tools/upload

Required some more changes for mode to op, and delete form.
Most forms did not need a POST.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: (follow-up) Remove check_csrf from pl files
Jonathan Druart [Fri, 9 Feb 2024 10:02:51 +0000 (11:02 +0100)]
Bug 34478: (follow-up) Remove check_csrf from pl files

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for tools/stage-marc-import
Marcel de Rooy [Fri, 9 Feb 2024 09:02:57 +0000 (09:02 +0000)]
Bug 34478: Changes for tools/stage-marc-import

First form is ajax upload, no post needed.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for tools/import_borrowers
Marcel de Rooy [Fri, 9 Feb 2024 08:55:23 +0000 (08:55 +0000)]
Bug 34478: Changes for tools/import_borrowers

Removed a csrf check in script itself.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for tools/viewlog (no POST, just viewing)
Marcel de Rooy [Fri, 9 Feb 2024 08:45:06 +0000 (08:45 +0000)]
Bug 34478: Changes for tools/viewlog (no POST, just viewing)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for tools/upload-images
Marcel de Rooy [Fri, 9 Feb 2024 08:36:59 +0000 (08:36 +0000)]
Bug 34478: Changes for tools/upload-images

First upload form does not submit (ajax processing).

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for tools/scheduler
Marcel de Rooy [Fri, 9 Feb 2024 08:26:33 +0000 (08:26 +0000)]
Bug 34478: Changes for tools/scheduler

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for tools/holidays
Marcel de Rooy [Fri, 9 Feb 2024 08:14:32 +0000 (08:14 +0000)]
Bug 34478: Changes for tools/holidays

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for overduerules.tt (remove POST for branch selection)
Marcel de Rooy [Fri, 9 Feb 2024 08:04:13 +0000 (08:04 +0000)]
Bug 34478: Changes for overduerules.tt (remove POST for branch selection)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Changes for offline_circ
Marcel de Rooy [Fri, 9 Feb 2024 07:45:33 +0000 (07:45 +0000)]
Bug 34478: Changes for offline_circ

Removed an unused form from process_koc.tt and an unused
op from process_koc.pl.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get - reports
Jonathan Druart [Thu, 8 Feb 2024 11:16:07 +0000 (12:16 +0100)]
Bug 34478: Manual fix - change to get - reports

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: op =~ ^cud- - Manual - cud-do_it => do_it
Jonathan Druart [Thu, 8 Feb 2024 11:11:00 +0000 (12:11 +0100)]
Bug 34478: op =~ ^cud- - Manual - cud-do_it => do_it

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add 'op' to circ/branchtransfers
Jonathan Druart [Thu, 8 Feb 2024 11:06:55 +0000 (12:06 +0100)]
Bug 34478: Add 'op' to circ/branchtransfers

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get - circ/reserveratios
Jonathan Druart [Thu, 8 Feb 2024 10:54:32 +0000 (11:54 +0100)]
Bug 34478: Manual fix - change to get - circ/reserveratios

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add 'op' to cataloguing/merge
Jonathan Druart [Thu, 8 Feb 2024 10:44:57 +0000 (11:44 +0100)]
Bug 34478: Add 'op' to cataloguing/merge

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add 'op' to cataloguing/moveitem
Jonathan Druart [Thu, 8 Feb 2024 09:57:15 +0000 (10:57 +0100)]
Bug 34478: Add 'op' to cataloguing/moveitem

Bug 34478: [TO SQUASH] Add 'op' to cataloguing/moveitem

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add 'op' to catalogue/MARCdetail
Jonathan Druart [Thu, 8 Feb 2024 09:19:07 +0000 (10:19 +0100)]
Bug 34478: Add 'op' to catalogue/MARCdetail

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add 'op' to authorities/merge
Jonathan Druart [Thu, 8 Feb 2024 08:56:39 +0000 (09:56 +0100)]
Bug 34478: Add 'op' to authorities/merge

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Replace forms with links - authorities/authorities
Jonathan Druart [Thu, 8 Feb 2024 08:50:12 +0000 (09:50 +0100)]
Bug 34478: Replace forms with links - authorities/authorities

Bug 34478: [TO SQUASH] Replace forms with links - authorities/authorities

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add 'op' to admin/marc-overlay-rules
Jonathan Druart [Wed, 7 Feb 2024 16:02:14 +0000 (17:02 +0100)]
Bug 34478: Add 'op' to admin/marc-overlay-rules

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add 'op' to tags/review
Jonathan Druart [Wed, 7 Feb 2024 15:19:19 +0000 (16:19 +0100)]
Bug 34478: Add 'op' to tags/review

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add 'op' to admin/smart-rules
Jonathan Druart [Wed, 7 Feb 2024 14:34:07 +0000 (15:34 +0100)]
Bug 34478: Add 'op' to admin/smart-rules

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: (follow-up) Remove POST from sru_modmapping templates
Marcel de Rooy [Wed, 7 Feb 2024 13:38:44 +0000 (13:38 +0000)]
Bug 34478: (follow-up) Remove POST from sru_modmapping templates

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Remove 'Delete' link for news on the homepage
Jonathan Druart [Wed, 7 Feb 2024 10:56:15 +0000 (11:56 +0100)]
Bug 34478: Remove 'Delete' link for news on the homepage

This should not be a link but a POST instead. Simply removing it for
now, we will reintroduce it later if there is a need for that.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Fix circ/set-library
Jonathan Druart [Wed, 7 Feb 2024 10:25:01 +0000 (11:25 +0100)]
Bug 34478: Fix circ/set-library

Why do not we simply redirect instead of POSTing?

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get - circ/branchoverdues
Jonathan Druart [Wed, 7 Feb 2024 09:39:34 +0000 (10:39 +0100)]
Bug 34478: Manual fix - change to get - circ/branchoverdues

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get - circ/curbside_pickups
Jonathan Druart [Wed, 7 Feb 2024 09:34:53 +0000 (10:34 +0100)]
Bug 34478: Manual fix - change to get - circ/curbside_pickups

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get - circ/article-requests
Jonathan Druart [Wed, 7 Feb 2024 09:32:12 +0000 (10:32 +0100)]
Bug 34478: Manual fix - change to get - circ/article-requests

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add 'op' to serials/subscription-batchedit
Jonathan Druart [Wed, 7 Feb 2024 09:27:43 +0000 (10:27 +0100)]
Bug 34478: Add 'op' to serials/subscription-batchedit

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get - serials/claims
Jonathan Druart [Wed, 7 Feb 2024 09:24:46 +0000 (10:24 +0100)]
Bug 34478: Manual fix - change to get - serials/claims

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Replace form with div - serials/serials-search
Jonathan Druart [Wed, 7 Feb 2024 09:22:23 +0000 (10:22 +0100)]
Bug 34478: Replace form with div - serials/serials-search

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Manual fix - change to get - serials/acqui-search
Jonathan Druart [Wed, 7 Feb 2024 09:00:28 +0000 (10:00 +0100)]
Bug 34478: Manual fix - change to get - serials/acqui-search

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Replace form with div - catalogue/result / z39.50/SRU search
Jonathan Druart [Wed, 7 Feb 2024 08:52:19 +0000 (09:52 +0100)]
Bug 34478: Replace form with div - catalogue/result / z39.50/SRU search

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add test to catch missing op in POST forms
Jonathan Druart [Wed, 7 Feb 2024 08:16:33 +0000 (09:16 +0100)]
Bug 34478: Add test to catch missing op in POST forms

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add op to reports/dictionary
Jonathan Druart [Tue, 6 Feb 2024 15:52:45 +0000 (16:52 +0100)]
Bug 34478: Add op to reports/dictionary

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add missing CSRF token to acqui/basket.tt
Jonathan Druart [Tue, 6 Feb 2024 15:31:59 +0000 (16:31 +0100)]
Bug 34478: Add missing CSRF token to acqui/basket.tt

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Remove form from preferences.tt
Jonathan Druart [Tue, 6 Feb 2024 15:29:52 +0000 (16:29 +0100)]
Bug 34478: Remove form from preferences.tt

We don't need a form here, it's never submitted

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Fix opac-tags and tags/lists
Jonathan Druart [Tue, 6 Feb 2024 14:54:38 +0000 (15:54 +0100)]
Bug 34478: Fix opac-tags and tags/lists

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Add csrf-token in meta
Jonathan Druart [Tue, 6 Feb 2024 14:54:32 +0000 (15:54 +0100)]
Bug 34478: Add csrf-token in meta

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Fix shelf transfer
Jonathan Druart [Tue, 6 Feb 2024 11:07:08 +0000 (12:07 +0100)]
Bug 34478: Fix shelf transfer

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Shorten output of xt/find-missing-csrf.t
Jonathan Druart [Tue, 6 Feb 2024 10:36:22 +0000 (11:36 +0100)]
Bug 34478: Shorten output of xt/find-missing-csrf.t

To make it more readable.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Fix xt/find-missing-csrf.t
Jonathan Druart [Tue, 6 Feb 2024 10:26:05 +0000 (11:26 +0100)]
Bug 34478: Fix xt/find-missing-csrf.t

It was reporting false positives.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: Move compatibility code
Pedro Amorim [Tue, 6 Feb 2024 10:25:45 +0000 (09:25 -0100)]
Bug 34478: Move compatibility code

All ILL backend retrocompatibility code has been moved to Illrequest.pm:get_op_param_deprecation for isolation and clarity

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
7 months agoBug 34478: ILL INTRA: query_type => op
Pedro Amorim [Tue, 6 Feb 2024 10:05:19 +0000 (10:05 +0000)]
Bug 34478: ILL INTRA: query_type => op

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>