From d9be17863ab83648e4f2838d162ed7274a5f4032 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 6 Sep 2024 11:42:09 +0000 Subject: [PATCH] Bug 37848: Fix "Run with template" dropdown menu style This patch adds the missing "dropdown-item" class to the "Run with template" dropdown menu markup in order to correct the menu's style. The patch also adds a template ID to the menu items' id attributes so that we don't have duplicate IDs. To test, apply the patch and go to Tools -> Notices. (testing steps copied from Bug 36157) 1. Create a notice with the module of "Reports" -- add something to the "Print" section. Example from the other bug: [% FOREACH b IN data %]
[% b.surname %], [% b.firstname %]
Expiration: [% b.dateexpiry %]
ID: [% b.borrowernumber %]
[% END %] 2. Create and run a saved report. Example from bug 36157: SELECT * FROM borrowers 3. Click on the "Run with template" dropdown and confirm that it is styled correctly. 4. Click to run the report with the template and confirm that it works correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize --- koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc index 727b7eaa14..525a558ecf 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc @@ -78,7 +78,7 @@