From a73d45534fe578ab3b425506aa5701ecb36065d9 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Mon, 2 Jul 2018 16:18:33 -0300 Subject: [PATCH] Bug 20942: (QA follow-up) Use $lines->total_outstanding This patch makes the controller code use $lines->total_outstanding instead of expecting ->outstanding_debits and ->outstanding_credits return the total. Tests should pass as before. No behaviour change is expected. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests still pass, no behaviour change. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens (cherry picked from commit 6672b26d16065d877d6d7300830fc3d619b09898) Signed-off-by: Martin Renvoize --- Koha/REST/V1/Patrons/Account.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Koha/REST/V1/Patrons/Account.pm b/Koha/REST/V1/Patrons/Account.pm index 2003bde234..a431998628 100644 --- a/Koha/REST/V1/Patrons/Account.pm +++ b/Koha/REST/V1/Patrons/Account.pm @@ -50,19 +50,19 @@ sub get { $balance->{balance} = $account->balance; - # get outstanding debits - my ( $debits_total, $debits ) = $account->outstanding_debits; - my ( $credits_total, $credits ) = $account->outstanding_credits; + # get outstanding debits and credits + my $debits = $account->outstanding_debits; + my $credits = $account->outstanding_credits; my @debit_lines = map { _to_api( $_->TO_JSON ) } @{ $debits->as_list }; $balance->{outstanding_debits} = { - total => $debits_total, + total => $debits->total_outstanding, lines => \@debit_lines }; my @credit_lines = map { _to_api( $_->TO_JSON ) } @{ $credits->as_list }; $balance->{outstanding_credits} = { - total => $credits_total, + total => $credits->total_outstanding, lines => \@credit_lines }; -- 2.39.5